February 2018 - Koha-bugs - lists.koha-community.org

[Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '18

02 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52310|0 |1 is obsolete| | Attachment #52311|0 |1 is obsolete| | Attachment #52312|0 |1 is obsolete| | --- Comment #28 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 71148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71148&action=ed… Bug 14364 - Allow automatically canceled expired waiting holds to fill the next hold Right now, if a library automatically cancels expired waiting holds, a librarian must still re-checkin an item to trap the next available hold for that item. It would be better if the next hold was automatically trapped and the librarians receive an email notification so they can make any changes to the item if need be ( hold area, hold slip in item, etc ). Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a record with one item 4) Place two holds on that record 5) Check in the item and set it to waiting for the first patron 6) Set ReservesMaxPickUpDelay to 1 7) Enable ExpireReservesMaxPickUpDelay 8) Enable ExpireReservesAutoFill 9) Set an email address in ExpireReservesAutoFillEmail 10) Modify the holds waitingdate to be in the past 11) Run misc/cronjobs/holds/cancel_expired_holds.pl 12) Note the hold is now waiting for the next patron 12) Note a waiting hold notification email was sent to that patron 13) Note a hold changed notification email was sent to the library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '18

02 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9607] pagination wrong if OPACShowUnusedAuthorities set to "don't show"
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '18

02 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9607 Marjorie Barry-Vila <marjorie.barry-vila(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10455] remove redundant 'biblioitems.marc' field
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '18

02 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 --- Comment #55 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #54) > This change has interesting side-effects ! > > - $sth = $dbh->prepare("UPDATE biblioitems SET marc=?,marcxml=? WHERE > biblionumber=?"); > - $sth->execute( $record->as_usmarc(), $record->as_xml_record($encoding), > $biblionumber ); > + $sth = $dbh->prepare("UPDATE biblioitems SET marcxml=? WHERE > biblionumber=?"); > + $sth->execute( $record->as_xml_record($encoding), $biblionumber ); > > It seems that since we do no longer call the sub as_usmarc, the automatic > field lengths in the marc are not calculated anymore. > This needs our attention. Will open a new report now! Trivial fix submitted. Please have a look and sign off. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10455] remove redundant 'biblioitems.marc' field
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '18

02 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20126 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20126 [Bug 20126] Saving a biblio does no longer update MARC field lengths -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10455] remove redundant 'biblioitems.marc' field
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '18

02 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10455 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #54 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- This change has interesting side-effects ! - $sth = $dbh->prepare("UPDATE biblioitems SET marc=?,marcxml=? WHERE biblionumber=?"); - $sth->execute( $record->as_usmarc(), $record->as_xml_record($encoding), $biblionumber ); + $sth = $dbh->prepare("UPDATE biblioitems SET marcxml=? WHERE biblionumber=?"); + $sth->execute( $record->as_xml_record($encoding), $biblionumber ); It seems that since we do no longer call the sub as_usmarc, the automatic field lengths in the marc are not calculated anymore. This needs our attention. Will open a new report now! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '18

02 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #38 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Has been tested already before, spent sufficient time on changes now. Looks good to me. No blocker, but slightly confusing in staff checkouts table: 0 Renewal denied by syspref (10 of 10 renewals remaining) If I can't renew, what is the value of these 10? :) Passed QA with follow-up for some minor issues. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '18

02 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71133|0 |1 is obsolete| | --- Comment #37 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 71138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71138&action=ed… Bug 15494: (QA follow-up) Additional polishing [1] Fix two typos in Circulation.t. Although the test does not fail, line 2127 contains two typos. Changing INVISILE to INVISIBLE :) And type should be itype. [2] Remove $yaml as leftover from older code. [3] Add a next when the split on /:/ does not give two results. This will prevent uninit warnings (although still disabled now in Circulation). [4] For the same reason we should switch the lines for NULL and empty string. The undefs you insert should trigger a warn. [5] The line for empty string should not insert undef, but empty string. For the same reason adding the condition defined($_) ... And proving it by adding two tests for the opposite values of callnumber and itemnotes. [6] Adding a strip spaces around the fieldname. User friendly.. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '18

02 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71132|0 |1 is obsolete| | --- Comment #36 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 71137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71137&action=ed… Bug 15494 - Add syspref Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '18

02 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71131|0 |1 is obsolete| | --- Comment #35 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 71136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71136&action=ed… Bug 15494 - Update display of renewal errors To test: 1 - Define a rule to deny renewal 2 - Checkout an item meeting this rule 3 - Attempt renew an item via the OPAC 4 - Attempt renewal via SIP 5 - Attempt renewal via staff client 6 - Verify errors are reasonable Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0