February 2018 - Koha-bugs - lists.koha-community.org

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '18

02 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71133|0 |1 is obsolete| | --- Comment #37 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 71138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71138&action=ed… Bug 15494: (QA follow-up) Additional polishing [1] Fix two typos in Circulation.t. Although the test does not fail, line 2127 contains two typos. Changing INVISILE to INVISIBLE :) And type should be itype. [2] Remove $yaml as leftover from older code. [3] Add a next when the split on /:/ does not give two results. This will prevent uninit warnings (although still disabled now in Circulation). [4] For the same reason we should switch the lines for NULL and empty string. The undefs you insert should trigger a warn. [5] The line for empty string should not insert undef, but empty string. For the same reason adding the condition defined($_) ... And proving it by adding two tests for the opposite values of callnumber and itemnotes. [6] Adding a strip spaces around the fieldname. User friendly.. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '18

02 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71132|0 |1 is obsolete| | --- Comment #36 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 71137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71137&action=ed… Bug 15494 - Add syspref Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '18

02 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71131|0 |1 is obsolete| | --- Comment #35 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 71136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71136&action=ed… Bug 15494 - Update display of renewal errors To test: 1 - Define a rule to deny renewal 2 - Checkout an item meeting this rule 3 - Attempt renew an item via the OPAC 4 - Attempt renewal via SIP 5 - Attempt renewal via staff client 6 - Verify errors are reasonable Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '18

02 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71130|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 71135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71135&action=ed… Bug 15494 - Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '18

02 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71129|0 |1 is obsolete| | --- Comment #33 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 71134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71134&action=ed… Bug 15494 - Unit tests prove -v t/db_dependent/Circulation.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '18

02 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #32 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 71133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71133&action=ed… Bug 15494: (QA follow-up) Additional polishing [1] Fix two typos in Circulation.t. Although the test does not fail, line 2127 contains two typos. Changing INVISILE to INVISIBLE :) And type should be itype. [2] Remove $yaml as leftover from older code. [3] Add a next when the split on /:/ does not give two results. This will prevent uninit warnings (although still disabled now in Circulation). [4] For the same reason we should switch the lines for NULL and empty string. The undefs you insert should trigger a warn. [5] The line for empty string should not insert undef, but empty string. For the same reason adding the condition defined($_) ... And proving it by adding two tests for the opposite values of callnumber and itemnotes. [6] Adding a strip spaces around the fieldname. User friendly.. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '18

02 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #31 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 71132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71132&action=ed… Bug 15494 - Add syspref -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '18

02 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #30 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 71131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71131&action=ed… Bug 15494 - Update display of renewal errors To test: 1 - Define a rule to deny renewal 2 - Checkout an item meeting this rule 3 - Attempt renew an item via the OPAC 4 - Attempt renewal via SIP 5 - Attempt renewal via staff client 6 - Verify errors are reasonable Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '18

02 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #29 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 71130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71130&action=ed… Bug 15494 - Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '18

02 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70629|0 |1 is obsolete| | Attachment #70630|0 |1 is obsolete| | Attachment #70631|0 |1 is obsolete| | Attachment #70632|0 |1 is obsolete| | --- Comment #28 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 71129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71129&action=ed… Bug 15494 - Unit tests prove -v t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.

1 0