March 2018 - Koha-bugs - lists.koha-community.org

[Bug 11317] Add a way to access files from the intranet
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '18

28 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #132 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- The use case for us would be to allow access to files generated on the server - not logs, but print notices. They contain patron information, so you need to secure them behind login. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17941] New: CanBookBeRenewed is very inefficient/slow
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '18

28 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 Bug ID: 17941 Summary: CanBookBeRenewed is very inefficient/slow Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: boutrosboutrosboutros(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com I started investigating why populating the checkout list in the patron view sometimes took ages (minutes), and on occations even causing the system to almost halt because of DB overload. It turned out that reason is calls to C4::Circulation::CanBookBeRenewed. The critical factor is whether an item has many holds on it, and if there are many items that can fill the hold. Briefly looking at the code it seems obvious that the time spent grows exponentially with the number of holds and items. As one example, checking if an item with 111 holds (and 12 items on the biblio) can be renewed takes around 25 sec and generates over 18,000 SQL queries. I can't help to think there must be some missed "early returns" opportunities in the loops somewhere. For example, if there are more unfulfilled holds than available items, can the item ever be renewed? If no, return before even begin to calculate.. However, I know holds are full of complexities and things I probably haven't thought about so I need to dig into the code more. I would be very gratefull if anyone knowledgeable about this part of the code could help me find some ways to optimize this! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 54

[Bug 11317] Add a way to access files from the intranet
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '18

28 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_05_candidate Status|Passed QA |Failed QA --- Comment #131 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- 1. Not unicode proof, create a file named "❤" in your accessdir and boom: Can't call method "mtime" on an undefined value at /home/vagrant/kohaclone/tools/access_files.pl line 61. 2. Please rename accessdir with access_dir 3. Can we get an up-to-date and complete test plan? 4. Why do not we have a default value for accessdir? 5. What is the main purpose of this development? How do we want to advert it? Still log files? 6. Did someone test with very big files (see bug 8437)? Should we put a limit? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15115] Editing item information on active course reserves should not be allowed.
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '18

28 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15115 --- Comment #1 from Jessie Zairo <jzairo(a)bywatersolutions.com> --- This is still an active issue. Some libraries face massive updates to reserves when switching terms to update items in course reserves module. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 20145] New: borrowers.datexpiry eq '0000-00-00' means expired?
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '18

28 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20145 Bug ID: 20145 Summary: borrowers.datexpiry eq '0000-00-00' means expired? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org See bug http://lists.koha-community.org/pipermail/koha-devel/2018-February/044322.h… Koha::Patron->is_expired returns 0 if $self->dateexpiry eq '0000-00-00' And there is a test I wrote for it on bug 17578 (commit 5a0a2ce584dec74808f471b0f92b2114c3d6029e , GetMemberDetails - Remove is_expired) But then we also have, in C4::Circulation::CanBookBeIssued: 752 if ( !defined $patron->dateexpiry || $patron->dateexpiry eq '0000-00-00') { 753 $issuingimpossible{EXPIRED} = 1; 754 } else { With a test: is( $issuingimpossible->{EXPIRED}, 1, 'The patron should be considered as expired if dateexpiry is 0000-00-00' ); So, my questions, do you have a very old Koha installations to search if there is borrowers.is_expired == "0000-00-00" in it? Do you remember if it meant expired or not at some point? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 9164] Only allow kohaadmin login under special conditions
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '18

28 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9164 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20489 CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13802] Renewals ignore hard due dates
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '18

28 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13802 Marjorie Barry-Vila <marjorie.barry-vila(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '18

28 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #57 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Rebased (last patch only) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '18

28 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72404|0 |1 is obsolete| | --- Comment #56 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 73389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73389&action=ed… Bug 14769: (Follow-up) Let blinddetail look at indicator values If the indicators are not controlled, blinddetail should not overwrite what the user already entered. Very strictly seen, we could say that it is outside the scope. But it is strongly related. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Tested with 100 and 600 in the cataloging editor. For 100 the second indicator should not be overwritten. For 600 it should. Also tested "ind2:" which should blank ind2. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15032] [Plack] Scripts that fork (like stage-marc-import.pl) don't work as expected
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '18

28 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20342 -- You are receiving this mail because: You are watching all bug changes.

1 0