March 2018 - Koha-bugs - lists.koha-community.org

[Bug 14407] Limit web-based self-checkout to specific IP addresses
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 --- Comment #44 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 70476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70476 Bug 14407: Unit tests for in_ipset Review of attachment 70476: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=144…) ----------------------------------------------------------------- ::: t/Auth.t @@ +18,5 @@ > +use Modern::Perl; > +use Test::More tests => 10; > + > +use C4::Auth qw / in_ipset /; > +use warnings; Modern::Perl should cover the use warnings situation. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20479 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20479 [Bug 20479] Superlibrarians cannot log into opac -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20387] New: There is no calendar on first acquisition, subscrition start and end
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20387 Bug ID: 20387 Summary: There is no calendar on first acquisition, subscrition start and end Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: hagud(a)orex.es QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com The calendar template is missing when creating a serial and defining a start date, end date and first time acquisition /cgi-bin/koha/serials/subscription-add.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 19468] New: Can't create basket in acquisitions
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19468 Bug ID: 19468 Summary: Can't create basket in acquisitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Depends on: 15685 When trying to create a new basket in acq, I get an internal server error: Can't call method "unblessed" on an undefined value at /home/vagrant/kohaclone/C4/Acquisition.pm line 829. I think this might be a side effect of the recently pushed bug 15685. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 5

[Bug 19695] New: Uncertain prices should not use find in list context
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19695 Bug ID: 19695 Summary: Uncertain prices should not use find in list context Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: stefan.berndtsson(a)ub.gu.se QA Contact: testopia(a)bugs.koha-community.org When clicking on Uncertain prices button from a basket, the log fails with the following message: Cannot use "->find" in list context at <path>/acqui/uncertainprice.pl line 76. Similar to Bug 18179. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 10

[Bug 20466] New: Incorrect fixtures for active currency in t/Prices.t
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20466 Bug ID: 20466 Summary: Incorrect fixtures for active currency in t/Prices.t Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Found by jenkins on https://jenkins.koha-community.org/job/Koha_Master_D8/401/console # Failed test 'No tests run for subtest "Configuration 1: 0 0"' # at t/Prices.t line 152. Can't call method "p_sep_by_space" on an undefined value at /home/vagrant/kohaclone/Koha/Number/Price.pm line 126. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 20367] New: userid resets to firstname.surname when BorrowerUnwantedField contains userid
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20367 Bug ID: 20367 Summary: userid resets to firstname.surname when BorrowerUnwantedField contains userid Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: lari.taskula(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com To replicate: 1. In staff client, set your username to firstname 2. Add userid to BorrowerUnwantedField system preference 3. Go to your patron modification screen (memberentry.pl) and click Save 4. Observe you get kicked out into login screen, saying: Error: You do not have permission to access this page. Log in as a different user -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 11

[Bug 20348] New: SIP2 patron identification fails to use userid
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20348 Bug ID: 20348 Summary: SIP2 patron identification fails to use userid Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: jose.i.martin.cuesta(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com The following code in C4/SIP/ILS/Patron.pm: $kp = Koha::Patrons->find( { cardnumber => $patron_id } ) or Koha::Patrons->find( { userid => $patron_id } ); should be (using || instead of or): $kp = Koha::Patrons->find( { cardnumber => $patron_id } ) || Koha::Patrons->find( { userid => $patron_id } ); It will never try to match a patron by userid. This is a bug according to Perl documentation here: https://perldoc.perl.org/perlop.html#Logical-or-and-Exclusive-Or -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 20303] New: Receive order fails if no "authorised_by" value
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20303 Bug ID: 20303 Summary: Receive order fails if no "authorised_by" value Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: bc(a)interleaf.ie QA Contact: testopia(a)bugs.koha-community.org If there is no "authorised by" value on the order the "receive" option fails with 500 error. The file called is orderreceive.pl?ordernumber=1234&invoiceid=1234 orderreceive.pl should check if authorised_by exists before looking up patron information. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13

[Bug 20167] New: Item hold is set to bibliographic hold when changing pickup location
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20167 Bug ID: 20167 Summary: Item hold is set to bibliographic hold when changing pickup location Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: stefan.berndtsson(a)ub.gu.se QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com If a patron has an item level hold with pickup location set to library A and staff then (via the Holds tab in the patron view) changes pickup location to library B, itemnumber is lost from the hold. This is a definite problem when the items within a bibliographic record are different things (separate volumes for example). This can be fixed by adding some code in Koha/REST/V1/Hold.pm This bit before the ModReserve call: if($hold->itemnumber()) { $params->{itemnumber} = $hold->itemnumber(); } However, given the FIXME comment in C4/Reserves.pm for ModReserve, I'm wondering if this is the desired fix: "Note that the forgoing can have the effect of causing item-level hold requests to turn into title-level requests. This will be fixed once reserves has separate columns for requested itemnumber and supplying itemnumber." A different method of solving this issue could be to provide itemnumber as part of the pickup-location-change call instead and keep the rest of the REST-API and ModReserve the way it works now. I'm somewhat unfamiliar with the how the Mojolicious system works, so I haven't looked into that method yet. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17