March 2018 - Koha-bugs - lists.koha-community.org

[Bug 8685] Inventory tool fails in timeout with large CB files
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '18

28 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685 --- Comment #14 from Mason James <mtj(a)kohaaloha.com> --- a temporary workaround for this issue is to increase the apache TimeOut variable to something large.. like 900 (or more) https://httpd.apache.org/docs/current/mod/core.html#timeout 900 seconds = 15 minutes, apache's default is 60 you can add the 'Timeout 900' line to your apache.conf (global) ..but you probably just want to add the line inside your Koha intranet vhost(s) we've been running this fix on prod without any problems -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8685] Inventory tool fails in timeout with large CB files
by bugzilla-daemon＠bugs.koha-community.org 28 Mar '18

28 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685 Mason James <mtj(a)kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj(a)kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15336] Script for merging vendors
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Comment #42 is|1 |0 private| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15336] Script for merging vendors
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 --- Comment #43 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- 14:27 < tcohen> and I don't like code 'dying' instead of raising exceptions 14:29 < tcohen> I think rollback+exception should take place in the lib, because the controller should consider the API call an atomic action, that can fail -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15336] Script for merging vendors
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #42 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- 14:27 < tcohen> I agree with you on 20446 14:27 < tcohen> and I don't like code 'dying' instead of raising exceptions 14:29 < tcohen> I think rollback+exception should take place in the lib, because the controller should consider the API call an atomic action, that can fail -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15336] Script for merging vendors
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen(a)gmail.com Status|Passed QA |In Discussion --- Comment #41 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Alex Arnaud from comment #33) > (In reply to Jonathan Druart from comment #31) > > I do not understand why you put the transaction in the pl and not in the > > method, are there any good reasons? > > My opinion is that commit or rollback should not take place in the API. As > Katrin asked, we could use merge_with to add this feature on the GUI. In > this case, what is point to have the transaction in there ? Will we offer > the ability to "test" before confirm on the GUI ? Tomas, Can I get your opinion on this please? I am expecting the whole move to be done in a transaction (handled by the method) and an exception raised if something failed. The dry-run mode could be done using nested transactions. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14407] Limit web-based self-checkout to specific IP addresses
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 --- Comment #53 from M. Tompsett <mtompset(a)hotmail.com> --- The question is does the in_ipset return the correct value for bad ranges? Because currently, it assumes open when a bad range is provided. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14407] Limit web-based self-checkout to specific IP addresses
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73318|0 |1 is obsolete| | --- Comment #52 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 73342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73342&action=ed… Bug 14407: Follow up to add test case and clean noise Comment #28 has a /36 which is invalid CIDR. This triggers a crash and noise. This cleans up the crash and noise, and adds test cases to check for them. prove t/Auth.t -- before missing null case, and /36 case. -- after null case, and /36 with/without warnings. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14407] Limit web-based self-checkout to specific IP addresses
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73316|0 |1 is obsolete| | --- Comment #51 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 73341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73341&action=ed… Bug 14407: Follow up add missing atomic update The patch only added the system preference for fresh installs. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14407] Limit web-based self-checkout to specific IP addresses
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70476|0 |1 is obsolete| | --- Comment #50 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 73340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73340&action=ed… Bug 14407: Unit tests for in_ipset TEST PLAN --------- 1) apply all pathches 2) sudo koha-shell -c bash kohadev prove t/Auth.t -- should run. 3) run koha qa test tools Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0