March 2018 - Koha-bugs - lists.koha-community.org

[Bug 15336] Script for merging vendors
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen(a)gmail.com Status|Passed QA |In Discussion --- Comment #41 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Alex Arnaud from comment #33) > (In reply to Jonathan Druart from comment #31) > > I do not understand why you put the transaction in the pl and not in the > > method, are there any good reasons? > > My opinion is that commit or rollback should not take place in the API. As > Katrin asked, we could use merge_with to add this feature on the GUI. In > this case, what is point to have the transaction in there ? Will we offer > the ability to "test" before confirm on the GUI ? Tomas, Can I get your opinion on this please? I am expecting the whole move to be done in a transaction (handled by the method) and an exception raised if something failed. The dry-run mode could be done using nested transactions. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14407] Limit web-based self-checkout to specific IP addresses
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 --- Comment #53 from M. Tompsett <mtompset(a)hotmail.com> --- The question is does the in_ipset return the correct value for bad ranges? Because currently, it assumes open when a bad range is provided. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14407] Limit web-based self-checkout to specific IP addresses
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73318|0 |1 is obsolete| | --- Comment #52 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 73342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73342&action=ed… Bug 14407: Follow up to add test case and clean noise Comment #28 has a /36 which is invalid CIDR. This triggers a crash and noise. This cleans up the crash and noise, and adds test cases to check for them. prove t/Auth.t -- before missing null case, and /36 case. -- after null case, and /36 with/without warnings. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14407] Limit web-based self-checkout to specific IP addresses
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73316|0 |1 is obsolete| | --- Comment #51 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 73341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73341&action=ed… Bug 14407: Follow up add missing atomic update The patch only added the system preference for fresh installs. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14407] Limit web-based self-checkout to specific IP addresses
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70476|0 |1 is obsolete| | --- Comment #50 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 73340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73340&action=ed… Bug 14407: Unit tests for in_ipset TEST PLAN --------- 1) apply all pathches 2) sudo koha-shell -c bash kohadev prove t/Auth.t -- should run. 3) run koha qa test tools Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14407] Limit web-based self-checkout to specific IP addresses
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70475|0 |1 is obsolete| | --- Comment #49 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 73339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73339&action=ed… Bug 14407: Allow restricting SCO to IP or IP range Converted this to actual applicable patches. I think the test plan is comment #28. -- Mark Tompsett Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14407] Limit web-based self-checkout to specific IP addresses
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 --- Comment #48 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Marc Véron from comment #28) > - Set SelfCheckAllowByIPRanges to 192.168.1.1 192.168.1.0/36 > as described for syspref SelfCheckAllowByIPRanges > Internal Server Error > Plack error log says; > 36, as in '192.168.1.30/36', does not make sense at > /home/marc/koha/C4/Auth.pm line 2058. > > Is it a bug or a wrong description for SelfCheckAllowByIPRanges? 36 is not valid. 8+8+8+8 = 32. Why would you have a number bigger than 32 on an IPv4 address? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14407] Limit web-based self-checkout to specific IP addresses
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 --- Comment #47 from M. Tompsett <mtompset(a)hotmail.com> --- kohadevbox is triggered from 192.168.50.1, so testing 192.168.0.0/16 worked nicely. :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20045] New: Switch single-column templates to Bootstrap grid: Various
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20045 Bug ID: 20045 Summary: Switch single-column templates to Bootstrap grid: Various Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: dcook(a)prosentient.com.au, josef.moravec(a)gmail.com, misilot(a)fit.edu, nengard(a)gmail.com, testopia(a)bugs.koha-community.org Blocks: 19980 This patch will convert several unrelated templates to use the Bootstrap grid: - about.tt - auth.tt - serials/subscription-add.tt - admin/admin-home.tt - reports/reports-home.tt - suggestion/suggestion.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '18

27 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 --- Comment #50 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Test in C4::Auth does not test if the AutoSelfCheckID patron has self_checkout_module permission: 185 if ( 186 # If the user logged in is the SCO user and they try to go out of the SCO module, 187 # log the user out removing the CGISESSID cookie 188 $in->{template_name} !~ m|sco/| 189 && $user 190 && C4::Context->preference('AutoSelfCheckID') 191 && $user eq C4::Context->preference('AutoSelfCheckID') 192 ) 193 { 194 $kick_out = 1; 195 } -- You are receiving this mail because: You are watching all bug changes.

1 0