April 2018 - Koha-bugs - lists.koha-community.org

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72981|0 |1 is obsolete| | --- Comment #85 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 74783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74783&action=ed… Bug 12747 - Add extra column in Z3950 search This is a complete squash of previous patches, with additional code quality improvments following M. Tompsett's feedback. Squashing was done (as suggested) because many lines add be added and subsequently deleted, which made for confusing patches. New changes: * Major enhancement to _add_custom_rowdata(), as suggested by QA. The $_ variable is no longer used (at all), and the split() routine is used. * t/db_dependent/Breeding.t now uses the mocked preference logic to avoid sysprefs being affected. Functionality and test plan have not changed. -- This patch makes it possible to add an extra column to Z3950 search results. The system preference AdditionalFieldsInZ3950ResultSearch maps which MARC field/subfields are displayed in the column. Testing: I Apply the patch II Run updatedatabase.pl ACQUISITIONS 0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch 1) Create a new basket or use an existing one 2) In -Add order to basket-, click "From an external source" 3) Select some search targets and enter a subject heading ex. house 4) Click Search bouton 5) Validate "Additional fields" column with the field/subfield value. CATALOGUING 0) Shares same syspref as above 1) Go to cataloguing, click New from z3950 2) Fill to result in a successful search 3) Validate column Addition Fields Sponsored-by: CCSR (https://ccsr.qc.ca) Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #9 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 74782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74782&action=ed… Bug 12159: Add tests Test plan: prove t/db_dependent/Koha/Patron/Attributes.t t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73018|0 |1 is obsolete| | Attachment #73019|0 |1 is obsolete| | --- Comment #8 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 74781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74781&action=ed… Bug 12159: Fix getting extended patron attributes for circ-menu Changes: - Replace getting preference ExtendedPatronAttributes by Koha.Preference in templates - Add Koha::Patron->attributes for getting patrons extended attributes - Use this method in circ-menu.inc - Remove getting attributes from members perl scripts Test plan: 0) Apply the patch 1) Add some patron attributes type - with free text, authorised value, limited by libraries... 2) Add some values to this attributes for some patrons 3) Go through as many patron pages as you can and confirm that attributes are shown at side panel when they shoul and are not shown when they should not be shown -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune(a)bulac.fr Status|Needs Signoff |Patch doesn't apply --- Comment #7 from Séverine Queune <severine.queune(a)bulac.fr> --- I couldn't apply the patch on master branch (17.12.00.037) : Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 12159: Fix getting extended patron attributes for circ-menu Using index info to reconstruct a base tree... M Koha/Patron.pm M circ/circulation.pl M koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc M koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt M koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt M koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt M members/boraccount.pl M members/member-flags.pl M members/memberentry.pl M members/moremember.pl M members/paycollect.pl Falling back to patching base and 3-way merge... Auto-merging members/paycollect.pl Auto-merging members/moremember.pl Auto-merging members/memberentry.pl Auto-merging members/member-flags.pl Auto-merging members/boraccount.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc Auto-merging circ/circulation.pl Auto-merging Koha/Patron.pm CONFLICT (content): Merge conflict in Koha/Patron.pm Failed to merge in the changes. Patch failed at 0001 Bug 12159: Fix getting extended patron attributes for circ-menu The copy of the patch that failed is found in: /var/repositories/koha/.git/rebase-apply/patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11909] Fix hidelostitems, OpacHiddenItems total count, prog them facet display
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11909 --- Comment #17 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Hugh Rundle from comment #16) > Hmm, I've tested this again and you're right. Possibly we had a local > caching issue. Apologies for the red herring! Np, glad it works! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19908] New: Password should not be mandatory
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Bug ID: 19908 Summary: Password should not be mandatory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When password is not set as a mandatory patron field, it should not be required. To test: - make sure BorrowerMandatoryField is empty and doesn't list password - add a new patron, leave password fields empty - try to save - you will be forced to enter a password with the field now being highlighted as required. I have also tried changing RequireStrongPassword and emptying minPasswordLength. Often libraries will leave password and username empty for patrons that won't ever use the OPAC. For example when they are not using the OPAC functionalities in general or for internal users. Making the password mandatory is a regression to former behaviour. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 47

[Bug 11936] Consistent log message for item insert
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick(a)bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #11 from Nick Clemens <nick(a)bywatersolutions.com> --- Awesome work all, backported to stable for 17.11.05 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19946] New: Update popup window templates to use Bootstrap grid: Authority Z39.50 search
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946 Bug ID: 19946 Summary: Update popup window templates to use Bootstrap grid: Authority Z39.50 search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Blocks: 19931 This bug falls under the omnibus Bug 19931, "Update popup window templates to use Bootstrap grid." Updated in this patch will be z3950_auth_search.tt, the template for Z39.50 searches from the authorities interface. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 [Bug 19931] Update popup window templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes.

1 18