April 2018 - Koha-bugs - lists.koha-community.org

[Bug 14610] Add ability to place article requests in Koha
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Pedro Amorim <pjamorim91(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pjamorim91(a)gmail.com --- Comment #268 from Pedro Amorim <pjamorim91(a)gmail.com> --- Hello everyone, after using this feature I noticed that e-mails are not being sent for patrons upon status update for the article requests. I checked the database and the to_address field is NULL in the message_queue table. Could it be that we need to define to_address => $borrower{'email'}, from_address => C4::Context->preference('KohaAdminEmailAddress'), in the EnqueueLetter call in https://github.com/Koha-Community/Koha/blob/master/Koha/ArticleRequest.pm#L… Or am I missing something else? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #13 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to Séverine Queune from comment #12) > Attributes checked "Display in check-out" are now displayed on side panel of > all tabs in patron account (that's useful). > > Maybe the description of this option on the "Attribute menu" should be > modifiy now. > "Display in check-out: Check to show this attribute in patron check-out." > --> "Display in patron's brief information" ? Definitely makes sense to me, would you mind to fill a bug for this? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20647 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 [Bug 20647] When ILL is enabled the hover effect on the ILL requests button is wrong. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|20646 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20646 [Bug 20646] "ILL Request" menu options not displayed when user has superlibrarian permission -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20646 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20646 [Bug 20646] "ILL Request" menu options not displayed when user has superlibrarian permission -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |severine.queune(a)bulac.fr --- Comment #58 from Séverine Queune <severine.queune(a)bulac.fr> --- I can't apply the patch on master branch 17.12.00.037 : Bug 15486 - Restrict number of holds placed by day 71314 - Bug 15486: DB structure change 71315 - Bug 15486: DBIC update 71316 - Bug 15486: Unit tests 71317 - Bug 15486: Extend CanItemBeReserved so it handles daily holds limits 71318 - Bug 15486: Modify request.tt to handle the new error string 72709 - Bug 15486: Make circ rules UI handle holds_per_day Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15486: DB structure change Applying: Bug 15486: DBIC update Using index info to reconstruct a base tree... M Koha/Schema/Result/Issuingrule.pm Falling back to patching base and 3-way merge... Auto-merging Koha/Schema/Result/Issuingrule.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Issuingrule.pm Failed to merge in the changes. Patch failed at 0001 Bug 15486: DBIC update The copy of the patch that failed is found in: /var/repositories/koha/.git/rebase-apply/patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #12 from Séverine Queune <severine.queune(a)bulac.fr> --- Attributes checked "Display in check-out" are now displayed on side panel of all tabs in patron account (that's useful). Maybe the description of this option on the "Attribute menu" should be modifiy now. "Display in check-out: Check to show this attribute in patron check-out." --> "Display in patron's brief information" ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74782|0 |1 is obsolete| | --- Comment #11 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 74792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74792&action=ed… Bug 12159: Add tests Test plan: prove t/db_dependent/Koha/Patron/Attributes.t t/db_dependent/Koha/Patrons.t Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74781|0 |1 is obsolete| | --- Comment #10 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 74791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74791&action=ed… Bug 12159: Fix getting extended patron attributes for circ-menu Changes: - Replace getting preference ExtendedPatronAttributes by Koha.Preference in templates - Add Koha::Patron->attributes for getting patrons extended attributes - Use this method in circ-menu.inc - Remove getting attributes from members perl scripts Test plan: 0) Apply the patch 1) Add some patron attributes type - with free text, authorised value, limited by libraries... 2) Add some values to this attributes for some patrons 3) Go through as many patron pages as you can and confirm that attributes are shown at side panel when they shoul and are not shown when they should not be shown Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0