April 2018 - Koha-bugs - lists.koha-community.org

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |severine.queune(a)bulac.fr --- Comment #58 from Séverine Queune <severine.queune(a)bulac.fr> --- I can't apply the patch on master branch 17.12.00.037 : Bug 15486 - Restrict number of holds placed by day 71314 - Bug 15486: DB structure change 71315 - Bug 15486: DBIC update 71316 - Bug 15486: Unit tests 71317 - Bug 15486: Extend CanItemBeReserved so it handles daily holds limits 71318 - Bug 15486: Modify request.tt to handle the new error string 72709 - Bug 15486: Make circ rules UI handle holds_per_day Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15486: DB structure change Applying: Bug 15486: DBIC update Using index info to reconstruct a base tree... M Koha/Schema/Result/Issuingrule.pm Falling back to patching base and 3-way merge... Auto-merging Koha/Schema/Result/Issuingrule.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Issuingrule.pm Failed to merge in the changes. Patch failed at 0001 Bug 15486: DBIC update The copy of the patch that failed is found in: /var/repositories/koha/.git/rebase-apply/patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #12 from Séverine Queune <severine.queune(a)bulac.fr> --- Attributes checked "Display in check-out" are now displayed on side panel of all tabs in patron account (that's useful). Maybe the description of this option on the "Attribute menu" should be modifiy now. "Display in check-out: Check to show this attribute in patron check-out." --> "Display in patron's brief information" ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74782|0 |1 is obsolete| | --- Comment #11 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 74792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74792&action=ed… Bug 12159: Add tests Test plan: prove t/db_dependent/Koha/Patron/Attributes.t t/db_dependent/Koha/Patrons.t Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74781|0 |1 is obsolete| | --- Comment #10 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 74791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74791&action=ed… Bug 12159: Fix getting extended patron attributes for circ-menu Changes: - Replace getting preference ExtendedPatronAttributes by Koha.Preference in templates - Add Koha::Patron->attributes for getting patrons extended attributes - Use this method in circ-menu.inc - Remove getting attributes from members perl scripts Test plan: 0) Apply the patch 1) Add some patron attributes type - with free text, authorised value, limited by libraries... 2) Add some values to this attributes for some patrons 3) Go through as many patron pages as you can and confirm that attributes are shown at side panel when they shoul and are not shown when they should not be shown Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #90 from Séverine Queune <severine.queune(a)bulac.fr> --- Feature works fine. A detail : maybe the pull down menu is too far from the selected line (1 or 2 lines down). I can't remember exactly what the first feature looked like. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74040|0 |1 is obsolete| | --- Comment #89 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 74787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74787&action=ed… Bug 12747: Adjustment to Z39.05 search template Removed some old columns that were moved in a previous patch and brought back in while rebasing. Also moved the additionnal fields column to the left of the action columns, so the pull down menu stays at the far right of the line. Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74039|0 |1 is obsolete| | --- Comment #88 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 74786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74786&action=ed… Bug 12747: (follow-up) Removed unwanted tab character and fixed typo in tests Removed a typo introduced while adding missing `use t::lib::Mocks ...` to Breeding.t Also removed tab character from z3950_search.tt Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74037|0 |1 is obsolete| | --- Comment #87 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 74785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74785&action=ed… Bug 12747: Switch date field on marc flavour Amended _add_rowdata to check only for the marcflavour-appropriate date field. This makes the test pass without noise. Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #86 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 74784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74784&action=ed… Bug 12747 - Missing use in tests Adds missing `use t::lib::Mocks ...` to Breeding.t Tests should now pass correctly. Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0