April 2018 - Koha-bugs - lists.koha-community.org

[Bug 2696] Fine payments should show what was paid for
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '18

21 Apr '18

1 0

[Bug 2696] Fine Payments Should Show What Was Paid For
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '18

21 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72263|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2696] Fine Payments Should Show What Was Paid For
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '18

21 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72088|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2696] Fine Payments Should Show What Was Paid For
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '18

21 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2696] Fine Payments Should Show What Was Paid For
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '18

21 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #38 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 74674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74674&action=ed… Bug 2696: (QA follow-up) Several fixes to template variables - Fix link to patron account in breadcrumbs - Fix includes for accounttype.inc to display type correctly - in Details for fee - in Payments list - Fix use CGI qw ( -utf8 ); - Remove <br> from within a string for better translation -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2696] Fine Payments Should Show What Was Paid For
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '18

21 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #37 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 74673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74673&action=ed… Bug 2696: (QA follow-up) - Remove use of GetMember Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2696] Fine Payments Should Show What Was Paid For
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '18

21 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #36 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 74672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74672&action=ed… Bug 2696: Fine payments should show what was paid for Test Plan: 1) Apply this patch and its' dependencies 2) Create and pay some various fees and fines 3) View the payments for fees, and fees paid by payments by using the new 'Details' button available on boraccount.pl Signed-off-by: Lee Jamison <ldjamison(a)marywood.edu> Running updatedatabase.pl after patch application makes dependencies happy. Passes QA Tools and works as intended. Rebased (2017-12-21): Alex Arnaud <alex.arnaud(a)biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2696] Fine Payments Should Show What Was Paid For
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '18

21 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #35 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Comment on attachment 72088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72088 Bug 2696 - Fine Payments Should Show What Was Paid For Review of attachment 72088: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=269…) ----------------------------------------------------------------- Hi all, looking at how long we've wanted for this... wow. While testing I discovered several issues with the template variables that I am fixing in a QA follow-up. ::: Koha/Account/Offset.pm @@ +37,5 @@ > =cut > > +=head3 debit > + > +=cut 1) Please add POD to debit and credit! Not treating this as a blocker, but please provide a follow up. ::: koha-tmpl/intranet-tmpl/prog/en/includes/account_offset_type.inc @@ +1,2 @@ > +[% SWITCH account_offset.type %] > + [% CASE 'Payment' %]Payment 2) I've checked and the strings from account_offset_type.inc and accounttype.inc are picked up by translation scripts. Just a note, nothing to see here! ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt @@ +84,5 @@ > + <th>Amount</th> > + <th>Amount outstanding</th> > + <th>Type</th> > + <th>Note</th> > + <th>Transacting<br/>librarian id</th> 3) This is a translation issue, because it leaves you with "Transacting" and "library id" separately. We need to achieve a nice layout otherwise. I will remove the <br> in a QA follow-up. ::: members/accountline-details.pl @@ +18,5 @@ > +# along with Koha; if not, see <http://www.gnu.org/licenses>. > + > +use Modern::Perl; > + > +use CGI; 4) Should be: use CGI qw ( -utf8 ); -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2696] Fine Payments Should Show What Was Paid For
by bugzilla-daemon＠bugs.koha-community.org 21 Apr '18

21 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #34 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- QA script and tests pass, will continue poking at this for a bit longer :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10858] Browse selected biblios - OPAC
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '18

20 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #125 from Séverine Queune <severine.queune(a)bulac.fr> --- (In reply to Jonathan Druart from comment #124) > As bug 19290 adds a new pref to turn the feature on/off, should not we do > the same for the OPAC? To me, that would be more logical. -- You are receiving this mail because: You are watching all bug changes.

1 0