April 2018 - Koha-bugs - lists.koha-community.org

[Bug 7910] Batch renewal of serials
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 --- Comment #23 from Séverine Queune <severine.queune(a)bulac.fr> --- Works as expected. Maybe the popup could be smaller, but that's a detail. Page is reloaded after the renewal of the subscriptions so it make the operation clear for me. Thanks Jonathan ! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7910] Batch renewal of serials
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74541|0 |1 is obsolete| | --- Comment #22 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 74547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74547&action=ed… Bug 7910: Give feedack when the subscriptions have been renewed - useless? This patch adds a message to the user to let them know the subscription have been renewed successfully. Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7910] Batch renewal of serials
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74540|0 |1 is obsolete| | --- Comment #21 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 74546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74546&action=ed… Bug 7910: Add the ability to renew several subscriptions at once This patch adds a "Renew all selected subscriptions" action link on top of the table of the "Check expiration" page. It will allow to auto-renew several subscriptions. Test plan: Make sure this new link renew the selected subscriptions as expected. Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7910] Batch renewal of serials
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 --- Comment #20 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 74545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74545&action=ed… Bug 20614: Use GET instead of POST for subscription renewing It will prevent Firefox (and certainly other browsers) to block the form resubmit: "To display this page, Firefox must send information that will repeat any action (such as a search or order confirmation) that was performed earlier." Test plan: Renew a subscription and save => You should not longer see the browser warning Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7910] Batch renewal of serials
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #412 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 74544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74544&action=ed… Bug 7143: Update about page for new dev - Andrew Isherwood -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 7910] Batch renewal of serials
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #19 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Applies ok for me, please try again. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20618] New: message_queue should save reserve id into metadata
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20618 Bug ID: 20618 Summary: message_queue should save reserve id into metadata Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: pasi.kallinen(a)joensuu.fi QA Contact: testopia(a)bugs.koha-community.org When there's a problem with reserves, and messages have already been sent to patrons, it is hard to find out which messages need to be resent. The message queue should have the reserve id in the metadata, so it would be much easier to connect a message to specific reserve. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 7910] Batch renewal of serials
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #18 from Séverine Queune <severine.queune(a)bulac.fr> --- koha@kohamonodev:/var/repositories/koha$ git bz apply 7910 Bug 7910 Depends on bug 20614 Follow? [(y)es, (n)o] y Bug 20614 - Firefox prevents parent page reload when renewing subscriptions 74509 - Bug 20614: Use GET instead of POST for subscription renewing Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20614: Use GET instead of POST for subscription renewing Bug 7910 - Batch renewal of serials 74540 - Bug 7910: Add the ability to renew several subscriptions at once 74541 - Bug 7910: Give feedack when the subscriptions have been renewed - useless? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 7910: Add the ability to renew several subscriptions at once fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/serials/checkexpiration.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 7910: Add the ability to renew several subscriptions at once The copy of the patch that failed is found in: /var/repositories/koha/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-7910-Add-the-ability-to-renew-several-subscrip-gRgY9c.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7910] Batch renewal of serials
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 --- Comment #17 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #13) > I am sorry, but this doesn't work for me. Heh, UI changes distracted me a bit apparently :) Fixed now. (In reply to Katrin Fischer from comment #14) > Was this intentional? > + use Data::Printer colored => 1; warn p $subscription; Of course not, removed. > If possible I think the success message for batch renewal would be better > without the pop-up and just on the page above the table with the usual > markup. I would consider that out of the scope, I think it has been improved with bug 20614 and the confirmation popup. It would require a complete rewrite of this script to make it work better. -- You are receiving this mail because: You are watching all bug changes.

1 0