April 2018 - Koha-bugs - lists.koha-community.org

[Bug 2696] Fine Payments Should Show What Was Paid For
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '18

20 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges?
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '18

20 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #25 from Nick Clemens <nick(a)bywatersolutions.com> --- All looks good to me, the trick of enabling the button on submit didn't feel right though. I attached an alternate patch that changes the form, adding a hidden input for when the button is disabled. It forced a few more js changes, but I like the concept better. Can you weigh in Marcel and either SO or obsolete my patch? you can then mark as PQA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges?
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '18

20 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #24 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 74621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74621&action=ed… Bug 20100: (Alternate) Use template logic instead of js to disable superlib box -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges?
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '18

20 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #23 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 74620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74620&action=ed… Bug 20100: Disallow access to superlibrarian privileges at client side This last patch activates the check at client side. If the pref ProtectSuperlibPrivs is enabled, non-superlibs should not be able to change superlibrarian privileges via the interface. Test plan: [1] Enable the pref. [2] Login as superlib and add/remove superlib privs to a staff user. [3] Login as another user (no superlib, but having borrowers, permissions and staff_access). Verify that you cannot add or remove superlib privs. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: JM Broust <jean-manuel.broust(a)univ-lyon2.fr> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges?
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '18

20 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #22 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 74619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74619&action=ed… Bug 20100: Disallow access to superlib privileges at server side Depends on pref ProtectSuperlibPrivs. If enabled, script member-flags.pl will not allow you to add or remove superlib privs when you are no superlibrarian. The follow-up patch will enable the check at client side. Test plan: [1] Enable the pref. Do not apply the third patch (client side). [2] Login as superlib and add/remove superlib privs to a staff user. [3] Login as another user (no superlib, but having borrowers, permissions and staff_access). Verify that you have an internal server error when you add or remove superlib privs. The log contains a warning. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: JM Broust <jean-manuel.broust(a)univ-lyon2.fr> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges?
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '18

20 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72747|0 |1 is obsolete| | Attachment #72749|0 |1 is obsolete| | Attachment #72750|0 |1 is obsolete| | --- Comment #21 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 74618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74618&action=ed… Bug 20100: Introduce preference ProtectSuperlibPrivs This pref allows you to block changes to superlibrarian privileges at client and server side for non-superlibrarians. This patch only contains the db rev and the preference description. Test plan: Run dbrev or new install. Check pref value. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: JM Broust <jean-manuel.broust(a)univ-lyon2.fr> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges?
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '18

20 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |nick(a)bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '18

20 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '18

20 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #43 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- === Details Net::Z3950::SimpleServer Just wondering why we need a new dep. SIPServer uses Net::Server::PreFork ? t/Koha/Z3950responder.t This test fails with me. Please check. not ok 3 - We didn't start server , should fail # Failed test 'We didn't start server , should fail' # at t/Koha/Z3950responder.t line 24. # got: undef # expected: '2' not ok 4 - We didn't start server, should fail because it cannot connect # Failed test 'We didn't start server, should fail because it cannot connect' # at t/Koha/Z3950responder.t line 25. # got: undef # expected: 'Cannot connect to upstream server' not ok 5 - There is no handler as we aren't connected # Failed test 'There is no handler as we aren't connected' # at t/Koha/Z3950responder.t line 27. # got: '13' # expected: '30' not ok 6 - We don't have a handler, should fail because we don't # Failed test 'We don't have a handler, should fail because we don't' # at t/Koha/Z3950responder.t line 28. # got: 'Fetch request out of range' # expected: 'No such resultset' Use of uninitialized value $num_to_prefetch in division (/) at /usr/share/koha/devclone/Koha/Z3950Responder/Session.pm line 158. Illegal division by zero at /usr/share/koha/devclone/Koha/Z3950Responder/Session.pm line 158. t/db_dependent/Koha/Z3950Responder/Session.t t/db_dependent/Koha/Z3950Responder/Session2.t The test coverage only focuses on the add item status routine. We are not testing the server itself. Would it be too hard to try? Commit message stuff from qa tools * Commit title does not contain 'follow-up' correctly spelt - 8e0da10 * Commit title does not start with 'Bug XXXXX: ' - 31c0f7b * Commit title does not start with 'Bug XXXXX: ' - cf4f62b * Commit title does not contain 'follow-up' correctly spelt - cf4f62b * Commit title does not start with 'Bug XXXXX: ' - f592650 * Commit title does not contain 'follow-up' correctly spelt - f592650 * Commit title does not start with 'Bug XXXXX: ' - c24c232 Path::Tiny Why is this dependency added? It is not used somewhere. Log::Log4perl::Appender Might be a new enhancement on itself?? my ($item_tag, $itemnumber_subfield) = GetMarcFromKohaField( "items.itemnumber", '' ); Does not need the default framework parameter anymore. See changed API. Testing misc/z3950_responder.pl Crashes on show 0 Can't call method "raw" on an undefined value at /usr/share/koha/devclone/Koha/Z3950Responder/Session.pm line 169. Target closed connection + warn "name: $opt_name and value: $opt_value"; Debug leftover? Configuration Defaults to port 9999 (yaz default). Note that we may use port 9999 too for Zebra authorities.. Passing a listener-address worked though. Should we add our own default? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 20 Apr '18

20 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #42 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- === General The idea is interesting! It works but I have the impression that it still needs some fine-tuning and further testing. Crashes on a show 0 for instance. Tests need attention. As an optional feature, it will not harm people not using it. On the other hand, it adds 600 lines of code for an additional item status via a Z39.50 daemon (including overlap with C4/Search Zebra code). We need to maintain that. Food for discussion? The feature does not support showing this new status via SRU/SRW in analogy with Zebra? (Only see YAZ responding with 404 on 9999 now in the browser.) In terms of new development, I wonder if it would not be simpler to provide an item status via REST API, and not invest in Zebra/Z39.50 (not looking at specific sponsor specs here)? Further thoughts ? -- You are receiving this mail because: You are watching all bug changes.

1 0