April 2018 - Koha-bugs - lists.koha-community.org

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 --- Comment #58 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #57) > This followup adds errors for the first and last situations. The middle one > only occurs if you apply the patch set but don't restart plack ( at least > for me ) so it's not a valid production error afaict. > > > Errors handling should be polished a bit. For instance I am seeing these > > screens when id or keeper does not match valid borrowernumbers: > > https://screenshots.firefox.com/nIgsc8xOpLHvuqXC/pro.kohadev.org > > https://screenshots.firefox.com/VTKYZNqBS3L8B5cq/pro.kohadev.org > > https://screenshots.firefox.com/gEGiMi16yknuyrZU/pro.kohadev.org IIRC it happened when keeper was invalid. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 --- Comment #57 from Kyle M Hall <kyle(a)bywatersolutions.com> --- This followup adds errors for the first and last situations. The middle one only occurs if you apply the patch set but don't restart plack ( at least for me ) so it's not a valid production error afaict. > Errors handling should be polished a bit. For instance I am seeing these > screens when id or keeper does not match valid borrowernumbers: > https://screenshots.firefox.com/nIgsc8xOpLHvuqXC/pro.kohadev.org > https://screenshots.firefox.com/VTKYZNqBS3L8B5cq/pro.kohadev.org > https://screenshots.firefox.com/gEGiMi16yknuyrZU/pro.kohadev.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 --- Comment #56 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 74585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74585&action=ed… Bug 9302: Add error messages, correct number of unit tests in subtest 'Test Koha::Patrons::merge' -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 --- Comment #55 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #54) > Thanks for the follow-ups. > > (In reply to Jonathan Druart from comment #38) > > 1. How did you generate $RESULTSET_PATRON_ID_MAPPING? > > How are we going to keep it up-to-date? I went through the tables looking for columns that represent borrowernumbers. It's pretty easy for columns with foreign keys to borrowers.borrowernumber, but not all the columns have a borrowernumber. We should just add that to the qa process. If a new column is added that is a borrowernumber, it should be added to the mapping. We could move the mapping itself its own perl module to make it more obvious if you wish. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10537] Limit ability to grant permissions based on user's own permissions
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10537 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen(a)gmail.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20100 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges?
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10537 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20594] New: Revert Perl version to 5.10
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20594 Bug ID: 20594 Summary: Revert Perl version to 5.10 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: mtompset(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Based on David Cook's correct point on Bug 20104, revert the version, but not the refactor, to 5.10 for perl. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 12123] HTML notices can break the notice viewer
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '18

19 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #42 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

1 0