April 2018 - Koha-bugs - lists.koha-community.org

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74219|0 |1 is obsolete| | --- Comment #223 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 74308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74308&action=ed… Bug 11708: UT: Replace 'ok' by 'is' where appropriate Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74218|0 |1 is obsolete| | --- Comment #222 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 74307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74307&action=ed… Bug 11708: New page for basket groups This patch moves the code responsible for displaying a list of basket groups into its own Perl script (acqui/basketgroups.pl), making the code in basketgroup.pl and basketgroup.tt a little bit easier to read. basketgroups.pl displays all basket groups in a single table (as bug 13371 for vendors) where rows are grouped by bookseller. In the process, this patch adds 4 new "Koha::Object" modules: - Koha::Bookseller(s) - Koha::Basket(s) - Koha::Basketgroup(s) - Koha::Order(s) It also adds a wrapper around the new DataTable() constructor to be able to use it with the same defaults than the previous dataTable() constructor Test plan: 0. Create a bunch of booksellers and basketgroups 1. Go back to acquisitions home page and click on "Basket groups" link on the left 2. Play with the table (sort, filter) and try every possible actions (Edit, Close and export as PDF, View, Reopen, Export as CSV) 3. Go to a specific vendor page and click on "Basket groups" tab 4. Check that only the vendor's basket groups are displayed Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74217|0 |1 is obsolete| | --- Comment #221 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 74306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74306&action=ed… Bug 11708: Place "Basket groups" menu entry on top of the side navigation Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74216|0 |1 is obsolete| | --- Comment #220 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 74305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74305&action=ed… Bug 11708: Remove column aqbasketgroups.closed It is redundant with aqbasketgroups.closeddate Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Patch updated: use atomic update Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74215|0 |1 is obsolete| | --- Comment #219 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 74304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74304&action=ed… Bug 11708: basketgroup.pl can now display basketgroups for all suppliers This happens when no booksellerid is given. This patch also adds 4 columns: - No. of ordered titles - No. of received titles - Ordered amount - Charged amount (amount of received orders) Add filters to basketgroup tables columns Show closed date in closed basketgroups tables Signed-off-by: juliette levast <juliette.levast(a)iepg.fr> Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74214|0 |1 is obsolete| | --- Comment #218 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 74303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74303&action=ed… Bug 11708: Unit tests for aqbasketgroups.closeddate Signed-off-by: juliette levast <juliette.levast(a)iepg.fr> Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74213|0 |1 is obsolete| | --- Comment #217 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 74302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74302&action=ed… Bug 11708: Add aqbasketgroups.closeddate Signed-off-by: juliette levast <juliette.levast(a)iepg.fr> Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Patch updated: Use atomic update Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #43 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Maybe too late yesterday, thx for the hint. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #42 from Ere Maijala <ere.maijala(a)helsinki.fi> --- Katrin, Firefox tends to display things in clear even if they're sent properly encoded. You can use e.g. the network tab in the developer tools to see what's actually sent. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20593] New: Warnings when adding a recipient to a routing list
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20593 Bug ID: 20593 Summary: Warnings when adding a recipient to a routing list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org Just noticed while working on something else. When adding a patron to a routing list, there are several warns in the logs: Use of uninitialized value in numeric gt (>) at /home/vagrant/kohaclone/C4/Serials.pm line 1973. Use of uninitialized value in concatenation (.) or string at /home/vagrant/kohaclone/serials/routing-preview.pl line 126. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1