May 2018 - Koha-bugs - lists.koha-community.org

[Bug 18979] New: Speed up 'valid-templates.t' tests
by bugzilla-daemon＠bugs.koha-community.org 14 May '18

14 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18979 Bug ID: 18979 Summary: Speed up 'valid-templates.t' tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 18055 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 [Bug 18055] Speed up '00-strict.t' test -- You are receiving this mail because: You are watching all bug changes.

1 27

[Bug 18055] New: Speed up '00-strict.t' test, with Parallel::ForkManager
by bugzilla-daemon＠bugs.koha-community.org 14 May '18

14 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Bug ID: 18055 Summary: Speed up '00-strict.t' test, with Parallel::ForkManager Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: mtj(a)kohaaloha.com QA Contact: gmcharlt(a)gmail.com A patch to speed up the 00-strict.t test (works better on multi-cpu systems) -- You are receiving this mail because: You are watching all bug changes.

1 59

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 14 May '18

14 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #94 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- (In reply to Marcel de Rooy from comment #93) > I could be the next QAer.. (Only glanced thru so far.) :) > The sentence I referred to earlier "at the expense" is somewhat unclear and > could be improved. Not a blocking concern. If anyone reading this has an idea, feel free to post a comment. > The fact that the default value for the pref contains a thousands separator > for many people is a bit confusing too. But I understand that it is the end > of a long discussion. It seems that any value will contain a thousands separator for many people. https://en.wikipedia.org/wiki/Decimal_separator#Digit_grouping The idea was that the default value would fit the basic use case (no thousands seps) for almost everyone (, and . users) https://en.wikipedia.org/wiki/Decimal_separator#Hindu%E2%80%93Arabic_numera… without requiring any configuration choice when migrating on the 18.11 for example. So system librarians can miss this change in the release notes without causing the very same chaos that this patch wants to fix. [1] Which hopefully will remove a obstacle for this path to be backportable for example. [1] And with drones becoming a commodity in a lot of countries, the cost for angry users to hire a hitman — using "modern" techniques that up to now were reserved to the USA — is constantly lowering. That's why I try to choose defaults that will keep people happy ^^" </troll> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8265] Allow a better form of the title to be included in notices
by bugzilla-daemon＠bugs.koha-community.org 14 May '18

14 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8265 Ray Delahunty <r.delahunty(a)arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty(a)arts.ac.uk --- Comment #2 from Ray Delahunty <r.delahunty(a)arts.ac.uk> --- Maybe the question to ask if 245 $b, etc. can be included in other places, not just for emails, but in Acquisitions and Cataloguing. It was one of the first things we noticed after migration- it is ever so inconvenient not being able to see the rest of the 245. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 14 May '18

14 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #93 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Victor Grousset/tuxayo from comment #92) > (In reply to Marcel de Rooy from comment #91) > > > So one can use anything as a thousands sep. As long as it's not a digit a > > > minus or in the DecimalSeparators syspref. > > > > In our country the . is the thousands separator and the , is the decimal > > sep. (Just opposite to Anglo-Saxon style.) > > So if you want to use the . as the thousands separator then you will have to > put only , in the DecimalSeparators syspref. > > > No problem for my library btw. > > Great :) Are all your potentially blocking concerns addressed? > (having discussions not closed could cause a QAer to hesitate) I could be the next QAer.. (Only glanced thru so far.) The sentence I referred to earlier "at the expense" is somewhat unclear and could be improved. Not a blocking concern. The fact that the default value for the pref contains a thousands separator for many people is a bit confusing too. But I understand that it is the end of a long discussion. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 14 May '18

14 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #92 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- (In reply to Marcel de Rooy from comment #91) > > So one can use anything as a thousands sep. As long as it's not a digit a > > minus or in the DecimalSeparators syspref. > > In our country the . is the thousands separator and the , is the decimal > sep. (Just opposite to Anglo-Saxon style.) So if you want to use the . as the thousands separator then you will have to put only , in the DecimalSeparators syspref. > No problem for my library btw. Great :) Are all your potentially blocking concerns addressed? (having discussions not closed could cause a QAer to hesitate) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 14 May '18

14 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #91 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Victor Grousset/tuxayo from comment #90) > Hopefully not, because on the IRC and mainly during the hackfest, I have > collected a lot of feedback. > Which caused the proposed solution to change more than 5 times. > I already bothered a lot of people (from france, germany and the US) to > ensure that there won't be librarian tears if this solution goes into > production. ^^ > Each simpler solution raised issues about existing use cases that work now > or worked before the ~16.11 regression. No simple solutions ;) > So one can use anything as a thousands sep. As long as it's not a digit a > minus or in the DecimalSeparators syspref. In our country the . is the thousands separator and the , is the decimal sep. (Just opposite to Anglo-Saxon style.) No problem for my library btw. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10306] Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264)
by bugzilla-daemon＠bugs.koha-community.org 14 May '18

14 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 --- Comment #85 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Agnes Rivers-Moore from comment #84) > I would like to request that the method for setting this up is documented in > some detail for the end user. Many smaller libraries stay well away from > mapping & frameworks for fear of breaking something so we are not familiar > with making adjustments. If the frameworks can be adjusted/new ones set up > set up during upgrade that would be nice. This is a very tiny and easy adjustment: Go to Administration/Koha to MARC mapping. For MARC21, find the table row for biblio.copyrightdate (260c), and click on Add. Type 264,c in the popup. Click OK. You're done. Note: At this point new or edited records with 264c, will adjust copyrightdate. Unchanged records will not. A sysadmin may run the script misc/maintenance/touch_all_biblios --where "copyrightdate is null" for you. This would update all biblios without 260c but having a 264c. (Note: maybe IFNULL(copyrightdate,0)=0 is even better as where condition.) In view of comment83 this setting is not yet included in frameworks etc. This will be done on the follow-up reports. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 14 May '18

14 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #90 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- (In reply to Marcel de Rooy from comment #89) > (In reply to Victor Grousset/tuxayo from comment #88) > > That means that in the case of wanting to use thousands separators; > > one has to renounce having , AND . as decimal seps. > > The one that is elected as the thousands sep can't be in the > > DecimalSeparators syspref. > > Sounds better to me. Do you need more feedback? From the list ? Hopefully not, because on the IRC and mainly during the hackfest, I have collected a lot of feedback. Which caused the proposed solution to change more than 5 times. I already bothered a lot of people (from france, germany and the US) to ensure that there won't be librarian tears if this solution goes into production. ^^ Each simpler solution raised issues about existing use cases that work now or worked before the ~16.11 regression. > > > I would probably prefer to assign both roles in separate > > > preferences to resolve the ambiguity. Now we still do not know what means > > > 3,512 ? Is it three thousand or three ? > > > > Does the above explanation addresses all of your concerns? > > Can't say that yet. > > > Is there a way to better phrase the syspref text? > > Depends on the choices we will make. Do you add another pref for thousand > sep? No need for it. «Gets rid of the spaces, currency symbols, names (EUR) There is nothing specific about currency symbols is this patch. It just removes everything that is not a digit a minus or a separator.» So one can use anything as a thousands sep. As long as it's not a digit a minus or in the DecimalSeparators syspref. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 14 May '18

14 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #89 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Victor Grousset/tuxayo from comment #88) > (In reply to Marcel de Rooy from comment #86) > > Reading: "So thousands separators come at the expense of handling both dots > > and commas." > > > > If I understand correctly, you do not know which separator has which > > function? > > That means that in the case of wanting to use thousands separators; > one has to renounce having , AND . as decimal seps. > The one that is elected as the thousands sep can't be in the > DecimalSeparators syspref. Sounds better to me. Do you need more feedback? From the list ? > > I would probably prefer to assign both roles in separate > > preferences to resolve the ambiguity. Now we still do not know what means > > 3,512 ? Is it three thousand or three ? > > Does the above explanation addresses all of your concerns? Can't say that yet. > Is there a way to better phrase the syspref text? Depends on the choices we will make. Do you add another pref for thousand sep? -- You are receiving this mail because: You are watching all bug changes.

1 0