May 2018 - Koha-bugs - lists.koha-community.org

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 11 May '18

11 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #73 from Blou <philippe.blouin(a)inlibro.com> --- 1) Did you read my explanation on the matter of answering? The user/owner has many other priorities, and the delay should not be a consideration. Who's waiting on who here? 2) In all those exchanges, I do not see the issue of Tests being raised until you did. Not that it's not valid, mind you, but the testers are working on the Functionalities/usage (Kathleen) or questioning the validity (Marcel). I prefer that, personally. No point in working and rebasing and working again on tests for a feature that might not get accepted as deemed useless. Tests are easy, Bouzid/team has written plenty of those for all the other patches. I have no personal attachment to the feature. Didn't code it, do not maintain it. And knowing what code it touches, it matters to me that it's done well. The process is important and must be followed. But the feature, per the actual cataloging users, is a must have for a serious tool. Must. Have. Philippe PS You get a piece of meat, you smell it, your experience/intuition tells you it's shit, you won't eat it. No need to call a biolab to test the meat. QAs have seen enough features and pieces of code to do that with patches. I do that with all _new_ features or bugs we talk about submitting. Let me tell you I have a picky nose myself, and I'm good at math/finance. The paying users appreciate. A smell test is not an insult. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14302] Remove GRS1 indexing related code
by bugzilla-daemon＠bugs.koha-community.org 11 May '18

11 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14302 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_05_candidate | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Koha::Virtualshelfshare duplicates rows for the same list
by bugzilla-daemon＠bugs.koha-community.org 11 May '18

11 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20754 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20754 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20754 [Bug 20754] Does table virtualshelfshares need a unique index on shelfnumber+borrowernumber+invitekey? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7910] Batch renewal of subscriptions
by bugzilla-daemon＠bugs.koha-community.org 11 May '18

11 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 --- Comment #29 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Last patch pushed to master. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7910] Batch renewal of subscriptions
by bugzilla-daemon＠bugs.koha-community.org 11 May '18

11 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 --- Comment #28 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #27) > Created attachment 75269 [details] [review] > Bug 7910: Give feedack when the subscriptions have been renewed > > This patch adds a message to the user to let them know the subscription > have been renewed successfully. > > Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> This patch has been forgotten (obsoleted), and was marked as " - useless?" in the commit message. It is not. GUI could be improved indeed, as Katrin said. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Koha::Virtualshelfshare duplicates rows for the same list
by bugzilla-daemon＠bugs.koha-community.org 11 May '18

11 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #25 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7910] Batch renewal of subscriptions
by bugzilla-daemon＠bugs.koha-community.org 11 May '18

11 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74547|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 75269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75269&action=ed… Bug 7910: Give feedack when the subscriptions have been renewed This patch adds a message to the user to let them know the subscription have been renewed successfully. Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7910] Batch renewal of subscriptions
by bugzilla-daemon＠bugs.koha-community.org 11 May '18

11 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74547|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7910] Batch renewal of subscriptions
by bugzilla-daemon＠bugs.koha-community.org 11 May '18

11 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Batch renewal of serials |Batch renewal of | |subscriptions -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 11 May '18

11 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #72 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Blou from comment #70) > If the value of the feature can't pass your smell test, I can't recommend > that the user throw good money after bad into the re-engineering of the > feature, indefinitely, to follow the latest architectural whims. They coded > this in 2010ish, so you can bet it's always playing catch-up, code-wise. Coded in 2010 and submitted to the community in November 2013. I do not need to read the test plan or the content of the patch when I see that: C4/Biblio.pm | 138 +++++++++++++- C4/Linker.pm | 5 +- C4/Linker/Default.pm | 2 +- t/Biblio.t | 2 + This definitely is code smell, tests for changes in C4 and Koha are required for years now. Several questions have been asked by Marcel 4 months ago, it would be good to get an answer first. That should not take much time to just... answer, right? -- You are receiving this mail because: You are watching all bug changes.

1 0