May 2018 - Koha-bugs - lists.koha-community.org

[Bug 11943] Koha::Virtualshelfshare duplicates rows for the same list
by bugzilla-daemon＠bugs.koha-community.org 11 May '18

11 May '18

1 0

[Bug 11943] Koha::Virtualshelfshare duplicates rows for the same list
by bugzilla-daemon＠bugs.koha-community.org 11 May '18

11 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 --- Comment #24 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 75247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75247&action=ed… Bug 11943: Add unit test for double accepts Test plan: Run t/db_dependent/Virtualshelves.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Koha::Virtualshelfshare duplicates rows for the same list
by bugzilla-daemon＠bugs.koha-community.org 11 May '18

11 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75120|0 |1 is obsolete| | Attachment #75121|0 |1 is obsolete| | Attachment #75122|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 75246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75246&action=ed… Bug 11943: Prevent duplicating rows in Koha::Virtualshelfshare This 'bug' existed long enough now to finally remove it ;) We do so by deleting the invitation if the borrower already has a share on this list. The user does not notice that, since he is redirected to the list view just as before. We still need: a unit test and a db revision. Test plan: [1] Share a list. Let user B accept. [2] Without this patch: Share again and let B accept again. [3] Verify that you have two shares for this list in virtualshelfshares. [4] With this patch: Share another list, let B accept. [5] Share this other list again, let B accept again. [6] Verify that virtualshelfshares does not contain double entries now. (Note: This pertains to the second list only.) Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Koha::Virtualshelfshare duplicates rows for the same list
by bugzilla-daemon＠bugs.koha-community.org 11 May '18

11 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Koha::Virtualshelfshare duplicates rows for the same list
by bugzilla-daemon＠bugs.koha-community.org 11 May '18

11 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 --- Comment #22 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #20) > However, should not we put the update DB entry on a separate bug report and > deal with the DB structure later? We will have to recheck the duplicate on > create the unique constraint anyway. I am not sure; see commit message. If we add a unique constraint, we need some more code changes (replacing NULL by empty string and that kind). We could move it to its own report and discuss further ;) If we do not really care, the dbrev is sufficient with the changed code. I opened report 20754 for it, but would certainly not mind pushing the third patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Koha::Virtualshelfshare duplicates rows for the same list
by bugzilla-daemon＠bugs.koha-community.org 11 May '18

11 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20753 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20753 [Bug 20753] Add an alert when a user accepts an already shared list -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Koha::Virtualshelfshare duplicates rows for the same list
by bugzilla-daemon＠bugs.koha-community.org 11 May '18

11 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20754 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Koha::Virtualshelfshare duplicates rows for the same list
by bugzilla-daemon＠bugs.koha-community.org 11 May '18

11 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Prevent double accepts in |Koha::Virtualshelfshare |Koha::Virtualshelfshare |duplicates rows for the | |same list --- Comment #21 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #19) > The user click on a link and... nothing happens? No, that is a misunderstanding. He clicks on the link and he is redirected to view this shared list. The behavior interface-wise is exactly the same with and without this patch. The only difference this bugfix makes is that the shared is not duplicated. > Should not we display a message to explain that the list is already shared? I thought about it too. Strictly speaking, this bugfix can still be pushed without string changes. And adding a message could be considered as an enhancement for a new report. Opened bug 20753 for it. In view of the above I am renaming/narrowing down the bug title. I will also look at the commit message in that sense. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Prevent double accepts in Koha::Virtualshelfshare
by bugzilla-daemon＠bugs.koha-community.org 10 May '18

10 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #20 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #19) > The user click on a link and... nothing happens? > > Should not we display a message to explain that the list is already shared? This should be done on a separate bug report, to not block the inclusion into 18.05 (string changes). However, should not we put the update DB entry on a separate bug report and deal with the DB structure later? We will have to recheck the duplicate on create the unique constraint anyway. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6172] Non-French UNIMARC frameworks need to be updated
by bugzilla-daemon＠bugs.koha-community.org 10 May '18

10 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6172 --- Comment #13 from Giuseppe Ciaccio <giuseppe.ciaccio(a)unige.it> --- Yes I'm indeed :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0