May 2018 - Koha-bugs - lists.koha-community.org

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 07 May '18

07 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74527|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 07 May '18

07 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes(a)biblibre.com --- Comment #80 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Patch tested with a sandbox, by Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 07 May '18

07 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_05_candidate | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 07 May '18

07 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_05_candidate | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 07 May '18

07 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 07 May '18

07 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #79 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- Created attachment 75123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75123&action=ed… Bug 12310: Fix decimal separators issues in fines: writeoff amount field This is a follow up for this forgotten field. See main patch more details. == Test plan == 1. Use a translation of the staff interface if possible. 2. Go to a patrons's page → fines → pay fines 3. Click on "Write off" This assumes an existing debt. Which should exists if you just tested the previous patches. 4. If you enter "1,50", the writeoff amount saved is only 1. This is the bug. 5. Apply this patch 6. run ~/src/installer/data/mysql/updatedatabase.pl 7. Refresh the page 8. Retry the write off. Apply the annex 1 to the "Writeoff amount" field 9. It works! \o/ === Annex 1: Subpart for each concerned page === 1. Set DecimalSeparators syspref to ",." 2. Input "12,34" 3. Press the "Tab/Tabulation" key. It will unfocus the field and trigger the conversion. Validating the form does the same but it's a trick to test more quickly by not switching to another page. 4. The value should have been converted to 12.34 5. Do the same with "12,34 EUR" and ensure that it's converted to "12,34" Same with "EUR 12.34" -> "12.34" 6. "EUR 12.34€thanks lyonthree" -> "12.34" 7. "123 456,7" -> "123456.7" 8.. "2" -> "2" 9.. "2,0" -> "2.0" 10. "-1'345.95" -> "-1345.95" 11. ",1234" -> ".1234" 12. Set DecimalSeparators syspref to "," 13. Reload the page with the form 14. "1.000" -> "1000" 15. "1.000.000,10" -> "1000000.10" 16. Set DecimalSeparators syspref to "." 17. Reload the page with the form 18. "1,000" -> "1000" 19. "1,000,000.10" -> "1000000.10" 20. Validate the form and check that the final value with the dot was 21 well handled. 22. Think about Koalas and smile. 🐨🐨🐨 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4809] Lost & Paid For doesn't record payment
by bugzilla-daemon＠bugs.koha-community.org 07 May '18

07 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4809 Patrick Robitaille <patrick.robitaille(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Prevent double accepts in Koha::Virtualshelfshare
by bugzilla-daemon＠bugs.koha-community.org 07 May '18

07 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 --- Comment #17 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 75122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75122&action=ed… Bug 11943: Db revision to remove double accepted shares Although it is no problem to have them, we could do a cleanup. This patch just removes duplicate rows from the table. Note: I considered adding a unique index like: ALTER TABLE virtualshelfshares ADD UNIQUE INDEX (shelfnumber, borrowernumber, invitekey); But the possible NULL values in borrowernumber and/or invitekey require additional code changes. So I left it alone. Test plan: [1] Create two records with same borrowernumber and shelfnumber in the shares table, if not present already. [2] Run updatedatabase.pl Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Prevent double accepts in Koha::Virtualshelfshare
by bugzilla-daemon＠bugs.koha-community.org 07 May '18

07 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 --- Comment #16 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 75121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75121&action=ed… Bug 11943: Add unit test for double accepts Test plan: Run t/db_dependent/Virtualshelves.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Prevent double accepts in Koha::Virtualshelfshare
by bugzilla-daemon＠bugs.koha-community.org 07 May '18

07 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75104|0 |1 is obsolete| | Attachment #75105|0 |1 is obsolete| | Attachment #75106|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 75120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75120&action=ed… Bug 11943: Prevent double accepts in Koha::Virtualshelfshare This 'bug' existed long enough now to finally remove it ;) We do so by deleting the invitation if the borrower already has a share on this list. Actually not that hard. We still need: a unit test and a db revision. Test plan: [1] Share a list. Let user B accept. [2] Without this patch: Share again and let B accept again. [3] Verify that you have two shares for this list in virtualshelfshares. [4] With this patch: Share another list, let B accept. [5] Share this other list again, let B accept again. [6] Verify that virtualshelfshares does not contain double entries now. (Note: This pertains to the second list only.) Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0