May 2018 - Koha-bugs - lists.koha-community.org

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 07 May '18

07 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #73 from David Gustafsson <glasklas(a)gmail.com> --- Which I now saw I already wrote about in previous comment. Still need to fix tests and documentation as the bare minimum before ready for sign-off. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 07 May '18

07 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #72 from David Gustafsson <glasklas(a)gmail.com> --- Rebase against master and remove (probably last of) String::Similarity related code. Have not had time to work on the other issues. We have been running this in production for a couple of weeks now, and have not experienced any issues. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 07 May '18

07 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74855|0 |1 is obsolete| | --- Comment #71 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 75118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75118&action=ed… Bug 14957 - Rule based permission for MARC fields Add a rule based permission system for MARC field modifications. Test plan: 1. Apply this patch 2. Run updatedatabase.pl 3. Log in to staff client 4. Enable new syspref MARCPermissions 5. You should see a new link "MARC field permissions" in the "Catalog" section under "Koha administrtion". 6. Go to the "MARC field permissions" page 7. Next to the page heading ("Manage MARC field permissions") there is a button with a question mark, click this for more information about the rule system. 8. Add desired rules to the rule table, press the +-button to add. 9. Clicking the pen-icon (edit) should allow you to edit corresponding rule. 10. Clicking the x-icon should remove corresponding rule after confirmation. 11. Selecting one or more rules followed by clicking the trash-icon should remove all selected rules after confirmation. 12. To test your rules, import or in other way modify a record. 13. Check that the record was modified as defined by your rules. Sponsored-by: Halland County Library Sponsored-by: Catalyst IT Sponsored-by: Gothenbug University Library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 07 May '18

07 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Accept different monetary |Decimal separators issues |formats as input |in patrons payments/fines -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 07 May '18

07 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #78 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- (In reply to Koha Team Lyon 3 from comment #77) > With DecimalSeparators=',.', when you are on paycollect.pl and choose to > writeoff a fine, if you enter "1,50", the writeoff amount saved is only 1. > The problem occurs only with the writeoff Confirmed. Thanks for catching this. Follow up patch in progress > I think that we should change the name of this ticket as it handles only the > members payments. Indeed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Prevent double accepts in Koha::Virtualshelfshare
by bugzilla-daemon＠bugs.koha-community.org 07 May '18

07 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75051|0 |1 is obsolete| | --- Comment #14 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 75106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75106&action=ed… Bug 11943: Db revision to remove double accepted shares Although it is no problem to have them, we could do a cleanup. This patch just removes duplicate rows from the table. Note: I considered adding a unique index like: ALTER TABLE virtualshelfshares ADD UNIQUE INDEX (shelfnumber, borrowernumber, invitekey); But the possible NULL values in borrowernumber and/or invitekey require additional code changes. So I left it alone. Test plan: [1] Create two records with same borrowernumber and shelfnumber in the shares table, if not present already. [2] Run updatedatabase.pl Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Prevent double accepts in Koha::Virtualshelfshare
by bugzilla-daemon＠bugs.koha-community.org 07 May '18

07 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75050|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 75105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75105&action=ed… Bug 11943: Add unit test for double accepts Test plan: Run t/db_dependent/Virtualshelves.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Prevent double accepts in Koha::Virtualshelfshare
by bugzilla-daemon＠bugs.koha-community.org 07 May '18

07 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75049|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 75104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75104&action=ed… Bug 11943: Prevent double accepts in Koha::Virtualshelfshare This 'bug' existed long enough now to finally remove it ;) We do so by deleting the invitation if the borrower already has a share on this list. Actually not that hard. We still need: a unit test and a db revision. Test plan: [1] Share a list. Let user B accept. [2] Without this patch: Share again and let B accept again. [3] Verify that you have two shares for this list in virtualshelfshares. [4] With this patch: Share another list, let B accept. [5] Share this other list again, let B accept again. [6] Verify that virtualshelfshares does not contain double entries now. (Note: This pertains to the second list only.) Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Prevent double accepts in Koha::Virtualshelfshare
by bugzilla-daemon＠bugs.koha-community.org 07 May '18

07 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Prevent double accepts in Koha::Virtualshelfshare
by bugzilla-daemon＠bugs.koha-community.org 07 May '18

07 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #11 from Nick Clemens <nick(a)bywatersolutions.com> --- Applying: Bug 11943: Prevent double accepts in Koha::Virtualshelfshare fatal: sha1 information is lacking or useless (Koha/Virtualshelfshare.pm). -- You are receiving this mail because: You are watching all bug changes.

1 0