May 2018 - Koha-bugs - lists.koha-community.org

[Bug 20586] New: Infinite loop creation of issues when using multi receive or generate next serial
by bugzilla-daemon＠bugs.koha-community.org 04 May '18

04 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20586 Bug ID: 20586 Summary: Infinite loop creation of issues when using multi receive or generate next serial Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: mbugz2(a)yahoo.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com When using either "Multi receiving" or "Generate next", the result is Server error 500. Normal receving of 1 issue works. 10 or more issues are created (not checking what number I enter in the choice of how many I want to multi receive). Error in error.log [Mon Apr 16 08:54:27.438449 2018] [core:error] [pid 2776] [client 127.0.0.1:42792] AH00124: Request exceeded the limit of 10 internal redirects due to probable configuration error. Use 'LimitInternalRecursion' to increase the limit if necessary. Use 'LogLevel debug' to get a backtrace., referer: https://koha-1.lub.lu.se:8443/cgi-bin/koha/serials/serials-edit.pl?subscrip… -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 04 May '18

04 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20648 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20648 [Bug 20648] Attribute option "Display in check-out" should be renamed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 04 May '18

04 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Koha Team Lyon 3 <koha(a)univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #77 from Koha Team Lyon 3 <koha(a)univ-lyon3.fr> --- Hello, I have followed the test plan (really enthousastic one ;) )and tried different inputs (with dot, comma, symbol, names) in fines patrons tab : maninvoice.pl, mancredit.pl, paycollect.pl) I test it with different setups in DecimalSeparators and the results were consistent. I found only one issue, perhaps related to bug19521. With DecimalSeparators=',.', when you are on paycollect.pl and choose to writeoff a fine, if you enter "1,50", the writeoff amount saved is only 1. The problem occurs only with the writeoff I think that we should change the name of this ticket as it handles only the members payments. Sonia -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Prevent double accepts in Koha::Virtualshelfshare
by bugzilla-daemon＠bugs.koha-community.org 04 May '18

04 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20687 Depends on|20687 | --- Comment #10 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Moving 20687 to see also instead of deps. They can be applied independent of each other. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20687 [Bug 20687] Multiple invitations to share lists prevents some users from accepting -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Prevent double accepts in Koha::Virtualshelfshare
by bugzilla-daemon＠bugs.koha-community.org 04 May '18

04 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org, | |nick(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Prevent double accepts in Koha::Virtualshelfshare
by bugzilla-daemon＠bugs.koha-community.org 04 May '18

04 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This report includes a db release notes| |revision that removes | |duplicate rows on | |shelfnumber and | |borrowernumber from your | |virtualshelfshares table. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Prevent double accepts in Koha::Virtualshelfshare
by bugzilla-daemon＠bugs.koha-community.org 04 May '18

04 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Prevent double accepts in Koha::Virtualshelfshare
by bugzilla-daemon＠bugs.koha-community.org 04 May '18

04 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 --- Comment #9 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 75051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75051&action=ed… Bug 11943: Db revision to remove double accepted shares Although it is no problem to have them, we could do a cleanup. This patch just removes duplicate rows from the table. Note: I considered adding a unique index like: ALTER TABLE virtualshelfshares ADD UNIQUE INDEX (shelfnumber, borrowernumber, invitekey); But the possible NULL values in borrowernumber and/or invitekey require additional code changes. So I left it alone. Test plan: [1] Create two records with same borrowernumber and shelfnumber in the shares table, if not present already. [2] Run updatedatabase.pl Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Prevent double accepts in Koha::Virtualshelfshare
by bugzilla-daemon＠bugs.koha-community.org 04 May '18

04 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 --- Comment #8 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 75050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75050&action=ed… Bug 11943: Add unit test for double accepts Test plan: Run t/db_dependent/Virtualshelves.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Prevent double accepts in Koha::Virtualshelfshare
by bugzilla-daemon＠bugs.koha-community.org 04 May '18

04 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 --- Comment #7 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 75049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75049&action=ed… Bug 11943: Prevent double accepts in Koha::Virtualshelfshare This 'bug' existed long enough now to finally remove it ;) We do so by deleting the invitation if the borrower already has a share on this list. Actually not that hard. We still need: a unit test and a db revision. Test plan: [1] Share a list. Let user B accept. [2] Without this patch: Share again and let B accept again. [3] Verify that you have two shares for this list in virtualshelfshares. [4] With this patch: Share another list, let B accept. [5] Share this other list again, let B accept again. [6] Verify that virtualshelfshares does not contain double entries now. (Note: This pertains to the second list only.) Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0