May 2018 - Koha-bugs - lists.koha-community.org

[Bug 11943] Prevent double accepts in Koha::Virtualshelfshare
by bugzilla-daemon＠bugs.koha-community.org 04 May '18

04 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Prevent double accepts in Koha::Virtualshelfshare
by bugzilla-daemon＠bugs.koha-community.org 04 May '18

04 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 --- Comment #9 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 75051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75051&action=ed… Bug 11943: Db revision to remove double accepted shares Although it is no problem to have them, we could do a cleanup. This patch just removes duplicate rows from the table. Note: I considered adding a unique index like: ALTER TABLE virtualshelfshares ADD UNIQUE INDEX (shelfnumber, borrowernumber, invitekey); But the possible NULL values in borrowernumber and/or invitekey require additional code changes. So I left it alone. Test plan: [1] Create two records with same borrowernumber and shelfnumber in the shares table, if not present already. [2] Run updatedatabase.pl Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Prevent double accepts in Koha::Virtualshelfshare
by bugzilla-daemon＠bugs.koha-community.org 04 May '18

04 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 --- Comment #8 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 75050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75050&action=ed… Bug 11943: Add unit test for double accepts Test plan: Run t/db_dependent/Virtualshelves.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Prevent double accepts in Koha::Virtualshelfshare
by bugzilla-daemon＠bugs.koha-community.org 04 May '18

04 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 --- Comment #7 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 75049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75049&action=ed… Bug 11943: Prevent double accepts in Koha::Virtualshelfshare This 'bug' existed long enough now to finally remove it ;) We do so by deleting the invitation if the borrower already has a share on this list. Actually not that hard. We still need: a unit test and a db revision. Test plan: [1] Share a list. Let user B accept. [2] Without this patch: Share again and let B accept again. [3] Verify that you have two shares for this list in virtualshelfshares. [4] With this patch: Share another list, let B accept. [5] Share this other list again, let B accept again. [6] Verify that virtualshelfshares does not contain double entries now. (Note: This pertains to the second list only.) Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Prevent double accepts in Koha::Virtualshelfshare
by bugzilla-daemon＠bugs.koha-community.org 04 May '18

04 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] Prevent double accepts in Koha::Virtualshelfshare
by bugzilla-daemon＠bugs.koha-community.org 04 May '18

04 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|AcceptShare should check |Prevent double accepts in |for double accepts |Koha::Virtualshelfshare -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] AcceptShare should check for double accepts
by bugzilla-daemon＠bugs.koha-community.org 04 May '18

04 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20687 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20687 [Bug 20687] Multiple invitations to share lists prevents some users from accepting -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11943] AcceptShare should check for double accepts
by bugzilla-daemon＠bugs.koha-community.org 04 May '18

04 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943 --- Comment #6 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- While testing 20687, I discovered that this one is still valid :) Still possible to accept two shares on the same list. +----+-------------+----------------+-----------+---------------------+ | id | shelfnumber | borrowernumber | invitekey | sharedate | +----+-------------+----------------+-----------+---------------------+ | 4 | 16 | 37 | NULL | 2018-05-04 08:17:08 | | 5 | 16 | 37 | NULL | 2018-05-04 08:44:04 | +----+-------------+----------------+-----------+---------------------+ Will give it a try now.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14544] Move the list related code to Koha::Virtualshelves
by bugzilla-daemon＠bugs.koha-community.org 04 May '18

04 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20687 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20687 [Bug 20687] Multiple invitations to share lists prevents some users from accepting -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20264] New: Syspref checkdigit is no longer in used
by bugzilla-daemon＠bugs.koha-community.org 04 May '18

04 May '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20264 Bug ID: 20264 Summary: Syspref checkdigit is no longer in used Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org And we could then remove it. http://irc.koha-community.org/koha/2013-06-26#i_1333289 http://irc.koha-community.org/koha/2013-06-26#i_1333589 -- You are receiving this mail because: You are watching all bug changes.

1 18