June 2018 - Koha-bugs - lists.koha-community.org

[Bug 20175] New: Set a correct default value for club_enrollments.date_created
by bugzilla-daemon＠bugs.koha-community.org 12 Jul '18

12 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20175 Bug ID: 20175 Summary: Set a correct default value for club_enrollments.date_created Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: julian.maurice(a)biblibre.com QA Contact: julian.maurice(a)biblibre.com Blocks: 17258 This bug is a continuation of bug 20144 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 18811] New: Visibility settings inconsistent between framework and authority editor
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '18

11 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 Bug ID: 18811 Summary: Visibility settings inconsistent between framework and authority editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: Needs Signoff Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: m.de.rooy(a)rijksmuseum.nl Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: jonathan.druart(a)bugs.koha-community.org, julian.maurice(a)biblibre.com, nick(a)bywatersolutions.com Blocks: 17380 Status: ASSIGNED Assignee: m.de.rooy(a)rijksmuseum.nl CC: jonathan.druart(a)bugs.koha-community.org, julian.maurice(a)biblibre.com, nick(a)bywatersolutions.com Status: Needs Signoff Patch complexity: Small patch Blocks: 17380 >From Nick Clemens on IRC: "Worth mentioning - you can't edit the 942 of an authority when creating, but it appears you can when editing, though you can't save it - confusing as end user." We should keep in mind that AddAuthority overwrites 942c when adding or modifying auth records. When adding a record: Since you choose the framework, we should not allow to change 942c here. The current behavior is fine; the field should normally be hidden via the framework. (We could even enforce it if it would not be hidden?) When modifying a record: The authorities.pl script (incorrectly) shows hidden fields when filled (which actually is weird). Since 942c is overwritten, this is useless. A closer look reveals that the visibility checks in authorities.pl do not completely correspond with the values used in auth_subfields_structure.pl. Auth_subfields_structure offers only two possibilities: 0=Show all and -5=Hide all. The code in authorities.pl now checks <=-4 or >=5 (probably remains from older code). Note that the sql install scripts initialize 942c to 8. The proposed patch adds more consistency between auth_subfields_structure.pl and authorities.pl. A non-zero value will be interpreted as hidden. IMPORTANT NOTE: This solution will remove values in hidden fields from the MARC record. Imo it is theoretically the best solution, but if we do not want to take that risk, we could also remove the two next statements at line 407 and 423 and add a specific next for 942c (enforcing to always hide it). --- Comment #1 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- In the previous comment 942c must be 942a. --- Comment #2 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 64314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64314&action=ed… Bug 18811: Change visibility checks in authorities.pl The check is now <=-4 or >=5, but the framework uses 0 for Show all and -5 for Hide all. (Note that sql installer scripts also use 8.) When modifying an authority, the script also showed hidden fields when filled, since it did not check the hidden field but only the tab field. NOTE: The proposed solution restores consistency, but will remove hidden fields from the MARC record. Test plan: [1] Set field 942a to Show all in an authority framework. [2] Open a new record in this framework and verify that you see 942a. [3] Edit an existing record in this framework and verify again. [4] Set field 942a now to Hide all in this framework. [5] Open a new record in this framework and verify that 942a is hidden. [6] Edit an existing record in this framework and verify again. --- Comment #3 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Nick, Julian or Jonathan: Would you have any comment on the *risk* of this solution? --- Comment #4 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #3) > Nick, Julian or Jonathan: > Would you have any comment on the *risk* of this solution? This mail did not come through due to a mail problem that specific day. Second try :) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 [Bug 17380] Cannot edit authorities with authtypecode = default -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 46

[Bug 20977] New: Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '18

11 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20977 Bug ID: 20977 Summary: Javascript vars used in confirm_deletion in catalog.js do not match strings in catalog-strings.inc Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The naming mismatch can cause javascript errors. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 19990] New: opac/opac-discharge.pl has a FIXME that can be fixed
by bugzilla-daemon＠bugs.koha-community.org 11 Jul '18

11 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19990 Bug ID: 19990 Summary: opac/opac-discharge.pl has a FIXME that can be fixed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com The variable $available is unnecessary and can be removed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12

[Bug 20641] New: Switch single-column templates to Bootstrap grid: Various, part 2
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '18

10 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20641 Bug ID: 20641 Summary: Switch single-column templates to Bootstrap grid: Various, part 2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Blocks: 19980 This patch will convert several unrelated templates to use the Bootstrap grid: - acqui/addorderiso2709.tt - catalogue/search-history.tt - cataloguing/linkitem.tt - cataloguing/value_builder/unimarc_field_225a_bis.tt - common/patron_search.tt - labels/label-print.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 20220] New: Move template JavaScript to the footer: Holds
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '18

10 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20220 Bug ID: 20220 Summary: Move template JavaScript to the footer: Holds Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/reserve/request.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for the holds template. -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 20731] New: Move template JavaScript to the footer: Call number browser MARC plugin
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '18

10 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20731 Bug ID: 20731 Summary: Move template JavaScript to the footer: Call number browser MARC plugin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Blocks: 17858 In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for the call number browser plugin. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 20969] New: Use modal to add and edit notes from basket
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '18

10 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Bug ID: 20969 Summary: Use modal to add and edit notes from basket Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Created attachment 76211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76211&action=ed… Screenshot showing note edit form in modal When looking at orders in a basket, each order has links to add or edit vendor and internal notes. I propose that we move a copy of the notes edit form to the basket template so that a modal can be used to edit notes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 20

[Bug 20703] New: Add ability to void all credit types
by bugzilla-daemon＠bugs.koha-community.org 10 Jul '18

10 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20703 Bug ID: 20703 Summary: Add ability to void all credit types Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org At this time, only payments may be voided. There is no reason to have this limitation. There are situations where a librarian may need to void an accidental writeoff, or perhaps void an automatic credit that was created by Koha. For illustration, this is directly from a partner library: "For example a lost book refund becomes a credit on account. Presently the credit may be applied to a fine for a different item charged to patron. We perform a write off to clear the remaining credit, then add the fine back to the account and give the patron a refund for the lost/refunded amount. Our accounting system ask that we keep the Lost funds/refunds separate from all fines." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 22

[Bug 20559] New: Occurrences of loading-small.gif still exist
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '18

09 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20559 Bug ID: 20559 Summary: Occurrences of loading-small.gif still exist Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 16072 Bug 16072 removes it but there are some left: git grep -l loading-small.gif koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt koha-tmpl/opac-tmpl/bootstrap/css/opac.css koha-tmpl/opac-tmpl/bootstrap/less/opac.less at least the tools template is relevant Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16072 [Bug 16072] Include only one small spinner gif in the staff client -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 18