June 2018 - Koha-bugs - lists.koha-community.org

[Bug 7651] Add separate permission for managing currencies and exchange rates
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '18

05 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 --- Comment #19 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 75828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75828&action=ed… Bug 7651: put TT directive on a single line to help translation Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7651] Add separate permission for managing currencies and exchange rates
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '18

05 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 --- Comment #18 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 75827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75827&action=ed… Bug 7651: (QA follow-up) Fix warning about undefined active currency If no active currency is defined we show a warning. This fixes the link shown below to check the correct permission. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7651] Add separate permission for managing currencies and exchange rates
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '18

05 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 --- Comment #17 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 75826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75826&action=ed… Bug 7651: (follow-up) Correct visibility on admin sidebar This patch corrects visibility of links to the different acquisition pages from the admin sidebar. It also makes a correction to the links on the acq start page: - Budgets = period_manage - Funds = budget_manage To test: - Follow the test plan of the first patch Signed-off-by: Charles Farmer <charles.farmer(a)inLibro.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7651] Add separate permission for managing currencies and exchange rates
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '18

05 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75573|0 |1 is obsolete| | Attachment #75574|0 |1 is obsolete| | Attachment #75788|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 75825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75825&action=ed… Bug 7651: Add a new permission for managing currencies and exchange rates At the moment staff users need parameters or parameters_remaining_permissions in order to be able to change exchange rates for acquisition orders. This patch adds a new separate permission currencies_manage and updates staff users currently having those permissions to get the new permission as well. To test: - Create some staff users with different permission sets 1) superlibrarian 2) parameters 3) parameters_remaining_permissions 4) manage_circ_rules, but not parmeters_remaining_permissions 5) all acquisition permissions - Apply patch and run database update - Verify new permission has been added and staff users updated 1) remains the same 2) + 3) will have currencies_manage 4) remains unchanged, doesn't have new permission 5) remains the same, will have access now because of having the top level acquisition permission - Verify the changed pages work correctly: - navigation on admin home page NOTE: the acquisition parameters section will now honor all different related permissions (edi_manage, budget_manage,...) - navigation on acquisition home page - try to access currencies page directly Signed-off-by: Charles Farmer <charles.farmer(a)inLibro.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7651] Add separate permission for managing currencies and exchange rates
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '18

05 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20880] New: Upgraded 17.11 to 18.05: Malformed Bootstrap Theme Filenames
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '18

05 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20880 Bug ID: 20880 Summary: Upgraded 17.11 to 18.05: Malformed Bootstrap Theme Filenames Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: rcmcdonald91(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org My 18.05 (from 17.11) OPAC is trying to download files like this: 'https://library.mydomain.com/opac-tmpl/bootstrap/lib/modernizr.min_18.05000…' These files do not exist. it should be: 'https://library.graa.com/opac-tmpl/bootstrap/lib/modernizr.min.js' -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 18880] New: Regression breaks local authentication fallback for all external authentications
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '18

05 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880 Bug ID: 18880 Summary: Regression breaks local authentication fallback for all external authentications Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: oliver.bock(a)aei.mpg.de QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org Created attachment 64719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64719&action=ed… Proposed patch A regression in commit cfc484b17 / bug #18314 breaks the local authentication fallback for all external authentications like LDAP, CAS and Shibboleth. The severity is critical for us as we, while using LDAP authentication, use the self-service checkout which requires a local user account. Also non-LDAP staff can't log into the staff pages anymore. The regression itself is a logical error as "@return = (0)" is considered to be "false" when checked with "unless". That's wrong as "unless" tests the number of elements in a list. Thus the "falsy" condition has to established with "@return = ()" instead. Please find attached a proposed patch against "17.05.x". Also, please make sure the fallback workflow gets test coverage. Thanks, Oliver -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 51

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '18

05 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #20 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- IMO we should push this one along with bug 20443 (which does not have patches yet). Otherwise we are going to have 2 different ways to fetch patron's attributes. Before we only had GetBorrowerAttributes. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '18

05 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #19 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #18) > FAIL Koha/Patron/Attribute.pm > forbidden pattern: Warning: The 'sub type' may be wrong is declared in a > Koha::* package (see bug 15446) (line 127) > > Josef: > This is a more nasty one. > Could you consider renaming this method? > The Koha objects also use _type and it might be confusing. > What do you think? It already exists. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '18

05 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #18 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- FAIL Koha/Patron/Attribute.pm forbidden pattern: Warning: The 'sub type' may be wrong is declared in a Koha::* package (see bug 15446) (line 127) Josef: This is a more nasty one. Could you consider renaming this method? The Koha objects also use _type and it might be confusing. What do you think? -- You are receiving this mail because: You are watching all bug changes.

1 0