June 2018 - Koha-bugs - lists.koha-community.org

[Bug 18880] New: Regression breaks local authentication fallback for all external authentications
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '18

05 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880 Bug ID: 18880 Summary: Regression breaks local authentication fallback for all external authentications Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: oliver.bock(a)aei.mpg.de QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org Created attachment 64719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64719&action=ed… Proposed patch A regression in commit cfc484b17 / bug #18314 breaks the local authentication fallback for all external authentications like LDAP, CAS and Shibboleth. The severity is critical for us as we, while using LDAP authentication, use the self-service checkout which requires a local user account. Also non-LDAP staff can't log into the staff pages anymore. The regression itself is a logical error as "@return = (0)" is considered to be "false" when checked with "unless". That's wrong as "unless" tests the number of elements in a list. Thus the "falsy" condition has to established with "@return = ()" instead. Please find attached a proposed patch against "17.05.x". Also, please make sure the fallback workflow gets test coverage. Thanks, Oliver -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 51

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '18

05 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #20 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- IMO we should push this one along with bug 20443 (which does not have patches yet). Otherwise we are going to have 2 different ways to fetch patron's attributes. Before we only had GetBorrowerAttributes. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '18

05 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #19 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #18) > FAIL Koha/Patron/Attribute.pm > forbidden pattern: Warning: The 'sub type' may be wrong is declared in a > Koha::* package (see bug 15446) (line 127) > > Josef: > This is a more nasty one. > Could you consider renaming this method? > The Koha objects also use _type and it might be confusing. > What do you think? It already exists. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '18

05 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #18 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- FAIL Koha/Patron/Attribute.pm forbidden pattern: Warning: The 'sub type' may be wrong is declared in a Koha::* package (see bug 15446) (line 127) Josef: This is a more nasty one. Could you consider renaming this method? The Koha objects also use _type and it might be confusing. What do you think? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '18

05 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #17 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 75822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75822&action=ed… Bug 12159: (QA follow-up) Silencing POD warn from qa tools *** ERROR: Spurious text after =cut at line 954 in file Koha/Patron.pm -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '18

05 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #16 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 75812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75812&action=ed… Bug 12159: Add tests Test plan: prove t/db_dependent/Koha/Patron/Attributes.t t/db_dependent/Koha/Patrons.t Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '18

05 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74791|0 |1 is obsolete| | Attachment #74792|0 |1 is obsolete| | --- Comment #15 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 75811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75811&action=ed… Bug 12159: Fix getting extended patron attributes for circ-menu Changes: - Replace getting preference ExtendedPatronAttributes by Koha.Preference in templates - Add Koha::Patron->attributes for getting patrons extended attributes - Use this method in circ-menu.inc - Remove getting attributes from members perl scripts Test plan: 0) Apply the patch 1) Add some patron attributes type - with free text, authorised value, limited by libraries... 2) Add some values to this attributes for some patrons 3) Go through as many patron pages as you can and confirm that attributes are shown at side panel when they shoul and are not shown when they should not be shown Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '18

05 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7651] Add separate permission for managing currencies and exchange rates
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '18

05 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 Bug 7651 depends on bug 3849, which changed state. Bug 3849 Summary: Descriptions of acquisition permissions are unclear https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3849] Descriptions of acquisition permissions are unclear
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '18

05 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED --- Comment #21 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Not pushing to 18.05.x as it could surprise unsuspecting librarians during a minor update. Nice fix for 18.11 though, marking resolved. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0