June 2018 - Koha-bugs - lists.koha-community.org

[Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '18

01 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 --- Comment #20 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 75737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75737&action=ed… Bug 11911: (follow-up) Hide suggestion box on acq start page if no permission When the user is not superlibrarian or has the manage_suggestions permission, the suggestion box on the left of the acq start page needs to be hidden. Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '18

01 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75630|0 |1 is obsolete| | Attachment #75631|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 75736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75736&action=ed… Bug 11911: Add a separate permission for managing suggestions Without this patch only catalogue permission was required for managing suggestions. This patch adds a new permission in the acquisition module do manage suggestions and updates staff user permissions accordingly. To test: - Make sure there is a pending suggestion - Create a few users with different permission sets: - User 1: only catalogue - User 2: any acquisition permission - User 3: cataloguing permission - Check all of them can access: /cgi-bin/koha/suggestion/suggestion.pl - Apply the patch - Verify all of them now have the suggestions_manage permission - Verify everything displays correctly on: - intranet start page - patron account in staff - acquisition start page - suggestion page (try to access by URL too) - Remove suggestions_manage for a staff user - Repeat tests above, access should be denied/links not visible Bonus: - Fixes the link on the acquisition start page for late orders to mage the permissions of the page itself: order_receive Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '18

01 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '18

01 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 --- Comment #18 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #17) > After the require the new { acquisition => 'suggestions_manage' } they* -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '18

01 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #17 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- We should highlight the change in the release notes: Before: members/purchase-suggestions.pl required { borrowers => 'edit_borrowers' } suggestion/suggestion.pl required { catalogue => 1 } After the require the new { acquisition => 'suggestions_manage' } -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13049] Merge selfreg cron jobs into cleanup_database
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '18

01 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 --- Comment #20 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Marcel de Rooy from comment #19) > (In reply to Katrin Fischer from comment #18) > > It looks like this change introduced a regression. Before the changes it was > > possible to define the delay for unverified registrations in hours and now > > it's days. It will also change what actually happens when you switch over? > > > > With GDPR being very strict about saving data the initial feature of being > > able to delete after x hours would be better. > > I think you are being even stricter now :) Triggered by a request from a library. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13049] Merge selfreg cron jobs into cleanup_database
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '18

01 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20856 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20856 [Bug 20856] Restore ability to delete unverified self registrations after x hours -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13049] Merge selfreg cron jobs into cleanup_database
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '18

01 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 --- Comment #19 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #18) > It looks like this change introduced a regression. Before the changes it was > possible to define the delay for unverified registrations in hours and now > it's days. It will also change what actually happens when you switch over? > > With GDPR being very strict about saving data the initial feature of being > able to delete after x hours would be better. I think you are being even stricter now :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13049] Merge selfreg cron jobs into cleanup_database
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '18

01 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 --- Comment #18 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- It looks like this change introduced a regression. Before the changes it was possible to define the delay for unverified registrations in hours and now it's days. It will also change what actually happens when you switch over? With GDPR being very strict about saving data the initial feature of being able to delete after x hours would be better. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '18

01 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #95 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Preliminary QA: Very brave to take this upon you ! Tiny suggestion: .decimal-unformating Fix spelling please. At least t => tt but what is decimal unformat btw? Better name? Something with normalize or so?? I have the feeling that DecimalSeparators and CurrencyFormat don't really harmonize. And yes, I can understand how problematic making changes in this area must be.. So thousands separators come at the expense of handling both dots and commas. Still opt for something that is more understandable. The number of changes to be expected here would be much larger. You actually use the new js formatting in three acq templates. What about things like: C4/Biblio.pm: $subfield_value =~ s/\./,/ if C4::Context->preference("CurrencyFormat") eq "FR"; acqui/addorderiso2709.pl: $price =~ s/\./,/ if C4::Context->preference("CurrencyFormat") eq "FR"; acqui/addorderiso2709.pl: $price =~ s/\./,/ if C4::Context->preference("CurrencyFormat") eq "FR"; Koha/Number/Price.pm $format_params = { %$format_params, int_curr_symbol => '', mon_thousands_sep => '', mon_decimal_point => '.', }; koha-tmpl/intranet-tmpl/prog/en/includes/format_price.inc [% IF Koha.Preference("CurrencyFormat") == 'FR' %] var default_value = { thousands_sep: ' ', decimal_point: ',', decimal_digits: 2 }; And this is just to name a few; the list could probably be larger when searching harder. It might be impossible to make global changes but the risk of this is adding just another approach in a few places and leaving Koha even more fragmented on the subject? Changing state for need of feedback or adjustments. -- You are receiving this mail because: You are watching all bug changes.

1 0