July 2018 - Koha-bugs - lists.koha-community.org

[Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '18

16 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #30 from Chris Nighswonger <cnighswonger(a)foundations.edu> --- (In reply to Marcel de Rooy from comment #24) > (In reply to Chris Nighswonger from comment #22) > > (In reply to Marcel de Rooy from comment #19) > > > Chris: > > > I have the impression > > > > Just an impression? ;-) Did you test and find a case where this fix does not > > work? > Please keep in mind that we both have the same goal: fix bugs and improve > code. QAing is more than testing. A careful look at the code can in my > experience reveal bugs just as easy or show you what to test. No offense intended. I understand that we have the same goal. I appreciate your contribution to the QA process. Please keep in mind that my time is extremely limited. Much more so than devs who are paid to work on Koha as I am paid to work on other projects. When you provide QA feedback without a supporting proof-case, it means that the dev has to spend time ensuring 1. your observation is valid and 2. Ensuring that the fix does not cause other problems. Time is expensive to be spending on an impression without accompanying demonstrable failure cases. > > > $binary_data is a reference to $image_data->{'imagefile'} which, in turn, is > > a reference to a hash created by DBI containing the results of the SELECT. > > DBI creates a new hash on every row retrieval[1], ensuring that the data > > contained at our reference is fresh every time. > The crux is here indeed. This is only partially true. The code does only > update $image_data in two of the if statement branches. So my observation > and request is just to clear $image_data each time in the loop or put its > definition into the loop. Clearing the other variables might be unneeded > since they are created in the loop. > So this reveals a test case: Make sure that record 1 in the loop is a patron > image and record 2 comes in the eq 'none' branch. Record 2 will use the old > value of $image_data. FTR: I have no problem undefing the entire $image_data reference. As soon as I have time, I will submit a follow-up patch. I also inadvertently removed the statements which short-circuit the loop in the case of no image data. That needs to be corrected as well. That said: Your suggested case does not cause the failure you suggest. I understand that $image_data never drops out of scope during the loop execution. I understand that in theory the reference can contain "stale" data. I just have not been handed and cannot establish a test case where it does. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19709] New: Move template JavaScript to the footer: Labels
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '18

16 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 Bug ID: 19709 Summary: Move template JavaScript to the footer: Labels Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: dominic.pichette(a)inlibro.com, jonathan.druart(a)bugs.koha-community.org, nick(a)bywatersolutions.com, simon.pouchol(a)biblibre.com, testopia(a)bugs.koha-community.org Depends on: 19647 Blocks: 17858 In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for label creator templates. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647 [Bug 19647] Move patron lists templates JS to the footer -- You are receiving this mail because: You are watching all bug changes.

1 41

[Bug 11176] Purchase suggestions should respect the 'active' switch on budgets
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '18

16 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11176 --- Comment #6 from Marjorie Barry-Vila <marjorie.barry-vila(a)collecto.ca> --- In 17.05, there is an other problem: when creating a new suggestion, active funds do not appear at first time. You have to save the suggestion and then go back to see active funds (with all inactive funds too). Anyone works on this? Regards Marjorie -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11176] Purchase suggestions should respect the 'active' switch on budgets
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '18

16 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11176 Marjorie Barry-Vila <marjorie.barry-vila(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21040 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '18

16 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #31 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #29) > Why BLOCKED? See comment 20. (In reply to Martin Renvoize from comment #30) > I believe Tomas is working on bug 20443.. which I think is the blocker here. See assignee field, I am working on it. Please do not change anything here. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9296] overduerules table needs restructuring to allow future extension
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '18

16 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9296 --- Comment #13 from Blou <philippe.blouin(a)inlibro.com> --- We'd love to, and we'll certain support (with testing) anyone working on it or similar patch, but it won't be us (inLibro) doing the coding at this point I'm sorry to say. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '18

16 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21079 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21079 [Bug 21079] Unify metadata schema across backends -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18851] New: use Test::DBIx::Class in 00-load.t breaks packaging
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '18

16 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Bug ID: 18851 Summary: use Test::DBIx::Class in 00-load.t breaks packaging Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: mirko(a)abunchofthings.net QA Contact: testopia(a)bugs.koha-community.org Bug 18266 introduces a regression for a problem fixed in Bug 15150. Test::DBIx::Class is not mandatory because it is not available in Debian, packaging of Koha is broken because of the use in t/00-load.t. -- You are receiving this mail because: You are watching all bug changes.

1 44

[Bug 12772] Overdue Notice/Status triggers tool
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '18

16 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
by bugzilla-daemon＠bugs.koha-community.org 16 Jul '18

16 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 --- Comment #29 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #28) > This is a privacy issue, I just didn't want it to die "in discussion". Yeah it is. No problem! Thx for following up.. Imo we are just clearing one variable away from PQA. I only need to convince Chris.. -- You are receiving this mail because: You are watching all bug changes.

1 0