August 2018 - Koha-bugs - lists.koha-community.org

[Bug 13618] Prevent XSS in the Staff Client and the OPAC
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '18

30 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #247 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #245) > Created attachment 78274 [details] [review] > Bug 13618: (follow-up) Add html filters to all the variables Followup pushed to master -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21194] New: East analytics show wrong title when linking to host
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '18

30 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21194 Bug ID: 21194 Summary: East analytics show wrong title when linking to host Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl To recreate: 1 - Enable easy analytics 2 - Find a record, say "Pikachu: A life in letters" 3 - Click 'Edit->Link to host item' 4 - Enter a barcode from a different record say "Ash: why was he compelled to catch them all?" 5 - Note the message after linking is 'The item has successfully been linked to Pikachu: a life in letters' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 15565] Place multiple holds at once for the same record
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '18

30 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '18

30 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #91 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 78305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78305&action=ed… Bug 15565: Allow up to (and including) maxreserves number of OPAC item levelholds This commit implements changes to opac-reserve.tt and opac-reserve.pl. 1. The change to opac-reserve.tt JS fixes the total_requested() function which returns an output which is always 2 digits higher than the actual number of selected item checkboxes. i.e. if the 'maxreserves' syspref (limit for the overall number of reserves allowed by a user) is 4 and a user has no previous holds and ticks 3 item checkboxes and submits the form. The 'Maximum number of reserve exceded.' popup message is displayed, however as they have selected 3 items for reservation this is less than the maxreserves value of 4. The popup is displayed because total_requested() JS function is returning 5 (i.e. 2 on top of the actual number of requested holds). This commit usbtracts 2 from the number of holds calculated by total_requested() so that the accurate number of requested holds is being used to determine whether or not to display the excess holds popup. 2. When the 'Holds per record (count)' (circulation rule) and 'maxreserves' syspref are the same value (e.g. 4) you can tick 4 item checkboxes in opac-reserve.pl and submit the form. The form will submit successfully and to the user everything looks to have worked however the holds will not be successfully created. This is because after the form is submitted to opac-reserve.pl a check is done: If 'number of submitted hold requests' + 'number of previous existing holds' greater than or equal to maxreserves syspref then set the variable '$canreserve' to 0. If the $canreserve variable is 0 the form will submit, no warning/error message is displayed to the user but the holds are not created. Users should be able to place 4 holds if the maxreserves syspref is 4 (just not more than 4 holds). This commit changes this check to: If 'number of submitted hold requests' + 'number of previous existing holds' greater than maxreserves syspref then set the variable '$canreserve' to 0.. i.e. notice we only check for greater than (not equal to). Which solves the bug of the form submitting and no holds being created when the maxreserves syspref and 'Holds per record (count)' (circulation rule) are the same. Test plan (in two parts to test fix #1 and #2 (above)): Test plan for fix #1: 1. Apply all patches on this bug report (15565) and follow and confirm the feature works as described in the test plan in the first commit 2. Set the 'maxreserves' syspref to 3 (and 'Holds per record (count)' (circulation rule) to 5) 3. Ensure your logged in patron account has no existing reserves 4. In the OPAC go to a biblio page with 3 or more items 5. In the reservation page (opac-reserve.pl) for that biblio select 2 item checkboes to place 2 item level holds and notice the 'Maximum number of reserve exceded.' popup message is displayed. As the maxreserves syspref value is 3 you should be able to place 2 holds without exceeding that value 6. Apply this patch 7. Repeat step 5 and notice the form submits without the exceeding popup message and the holds are successfully placed. Test plan for fix #2: 1. Apply all patches attached to this bug report (bug 15565) and perform the test plan in the first commit and verify it works. 2. Set your 'Holds per record (count)' (circulation rule) and 'maxreserves' syspref to the same value 3 3. Go to a biblio in the OPAC with 3 or more items 4. In the opac-reserve.pl reservation interface for that biblio tick 3 item checkboxes to place 3 item level holds and submit the form. 5. Notice the form submits and no warning/error message is displayed 6. In the opac user summary page that is displayed after the reserve form is submitted notice the holds are not displayed this is because they have not been placed 7. Apply this patch 8. Repeat step 4 and 5 and notice the holds have been successfully placed and are displayed in your opac user summary page. Sponsored-By: Brimbank Library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '18

30 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #83 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- [Koha] Course reserves widget -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10659] Upgrade jQuery star ratings plugin
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '18

30 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 Cab Vinton <bibliwho(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |bibliwho(a)gmail.com --- Comment #16 from Cab Vinton <bibliwho(a)gmail.com> --- The sandbox you've requested is not ready. Some problems occurred applying patches from bug 10659: <h1>Something went wrong !</h1>Applying: Bug 10659: Upgrade jQuery star ratings plugin error: Failed to merge in the changes. Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt Falling back to patching base and 3-way merge... Removing koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.rating.js Removing koha-tmpl/opac-tmpl/bootstrap/images/star-ratings-sprite.png Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt Removing koha-tmpl/opac-tmpl/bootstrap/css/jquery.rating.css Patch failed at 0001 Bug 10659: Upgrade jQuery star ratings plugin The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 10659 - Upgrade jQuery star ratings plugin 77740 - Bug 10659: Upgrade jQuery star ratings plugin 77741 - Bug 10659: (follow-up) Add plugin information to the about page Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-10659-Upgrade-jQuery-star-ratings-plugin-4vjbbb.patch . -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '18

30 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #58 from Cab Vinton <bibliwho(a)gmail.com> --- Signed off in PTFS Sandbox 0. But note that the dropdown setting appears to control. In other words, once the dropdown is displayed, that setting sticks, even if the preference setting is changed or if the user logs out of the staff client or OPAC. This is also true if the dropdown is subsequently hidden. So, once the dropdown has been displayed, that is where the Results per page must be set & the system preference does not control. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '18

30 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #57 from PTFS Europe Sandboxes <sandboxes(a)ptfs-europe.com> --- Created attachment 78302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78302&action=ed… Bug 14715: [FOLLOW-UP] Fix results not showing This fixes the display issue for me. Can someone please test? Signed-off-by: Cab Vinton <bibliwho(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '18

30 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #56 from PTFS Europe Sandboxes <sandboxes(a)ptfs-europe.com> --- Created attachment 78301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78301&action=ed… Bug 14715: [FOLLOW-UP] Rebase and fix up I noticed that the two sysprefs initially created with this patch weren't really being used, so I removed them. Instead I've added two new sysprefs: numSearchResultsDropdown OPACnumSearchResultsDropdown that control whether the dropdown shows or not. Otherwise the defaults in numSearchResults and OPACnumSearchResults are used to decide number of search results per page. When testing: Run updatedatabase.pl Test with values in numSearchResults and OPACnumSearchResults. Use original test plan in Comment 12 but test with the dropdown sysprefs off and on. Sponsored-by: Region Halland Signed-off-by: Cab Vinton <bibliwho(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '18

30 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #55 from PTFS Europe Sandboxes <sandboxes(a)ptfs-europe.com> --- Created attachment 78300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78300&action=ed… Bug 14715: [FOLLOW-UP] Removing 'all' option, fixing QA tools issues Signed-off-by: Simon Pouchol <simon.pouchol(a)biblibre.com> Signed-off-by: Cab Vinton <bibliwho(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0