August 2018 - Koha-bugs - lists.koha-community.org

[Bug 10659] Upgrade jQuery star ratings plugin
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '18

30 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 Cab Vinton <bibliwho(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |bibliwho(a)gmail.com --- Comment #16 from Cab Vinton <bibliwho(a)gmail.com> --- The sandbox you've requested is not ready. Some problems occurred applying patches from bug 10659: <h1>Something went wrong !</h1>Applying: Bug 10659: Upgrade jQuery star ratings plugin error: Failed to merge in the changes. Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt Falling back to patching base and 3-way merge... Removing koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.rating.js Removing koha-tmpl/opac-tmpl/bootstrap/images/star-ratings-sprite.png Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt Removing koha-tmpl/opac-tmpl/bootstrap/css/jquery.rating.css Patch failed at 0001 Bug 10659: Upgrade jQuery star ratings plugin The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 10659 - Upgrade jQuery star ratings plugin 77740 - Bug 10659: Upgrade jQuery star ratings plugin 77741 - Bug 10659: (follow-up) Add plugin information to the about page Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-10659-Upgrade-jQuery-star-ratings-plugin-4vjbbb.patch . -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '18

30 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #58 from Cab Vinton <bibliwho(a)gmail.com> --- Signed off in PTFS Sandbox 0. But note that the dropdown setting appears to control. In other words, once the dropdown is displayed, that setting sticks, even if the preference setting is changed or if the user logs out of the staff client or OPAC. This is also true if the dropdown is subsequently hidden. So, once the dropdown has been displayed, that is where the Results per page must be set & the system preference does not control. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '18

30 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #57 from PTFS Europe Sandboxes <sandboxes(a)ptfs-europe.com> --- Created attachment 78302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78302&action=ed… Bug 14715: [FOLLOW-UP] Fix results not showing This fixes the display issue for me. Can someone please test? Signed-off-by: Cab Vinton <bibliwho(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '18

30 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #56 from PTFS Europe Sandboxes <sandboxes(a)ptfs-europe.com> --- Created attachment 78301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78301&action=ed… Bug 14715: [FOLLOW-UP] Rebase and fix up I noticed that the two sysprefs initially created with this patch weren't really being used, so I removed them. Instead I've added two new sysprefs: numSearchResultsDropdown OPACnumSearchResultsDropdown that control whether the dropdown shows or not. Otherwise the defaults in numSearchResults and OPACnumSearchResults are used to decide number of search results per page. When testing: Run updatedatabase.pl Test with values in numSearchResults and OPACnumSearchResults. Use original test plan in Comment 12 but test with the dropdown sysprefs off and on. Sponsored-by: Region Halland Signed-off-by: Cab Vinton <bibliwho(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '18

30 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #55 from PTFS Europe Sandboxes <sandboxes(a)ptfs-europe.com> --- Created attachment 78300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78300&action=ed… Bug 14715: [FOLLOW-UP] Removing 'all' option, fixing QA tools issues Signed-off-by: Simon Pouchol <simon.pouchol(a)biblibre.com> Signed-off-by: Cab Vinton <bibliwho(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '18

30 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #54 from PTFS Europe Sandboxes <sandboxes(a)ptfs-europe.com> --- Created attachment 78299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78299&action=ed… Bug 14715: [FOLLOW-UP] Fixing qa-tools issues and merge conflicts Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Cab Vinton <bibliwho(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '18

30 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #53 from PTFS Europe Sandboxes <sandboxes(a)ptfs-europe.com> --- Created attachment 78298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78298&action=ed… Bug 14715: results per page setting for catalog search Add new select field to catalog search results pages which allows user to set number of results to be shown per page. Setting saved in cookie "results_per_page". To test: 1) Do a catalog search in the intranet and OPAC 2) Confirm that results automatically update upon selection of results per page to show 3) Test for all options (20, 40, 60, 80, 100, all) Bug 14715: syspref for results per page options Remove the "all" option. Add syspref [OPAC]numSearchResultsPerPage for specifying options for numbers of results per page including [OPAC]numSearchResults. Bug 14715: database updates Bug 14715: Fixing pagination problems Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Cab Vinton <bibliwho(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '18

30 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 PTFS Europe Sandboxes <sandboxes(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78230|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '18

30 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 PTFS Europe Sandboxes <sandboxes(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75941|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '18

30 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 PTFS Europe Sandboxes <sandboxes(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75940|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0