August 2018 - Koha-bugs - lists.koha-community.org

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 --- Comment #40 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 78284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78284&action=ed… Bug 15184: Add POD -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 --- Comment #39 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 78283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78283&action=ed… Bug 15184: Add users ? We certainly do not want this patch. What about users that are notified on receiving? Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 --- Comment #38 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 78282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78282&action=ed… Bug 15184: Add the ability to duplicate existing order lines This patchset adds the ability to duplicate existing order lines to a given basket. It will help acquisitions of serials of when the same publication is ordered frequently. The workflow will be: - Create a new basket - Use the "Add to basket" button - Select the new entry "From existing orders (copy)" - Search and select the order you want to duplicate - Define some default values for these orders - Duplicate! Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 --- Comment #37 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 78281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78281&action=ed… Bug 15184: Add the ordernumbers filters to GetHistory It adds the ability to return the result of GetHistory given a list a ordernumbers Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 --- Comment #36 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 78280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78280&action=ed… Bug 15184: Prepare the ground - Move funds and sort fields autoupdate We are going to reuse the same logic: when a fund is selected the statistic values are automatically updated. Let move it to make it reusable more easily and isolate the code. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78074|0 |1 is obsolete| | Attachment #78075|0 |1 is obsolete| | Attachment #78076|0 |1 is obsolete| | Attachment #78077|0 |1 is obsolete| | Attachment #78078|0 |1 is obsolete| | Attachment #78277|0 |1 is obsolete| | Attachment #78278|0 |1 is obsolete| | --- Comment #35 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 78279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78279&action=ed… Bug 15184: Prepare the ground - Move order search filters We are going to reuse these filters so we move it to a separate include file. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 --- Comment #34 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #29) > QA scripts complain about missing POD: > FAIL pod coverage > POD is missing for add_user > POD is missing for duplicate_to > POD is missing for items > POD is missing for users Added in the last follow-up. > This looks a little odd: > + <label for="fund">Fund: </label> > + <select name="budget" id="fund"> Moved from acqui/histsearch.tt, existed before this patch. > Wondering about missing |html filters, especially in > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt. Added missing filters in a separate patch. (In reply to Katrin Fischer from comment #30) > Also, can you please explain the last patch? > > Bug 15184: Add users ? > > We certainly do not want this patch. What about users that are notified > on receiving? When an order is duplicated, do we want to duplicate the user list who were notified on receiving? I.e. they will be notified on receiving items for the duplicated order. I was not sure if it was wanted or not, so I put that code on a separate patch and waited for a feedback. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 --- Comment #33 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 78278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78278&action=ed… Bug 15184: add missing filters -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 --- Comment #32 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 78277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78277&action=ed… Bug 15184: Add POD -- You are receiving this mail because: You are watching all bug changes.

1 0