August 2018 - Koha-bugs - lists.koha-community.org

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '18

28 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 paxed <pasi.kallinen(a)joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen(a)joensuu.fi --- Comment #9 from paxed <pasi.kallinen(a)joensuu.fi> --- Comment on attachment 78212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78212 Bug 15529 - Lock /var/lock/koha/<instance>/messagequeue.lock while running process_message_queue.pl AFAICS, no other cronjob script uses one of the debian/scripts/koha- -scripts ... I wonder if this works for everyone? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '18

28 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #8 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 78212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78212&action=ed… Bug 15529 - Lock /var/lock/koha/<instance>/messagequeue.lock while running process_message_queue.pl The script loops through every enabled instance. It checks if the messagequeue.lock file is locked in the instance directory. If not then the cronjob runs. If the lock file is locked then this is logged and a email is sent out. Test plan: 1. In two terminals open koha-shell and try to run ./process_message_queue.pl and notice you can run the script multiple times simulataneously without a warning/error being displayed 2. Apply patch 3. Repeast step 1 and notice that the second of the two scripts to be run will output text saying './process_message_queue.pl is already running. Exiting' In this case the aforementioned text is displayed and the body of the cronjob is not run. 4. The first cronjob script to run, runs without issues Sponsored-By: Parliament Library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '18

28 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78211|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '18

28 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #7 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 78211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78211&action=ed… Bug 15529 - Lock /var/lock/koha/<instance>/messagequeue.lock while running process_message_queue.pl The script loops through every enabled instance. It checks if the messagequeue.lock file is locked in the instance directory. If not then the cronjob runs. If the lock file is locked then this is logged and a email is sent out. Test plan: 1. In two terminals open koha-shell and try to run ./process_message_queue.pl and notice you can run the script multiple times simulataneously without a warning/error being displayed 2. Apply patch 3. Repeast step 1 and notice that the second of the two scripts to be run will output text saying './process_message_queue.pl is already running. Exiting' In this case the aforementioned text is displayed and the body of the cronjob is not run. 4. The first cronjob script to run, runs without issues Sponsored-By: Parliament Library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '18

28 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78210|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '18

28 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #6 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 78210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78210&action=ed… Bug 15529 - Lock /var/lock/koha/<instance>/messagequeue.lock while running process_message_queue.pl The script loops through every enabled instance. It checks if the messagequeue.lock file is locked in the instance directory. If not then the cronjob runs. If the lock file is locked then this is logged and a email is sent out. Test plan: 1. In two terminals open koha-shell and try to run ./process_message_queue.pl and notice you can run the script multiple times simulataneously without a warning/error being displayed 2. Apply patch 3. Repeast step 1 and notice that the second of the two scripts to be run will output text saying './process_message_queue.pl is already running. Exiting' In this case the aforementioned text is displayed and the body of the cronjob is not run. 4. The first cronjob script to run, runs without issues 5. At the end of the execution of the first script a 15 second pause is run Sponsored-By: Parliament Library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '18

28 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78205|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news entry
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '18

28 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 --- Comment #72 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Rebased, ready for testing -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news entry
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '18

28 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78104|0 |1 is obsolete| | --- Comment #71 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 78208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78208&action=ed… Bug 14272: (follow-up) Fixing template error and layout To test, confirm that OpacMainUserBlock and Quote of the Day do not show if viewing a single news item, but do show otherwise. Confirm user dashboard shows where expected Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> UPDATE 24/Aug: Add expiration date text -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news entry
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '18

28 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77568|0 |1 is obsolete| | --- Comment #70 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 78207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78207&action=ed… Bug 14272: (follow-up) only display news available for a particular opac lang [alternative patch] Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0