August 2018 - Koha-bugs - lists.koha-community.org

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #45 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 78240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78240&action=ed… Bug 15326: (follow-up) Interface fixes This patch addresses the following: a) I feel we don't need the "Pages" heading. It only takes up space and states the obvious. (non-blocker... but navigation needs work, see below) b) OpacMainUserBlock should not show on the pages in my opinion. Libraries use it to place text on the start page instead of using the news feature, which means it repeats on all pages. I'd really like to see this changed. c) Personally I'd change "Location" to "Interface" to avoid confusion with the item value in translations. But I see it's the same on news. So out of scope here. d) Parent pages can be deleted without warning. Childs will be moved to top level. This is acceptable behaviour as they are not left orphaned. But it might be something to improve on in the future. e) In the test plan and in the code I see there should be a confirmation message on deleting a single or multiple entries, but this doesn't work. (blocker) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16702] New: Notice Triggers Issue: Delivery Mechanism Options Not Saving
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16702 Bug ID: 16702 Summary: Notice Triggers Issue: Delivery Mechanism Options Not Saving Change sponsored?: --- Product: Koha Version: 16.05 Hardware: PC OS: Linux Status: NEW Severity: blocker Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: bassplayer9(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org Problem with Notice & Status Triggers (Tools › Notice triggers) When attempting to save my notice trigger configuration after (1) setting a delay integer, (2) selecting an overdue notice template, and (3) then choosing a delivery type (Email, SMS, etc.), the configuration saves but without the any of the delivery method types saving/sticking - they reset to an unchecked status. I do get a "changes saved" confirmation overall, but my delivery mechanism selections disappear for Email, Print, and SMS after clicking the "Save Changes" button. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 15520] Add more granular permission for only editing own library's circ rules
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Cab Vinton <bibliwho(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho(a)gmail.com --- Comment #23 from Cab Vinton <bibliwho(a)gmail.com> --- Issues in Biblibre Sandbox 1: Some problems occurred applying patches from bug 15520: <h1>Something went wrong !</h1>Applying: Bug 15520: Add permission to restrict circ rules editing to own library Using index info to reconstruct a base tree... M admin/smart-rules.pl M koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt Auto-merging admin/smart-rules.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 15520: Add permission to restrict circ rules editing to own library The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 15520 - Add more granular permission for only editing own library's circ rules 77219 - Bug 15520: Add permission to restrict circ rules editing to own library 77220 - Bug 15520: Rename permission to manage_circ_rules_from_any_libraries Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-15520-Add-permission-to-restrict-circ-rules-ed-GgcAa1.patch . -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Cab Vinton <bibliwho(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho(a)gmail.com --- Comment #35 from Cab Vinton <bibliwho(a)gmail.com> --- Tested in Biblibre Sandbox 1 -- Digital signs does not appear under Tools/Additional Tools. cgi-bin/koha/opac-signs.pl not found on server. OPACDigitalSigns system preference is added. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #44 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 78238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78238&action=ed… Bug 15326: (follow-up) Code review fixes Addresses the following issues: b) In opac-cmspages there is: + flagsrequired => { borrow => 1 }, The borrow permission has been removed since. (blocker) c) Comment was removed unnecessarily, just needs to be moved into its right spot below again: -# If GoogleIndicTransliteration system preference is On Set parameter to load Google's javascript in OPAC search screens d) One file uses qw( -utf-8) but another does not: +use CGI; +use CGI qw( -utf8 ); (blocker) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Cab Vinton <bibliwho(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho(a)gmail.com --- Comment #49 from Cab Vinton <bibliwho(a)gmail.com> --- Patch failed in PTFS Sandbox 0: The sandbox you've requested is not ready. Some problems occurred applying patches from bug 8630: <h1>Something went wrong !</h1>Applying: Bug 8630 - Adlibris covers (syspref files) Applying: Bug 8630 - Adlibris covers (intranet templates) Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Applying: Bug 8630 - Adlibris covers (intranet CSS) error: Failed to merge in the changes. Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/css/staff-global.css Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/css/staff-global.css CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/css/staff-global.css Patch failed at 0001 Bug 8630 - Adlibris covers (intranet CSS) The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 8630 - Add covers from AdLibris to the OPAC and Intranet 76848 - Bug 8630 - Adlibris covers (syspref files) 76849 - Bug 8630 - Adlibris covers (intranet templates) 76850 - Bug 8630 - Adlibris covers (intranet CSS) 76851 - Bug 8630 - Adlibris covers (OPAC templates) 76852 - Bug 8630 - Adlibris covers (OPAC less changes) 76853 - Bug 8630: [FOLLOW-UP] Make Adlibris cover show on OPAC overdues tab 76859 - Bug 8630: Regenerated minified OPAC CSS Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-8630---Adlibris-covers-intranet-CSS-11sz87.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #43 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Rebased, working on things in Comment 36 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76392|0 |1 is obsolete| | --- Comment #42 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 78237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78237&action=ed… Bug 15326: (follow-up) Fix tools menu highlighting Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76391|0 |1 is obsolete| | --- Comment #41 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 78236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78236&action=ed… Bug 15326: (follow-up) Don't make links to unpublished pages in opac Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76390|0 |1 is obsolete| | --- Comment #40 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 78235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78235&action=ed… Bug 15326: (follow-up) Move js to footer, use Asset plugin Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0