August 2018 - Koha-bugs - lists.koha-community.org

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #44 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 78238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78238&action=ed… Bug 15326: (follow-up) Code review fixes Addresses the following issues: b) In opac-cmspages there is: + flagsrequired => { borrow => 1 }, The borrow permission has been removed since. (blocker) c) Comment was removed unnecessarily, just needs to be moved into its right spot below again: -# If GoogleIndicTransliteration system preference is On Set parameter to load Google's javascript in OPAC search screens d) One file uses qw( -utf-8) but another does not: +use CGI; +use CGI qw( -utf8 ); (blocker) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '18

29 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Cab Vinton <bibliwho(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho(a)gmail.com --- Comment #49 from Cab Vinton <bibliwho(a)gmail.com> --- Patch failed in PTFS Sandbox 0: The sandbox you've requested is not ready. Some problems occurred applying patches from bug 8630: <h1>Something went wrong !</h1>Applying: Bug 8630 - Adlibris covers (syspref files) Applying: Bug 8630 - Adlibris covers (intranet templates) Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Applying: Bug 8630 - Adlibris covers (intranet CSS) error: Failed to merge in the changes. Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/css/staff-global.css Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/css/staff-global.css CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/css/staff-global.css Patch failed at 0001 Bug 8630 - Adlibris covers (intranet CSS) The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 8630 - Add covers from AdLibris to the OPAC and Intranet 76848 - Bug 8630 - Adlibris covers (syspref files) 76849 - Bug 8630 - Adlibris covers (intranet templates) 76850 - Bug 8630 - Adlibris covers (intranet CSS) 76851 - Bug 8630 - Adlibris covers (OPAC templates) 76852 - Bug 8630 - Adlibris covers (OPAC less changes) 76853 - Bug 8630: [FOLLOW-UP] Make Adlibris cover show on OPAC overdues tab 76859 - Bug 8630: Regenerated minified OPAC CSS Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-8630---Adlibris-covers-intranet-CSS-11sz87.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '18

28 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #43 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Rebased, working on things in Comment 36 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '18

28 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76392|0 |1 is obsolete| | --- Comment #42 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 78237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78237&action=ed… Bug 15326: (follow-up) Fix tools menu highlighting Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '18

28 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76391|0 |1 is obsolete| | --- Comment #41 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 78236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78236&action=ed… Bug 15326: (follow-up) Don't make links to unpublished pages in opac Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '18

28 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76390|0 |1 is obsolete| | --- Comment #40 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 78235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78235&action=ed… Bug 15326: (follow-up) Move js to footer, use Asset plugin Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '18

28 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76389|0 |1 is obsolete| | --- Comment #39 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 78234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78234&action=ed… Bug 15326: (follow-up) utf8 to utf8mb4 Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '18

28 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76388|0 |1 is obsolete| | --- Comment #38 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 78233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78233&action=ed… Bug 15326: (follow-up) Add CMS feature This patch builds on Martin Persson's patch. I made a few changes that improve the patch and make this feature functional. The only thing I am not completely satisfied with (and doesn't reliably work) is the navigation for the CMS pages on both the staff side and the OPAC side. This needs work. Otherwise the CMS feature works. - Make sure you update database after applying patch - After adding a few pages, confirm that filtering results works (play with different combinations of display location, library and language) - Confirm that pages with specific locations ONLY show up in those locations, i.e. OPAC pages can only be accessed in OPAC and staff interface pages can only be accessed on staff client - Confirm that table is showing correct data, particularly language, location and library - Confirm that if page has not been published and user does not have permission to edit pages, page content will not display on OPAC side. On staff side, a message will show saying that page has not been published - Confirm pagination for table shows and works - Confirm deleting pages works as expected (confirm message before delete) - Confirm link title must be unique when adding new pages - Confirm that editing the details of an existing page works - Confirm that adding a child page will only work if the location of child page matches location of parent page, i.e., if parent page is an OPAC page then child page must also be OPAC page. if parent page is in all locations then child page can be in all or either interface(s) - Confirm Select All/Clear All toggle works - Confirm viewing of CMS pages in OPAC and in staff client works and looks nice Sponsored-by: Region Halland Bug 15326: [FOLLOW-UP] Many fixes This patch: - moves action buttons into a dropdown, adds a delete button to dropdown - fixes the tests (they should now all pass) - fixes qa tool problems - removes the Koha::CmsPages->remove() method (unnecessary) - makes changes to the Koha::CmsPages->add() method (now simpler, easier to test) This is now ready to test. Sponsored-by: Catalyst IT Bug 15326: [FOLLOW-UP] More fixes This patch removes the t/Pages.t file because it isn't required, and other unused methods. This patch is ready to test. The appropriate tests are in t/db_dependent/Pages.t Bug 15326: [FOLLOW-UP] adding and editing fixes Sorry, did not see the second half of your comment. This patch should fix the adding and editing issues in Comment 16. Bug 15326: [FOLLOW-UP] Fixing library field in form, opac publishing Fixes issues from Comment 19, please test Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '18

28 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76387|0 |1 is obsolete| | --- Comment #37 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 78232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78232&action=ed… Bug 15326: Add CMS feature INCOMPLETE - For evaluation purposes only! Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news entry
by bugzilla-daemon＠bugs.koha-community.org 28 Aug '18

28 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 --- Comment #76 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 78231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78231&action=ed… Bug 14272: (follow-up) Fixing layout issues and expiration date hint Misunderstood the first time. I've added the hint to the news form on staff side. I've fixed the layout on OPAC. The RSS feed shows on the main page, but is hidden if there is no news and if viewing one news item. -- You are receiving this mail because: You are watching all bug changes.

1 0