August 2018 - Koha-bugs - lists.koha-community.org

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '18

24 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 --- Comment #49 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 78138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78138&action=ed… Bug 15524: (QA follow-up) Respect ReservesControlBranch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '18

24 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 --- Comment #48 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 78137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78137&action=ed… Bug 15524: (QA follow-up) Pass max_holds at the right position in update When updating max_holds should be before the categorycode in the update query. Things that can be found by testing :) Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '18

24 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 --- Comment #47 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 78136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78136&action=ed… Bug 15524: (QA follow-up) Fix meaningless test The last test claims to allow a hold when branch=5 and patron=5, but look at the preceding statements: $rule_branch->max_holds(5); $rule_branch->update(); $rule_branch->max_holds(5); $rule_branch->insert(); The last insert will not be done, since the record is already present. A create should have triggered an error on the primary key. Obviously, we should use $rule_all. Test plan: Run the test again. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '18

24 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 --- Comment #46 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 78135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78135&action=ed… Bug 15524: (QA Followup) - Change language used Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '18

24 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71737|0 |1 is obsolete| | Attachment #71738|0 |1 is obsolete| | Attachment #71739|0 |1 is obsolete| | Attachment #71740|0 |1 is obsolete| | Attachment #71741|0 |1 is obsolete| | Attachment #77681|0 |1 is obsolete| | Attachment #77682|0 |1 is obsolete| | --- Comment #45 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 78134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78134&action=ed… Bug 15524: Set limit on maximum possible holds per patron by category It's possible to set a limit on the maximum number of holds for a particular branch/category/itemtype, but not on the total number of holds for a given patron (by branch/category). This new rule works in conjunction with the existing branch/borrower/item rules in that Koha will use the lower of the two limits. This new rule counts all holds of all types, which prevents bib-level holds from not being counted for the purpose of these limits. This makes the most sense and was also requested by the sponsor. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Go to the circ rules editor, note the new max holds rules by patron category in the "Checkout limit by patron category". ( Should we rename this section? ) 4) Create find a patron that is allowed to place a hold, count the number of holds that patron has. Lets make that number 'X'. 5) Set the new max holds rule to X for "All libraries" 6) Note the patron can no longer place another hold 7) Set the new max holds rule to X + 1 for the patron's home library 8) Note the patron can again place another hold 9) Set the new max holds rule to X for the patron's home library 10) Note the patron can no longer place another hold Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20248] New: Elasticsearch - Improvements to mappings UI and indexing script
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '18

24 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248 Bug ID: 20248 Summary: Elasticsearch - Improvements to mappings UI and indexing script Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: ere.maijala(a)helsinki.fi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 49

[Bug 21175] New: Handle locations and collections with no matching authorised value in patron checkouts table
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '18

24 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21175 Bug ID: 21175 Summary: Handle locations and collections with no matching authorised value in patron checkouts table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Currently the code for displaying locations and collection in the patron checkouts table doesn't handle the case when there is no authorised value in LOC or CCODE. > + my $collection; > + if ( $c->{collection} ) { > + my $av = Koha::AuthorisedValues->search({ category => 'CCODE', authorised_value => $c->{collection} }); > + $collection = $av->count ? $av->next->lib : ''; We could make this a little better by displaying the stored value when no match is found in the authorised value list. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 15408] Timestamp on funds not updated when you duplicate a budget
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '18

24 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15408 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #30 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Pushed to 18.05.x for 18.05.03 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15408] Timestamp on funds not updated when you duplicate a budget
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '18

24 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15408 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21234] New: Remove our .clearfix class in favor of Bootstrap's
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '18

24 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21234 Bug ID: 21234 Summary: Remove our .clearfix class in favor of Bootstrap's Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Bootstrap in the staff client has its own ".clearfix" class which appears to be conflicting with the one in staff-global.scss. Removing .clearfix from staff-global.scss fixes it. See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20740#c2. -- You are receiving this mail because: You are watching all bug changes.

1 10