August 2018 - Koha-bugs - lists.koha-community.org

[Bug 14391] Granular permissions for the administration module
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '18

24 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 --- Comment #8 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 78109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78109&action=ed… Bug 14391: (QA follow-up) Resolve POD warn on svc..systempreferences *** WARNING: No items in =over (at line 48) / =back list at line 54 in file svc/config/systempreferences *** WARNING: No items in =over (at line 73) / =back list at line 79 in file svc/config/systempreferences => If you use 'over', you should add 'item'-s. Test plan: Run perldoc svc/config/systempreferences Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14391] Granular permissions for the administration module
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '18

24 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 --- Comment #7 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #6) > QA Comment: > Looks good! Nice addition. Some minor comments which should take much time: > > manage_classifications No text on form? => typo CASE 'manage_classfications' > Missing letter ! > Spelling Manage column configuation / SRU server confiugration / search > enginge > > installer/data/mysql/atomicupdate/bug14391_granular_admin_permissions.sql > The atomic update queries could be further optimized. You add separate > inserts for each permission with subqueries for borrowers. Easy to read, but > more costly to run. > Do you have figures about how long it takes on a larger patron table ? > Why not something like: > INSERT INTO user_permissions (borrowernumber, module_bit, code) > SELECT borrowers.borrowernumber, permissions.module_bit, permissions.code > FROM borrowers > LEFT JOIN user_permissions USING (borrowernumber) > LEFT JOIN permissions ON module_bit =3 AND code NOT IN ( * list existing > permissions for admin * ) > WHERE user_permissions.code='parameters_remaining_permissions' > This replaces most separate inserts and uses joins instead of subqueries. > > admin/localization.pl, svc/localization > Need manage_itemtypes > Understand why you do it, but it seems not logical in the long run. Better > add a specific one. > > admin/printers.pl > parameters => '*' > Only case where we refer to *. Why not separate? much time => not much time :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14391] Granular permissions for the administration module
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '18

24 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #6 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment: Looks good! Nice addition. Some minor comments which should take much time: manage_classifications No text on form? => typo CASE 'manage_classfications' Missing letter ! Spelling Manage column configuation / SRU server confiugration / search enginge installer/data/mysql/atomicupdate/bug14391_granular_admin_permissions.sql The atomic update queries could be further optimized. You add separate inserts for each permission with subqueries for borrowers. Easy to read, but more costly to run. Do you have figures about how long it takes on a larger patron table ? Why not something like: INSERT INTO user_permissions (borrowernumber, module_bit, code) SELECT borrowers.borrowernumber, permissions.module_bit, permissions.code FROM borrowers LEFT JOIN user_permissions USING (borrowernumber) LEFT JOIN permissions ON module_bit =3 AND code NOT IN ( * list existing permissions for admin * ) WHERE user_permissions.code='parameters_remaining_permissions' This replaces most separate inserts and uses joins instead of subqueries. admin/localization.pl, svc/localization Need manage_itemtypes Understand why you do it, but it seems not logical in the long run. Better add a specific one. admin/printers.pl parameters => '*' Only case where we refer to *. Why not separate? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14391] Granular permissions for the administration module
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '18

24 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl Status|Signed Off |BLOCKED QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | --- Comment #5 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news entry
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '18

24 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77569|0 |1 is obsolete| | --- Comment #68 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 78104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78104&action=ed… Bug 14272: (follow-up) Fixing template error and layout To test, confirm that OpacMainUserBlock and Quote of the Day do not show if viewing a single news item, but do show otherwise. Confirm user dashboard shows where expected Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> UPDATE 24/Aug: Add expiration date text -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news entry
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '18

24 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 24 Aug '18

24 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |chris(a)bigballofwax.co.nz --- Comment #277 from Chris Cormack <chris(a)bigballofwax.co.nz> --- (In reply to Martin Renvoize from comment #276) > Rebased again. Sadly Applying: Bug 11897: Add Stock Rotation atomic update schema. Applying: Bug 11897: DO NOT PUSH: Add stock rotation schema files. Applying: Bug 11897: DBIX::Class::Ordered in Stockrotationstage. Applying: Bug 11897: Stockrotation error: sha1 information is lacking or useless (installer/data/mysql/sysprefs.sql). error: could not build fake ancestor Patch failed at 0001 Bug 11897: Stockrotation -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11682] serials.status is too dependent on magic numbers
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '18

23 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682 --- Comment #9 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Caroline Cyr La Rose from comment #8) > Are authorized values translatable now? I feel like we should be able to > customized the serial statuses like we do regular statuses. You can translate them, but they are not multi-lingual - you can not have them in English and German for example. And we don't have installers for a lot of different languages, so it's manual work to translate them often. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 13498] 'email' templates used for printing slips
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '18

23 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13498 Jessie Zairo <jzairo(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11682] serials.status is too dependent on magic numbers
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '18

23 Aug '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11682 Caroline Cyr La Rose <caroline.cyr-la-rose(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose(a)inlibro.com> --- Are authorized values translatable now? I feel like we should be able to customized the serial statuses like we do regular statuses. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0