September 2018 - Koha-bugs - lists.koha-community.org

[Bug 20922] New: Koha::Number::Price must not be used in updatedatabase.pl
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '18

24 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922 Bug ID: 20922 Summary: Koha::Number::Price must not be used in updatedatabase.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org >From the koha-devel list: http://lists.koha-community.org/pipermail/koha-devel/2018-June/044608.html 16.06.00.042 Upgrade to 16.06.00.041 done (Bug 14629 - Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher) DBD::mysql::st execute failed: Unknown column 'me.p_sep_by_space' in 'field list' [for Statement "SELECT `me`.`currency`, `me`.`symbol`, `me`.`isocode`, `me`.`timestamp`, `me`.`rate`, `me`.`active`, `me`.`archived`, `me`.`p_sep_by_space` FROM `currency` `me` WHERE ( `active` = ? )" with ParamValues: 0=1] at /usr/local/share/perl/5.24.1/DBIx/Class/Storage/DBI.pm line 1836. DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.p_sep_by_space' in 'field list' at /inlibro/git/koha-csf-prod-inlibro/Koha/Objects.pm line 209 Basically, the update code uses Koha::Number::Price, which in full modern object mode goes for its newly added *p_sep_by_space* _in the 18.05 code_. But the DB doesn't have it yet (it comes with 17.12.00.022). -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 21019] New: Borrower address not shown on reserve pop-up on returns.pl
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '18

24 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21019 Bug ID: 21019 Summary: Borrower address not shown on reserve pop-up on returns.pl Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Bug 17829 changed the variable for address from 'address' to 'boraddress' which is not used in the template -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 21025] New: Koha::Patron::Discharge is missing use C4::Letters
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '18

24 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21025 Bug ID: 21025 Summary: Koha::Patron::Discharge is missing use C4::Letters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: charles.farmer(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Tried to download a discharge slip from the OPAC, but received the following message: > An error occurs when generating the pdf file. Please contact the staff to resolve this problem. >From the logs: > [Fri Jun 29 15:34:45.758105 2018] [cgi:error] [pid 10573] [client 127.0.0.1:44946] AH01215: [Fri Jun 29 15:34:45 2018] opac-discharge.pl: Undefined subroutine &C4::Letters::GetPreparedLetter called at /meow/Koha/Patron/Discharge.pm line 113.: /meow/opac/opac-discharge.pl, referer: http://master/cgi-bin/koha/opac-discharge.pl Will submit patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 21029] New: "Suspend until" in modal in staff patron account is not translatable
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '18

24 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21029 Bug ID: 21029 Summary: "Suspend until" in modal in staff patron account is not translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr To test: - Place a hold on an item - Go to the patron account - Click on the Suspend button on the holds tab - View the modal, the label before the date field "Suspend until:" is not translatable. The label is part of the holds.js file. As .js files are never translatable it needs to be moved to template level. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 20953] New: Discharge can be requested several times on OPAC
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '18

24 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20953 Bug ID: 20953 Summary: Discharge can be requested several times on OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org On OPAC, a user can requested a discharge even if one is already pending. This generates several pending discharges in staff interface that can not be deleted. This is because request operation leads to page 'opac-discharge.pl?op=request' and user can refresh this page performing a new request. Perl code must check that operation is allowed. -- You are receiving this mail because: You are watching all bug changes.

1 21

[Bug 20927] New: moredetail.pl crash on nonexistent biblionumber
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '18

24 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20927 Bug ID: 20927 Summary: moredetail.pl crash on nonexistent biblionumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: pasi.kallinen(a)joensuu.fi QA Contact: testopia(a)bugs.koha-community.org moredetail.pl crashes when trying to view a nonexistent biblionumber. The case should be handled like it is done in detail.pl. -- You are receiving this mail because: You are watching all bug changes.

1 26

[Bug 21133] New: Missing use C4::Account statement in Koha/Patron.pm
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '18

24 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21133 Bug ID: 21133 Summary: Missing use C4::Account statement in Koha/Patron.pm Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 27

[Bug 21176] New: decreaseLoanHighHolds does not properly calculate date when TimeFormat set to 12 hour
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '18

24 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21176 Bug ID: 21176 Summary: decreaseLoanHighHolds does not properly calculate date when TimeFormat set to 12 hour Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com To recreate: 1 - Enable decreaseLoanHighHolds, set to 1 day and more than 0 holds 2 - Set TimeFormat to 12 hour 3 - Find or create a record with two items 4 - Place a hold on one of them 5 - Checkout the other to a different patron 6 - Note the warning message display correct time 7 - Confirm the checkout 8 - Note the item is due at 11:59AM -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 11

[Bug 21188] New: t/db_dependent/Circulation/issue.t is failing
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '18

24 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21188 Bug ID: 21188 Summary: t/db_dependent/Circulation/issue.t is failing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Stems from bug 20660 The issue seems to be that $return_date is a string and not a DateTime object - when we call _debar_user_on_return we are expecting a DateTime object -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 21289] New: Error when sending emails to partner libraries
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '18

24 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21289 Bug ID: 21289 Summary: Error when sending emails to partner libraries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com During the "Place request with partners" workflow, at the point of sending the request mail, an "Internal server error" is displayed and the following is logged: Can't call method "isa" on unblessed reference at /home/koha/kohaclone/ill/ill-requests.pl line 241. The error here is misleading. It is due to the 'catch' block being called without an instance of a Koha::Exceptions::Ill object being passed. The reason it is being called is that the handle_commit_maybe sub is being called inside it. The handle_commit_maybe sub redirects the client, the exits: 295 # Redirect to a view of the newly created request 296 print $cgi->redirect( 297 '/cgi-bin/koha/ill/ill-requests.pl?method=illview&illrequest_id='. 298 $request->id 299 ); 300 exit; This is correct, but because it is being called inside the try block, the "exit" causes the catch block to be called, despite the client being redirected. A patch for this should move the call to handle_commit_maybe outside of the try block, we will still only reach it if everything inside the try block succeeded. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13