September 2018 - Koha-bugs - lists.koha-community.org

[Bug 5458] length of items.ccode disagrees with authorised_values.authorised_value
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5458 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #18 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Works well, nice bit of tidy up Fridolin, thanks! Tidied up the signoff lines and passing qa. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5458] length of items.ccode disagrees with authorised_values.authorised_value
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5458 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79317|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 79332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79332&action=ed… Bug 5458: Update DBIx schema Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5458] length of items.ccode disagrees with authorised_values.authorised_value
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5458 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79316|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 79331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79331&action=ed… Bug 5458: increase ccode column to varchar 80 Koha allows you to define an authorised value having length 80, but then you can't use it. Here is why: The SQL field items.ccode is a varchar(10). The SQL field authorised_values.authorised_value is a varchar(80). Therefore the authorised value is truncated to length 10 in items.ccode and the mapping from authorised value to description string fails in Koha. This patch increases ccode column to varchar 80, like location. Test plan : 1) Dont apply patches 2) Check there is on item field a subfield with authorised value category CCODE 3) Check this subfield is linked with database column items.ccode 4) Create an authorised values in category CCODE with 'DOCUMENTATION' 5) Edit an item on ccode and choose 'DOCUMENTATION' 6) Save item 7) Look at items.ccode in database or export in MARCXML 8) The value is troncated to 'DOCUMENTAT' 9) Apply patches and update database with installer/data/mysql/atomicupdate/bug_5458.sql 10) Repeate step 5 to 7 11) The value is not truncated 'DOCUMENTATION' Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset(a)hotmail.com Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12365] Notes for rules
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 --- Comment #35 from Christopher Brannon <cbrannon(a)cdalibrary.org> --- I am catching up on bugs, and noticed that it was noted that this is actually modifying the rules table with a new column. I would like to reiterate, if it isn't too late, that it might be preferable to have a separate notes table. One that could be used for more than just this one table. I don't see it hindering performance as a notes table would not be accessed when the rules are used in circulation processes. If there is a reason it would be better to have the notes in the table, great. I am learning here, so would be interested in knowing if one method is better than another. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #13 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 78918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78918 Bug 15529 - Locking process_message_queue.pl cron whilst it is running Review of attachment 78918: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=155…) ----------------------------------------------------------------- ::: misc/cronjobs/process_message_queue.pl @@ +100,5 @@ > +); > + > +$email->attach( > +Type => 'Text', > + Data => 'process_message_queue.pl cron is already running', If another process is running, why not queue this as a message, rather than add another layer of emailing ugliness? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10060] Self Checkout module does not honour circ control
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10060 --- Comment #14 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- bug 16520 suggests it should work with Plack too (others might know more) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 10060] Self Checkout module does not honour circ control
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10060 --- Comment #13 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- You can have a virtualhost config for each for your branches in Apache with different settings for the selfcheck user. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #71 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Séverine Queune from comment #58) > I can't apply the patch on master branch 17.12.00.037 : Hola Séverine, the new patches apply on master. Thanks! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #70 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Lucie Gay from comment #57) > patch works well, but messages are not clear : > in staff user : "None of these items can normally be put on hold for this > patron" > opac : "Sorry, none of these items can be placed on hold." > patrons doesn't know that it's because there is a limit per day Hi Lucie, thanks for testing it and helping me improve it! I agree the OPAC 'could' give better information to the OPAC users when placing a hold is not possible. But that's already the case for existing constraints, and this bug is not about it. I would encourage you to file a new one, with a proposal to give end users more information! -- You are receiving this mail because: You are watching all bug changes.

1 0