September 2018 - Koha-bugs - lists.koha-community.org

[Bug 5458] length of items.ccode disagrees with authorised_values.authorised_value
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5458 Michal Denar <black23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23(a)gmail.com --- Comment #12 from Michal Denar <black23(a)gmail.com> --- Sorry, my devbox drive me crazy .... Patch tested but some mess added on sign. Mike -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5458] length of items.ccode disagrees with authorised_values.authorised_value
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5458 --- Comment #11 from Michal Denar <black23(a)gmail.com> --- Created attachment 79317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79317&action=ed… Bug 5458: Update DBIx schema Signed-off-by: Michal Denar <black23ěgmail.com> Signed-off-by: Your Full Name <your_email> https://bugs.koha-community.org/show_bug.cgi?id=17282 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5458] length of items.ccode disagrees with authorised_values.authorised_value
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5458 Michal Denar <black23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78553|0 |1 is obsolete| | Attachment #78554|0 |1 is obsolete| | --- Comment #10 from Michal Denar <black23(a)gmail.com> --- Created attachment 79316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79316&action=ed… Bug 5458: increase ccode column to varchar 80 Koha allows you to define an authorised value having length 80, but then you can't use it. Here is why: The SQL field items.ccode is a varchar(10). The SQL field authorised_values.authorised_value is a varchar(80). Therefore the authorised value is truncated to length 10 in items.ccode and the mapping from authorised value to description string fails in Koha. This patch increases ccode column to varchar 80, like location. Test plan : 1) Dont apply patches 2) Check there is on item field a subfield with authorised value category CCODE 3) Check this subfield is linked with database column items.ccode 4) Create an authorised values in category CCODE with 'DOCUMENTATION' 5) Edit an item on ccode and choose 'DOCUMENTATION' 6) Save item 7) Look at items.ccode in database or export in MARCXML 8) The value is troncated to 'DOCUMENTAT' 9) Apply patches and update database with installer/data/mysql/atomicupdate/bug_5458.sql 10) Repeate step 5 to 7 11) The value is not truncated 'DOCUMENTATION' Signed-off-by: Michal Denar <black23ěgmail.com> https://bugs.koha-community.org/show_bug.cgi?id=17282 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5458] length of items.ccode disagrees with authorised_values.authorised_value
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5458 Michal Denar <black23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 18635] New: Koha::Patron->guarantees() should return results alphabetically
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18635 Bug ID: 18635 Summary: Koha::Patron->guarantees() should return results alphabetically Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Currently there is no sort here so patrons are returned in db order (unordered) We should return them alphabetically for display and other purposes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 36

[Bug 10382] collection not returning to null when removed from course reserves
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 --- Comment #56 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- (In reply to Marcel de Rooy from comment #55) > (In reply to Alex Arnaud from comment #54) > > If you put this at the line #113, this is just after the ccode test. So why > > would it change anything ? > It should be after that test. But its purpose is to check what happens later > when you revert the course reserve and put back the original value.. > > > Also, $item->ccode(undef)->store; and $item->ccode('')->store; is different. > > Undef is not converted to null: > Yes it is. Your example below is the proof ! NULL vs empty string > > > $item->ccode(undef)->store; > > MariaDB [koha]> select ccode from items where itemnumber = xxxx; > > +-------+ > > | ccode | > > +-------+ > > | NULL | > > +-------+ > > 1 row in set (0.00 sec) > > > > $item->ccode('')->store; > > MariaDB [koha]> select ccode from items where itemnumber = xxxx; > > +-------+ > > | ccode | > > +-------+ > > | | > > +-------+ > > 1 row in set (0.00 sec) > > > > But i think it is transparent for us when using dbic methods. Returned > > values are the same. > They are not the same. Right. And this it's managed afaik. Change '' by undef at line #109: You'll have do to do the same thing at #line #112 to make the test pass and vice versa. But i don't understand why puting your code at line #113 should be a problem if the test still pass. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5501] Improve the 'do not notify' option
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 Marjorie Barry-Vila <marjorie.barry-vila(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21199] Patron's attributes are displayed on GetPatronInfo's ILSDI output regardless opac_display
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21199 --- Comment #9 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- Pushed to 17.05.x for 17.05.14 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21054] New: Extra closing body tag in sco-main.tt prevents slip printing
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21054 Bug ID: 21054 Summary: Extra closing body tag in sco-main.tt prevents slip printing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Self checkout Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Bug 16732 added an extra closing body tag to sco-main.tt Bug 18387 notes that page errors kick the SCO user out. The extra body tag creates an html error and prevents receipt printing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 10

[Bug 20951] New: Koha::Patron::Discharge is missing use Koha::Patron::Debarments
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20951 Bug ID: 20951 Summary: Koha::Patron::Discharge is missing use Koha::Patron::Debarments Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Koha::Patron::Discharge is missing use Koha::Patron::Debarments used in discharge() method. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17