September 2018 - Koha-bugs - lists.koha-community.org

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #69 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to M. Tompsett from comment #54) > Comment on attachment 71314 [details] [review] > Bug 15486: DB structure change > > Review of attachment 71314 [details] [review]: > ----------------------------------------------------------------- > > ::: installer/data/mysql/atomicupdate/bug_15486_max_holds_per_day.perl > @@ +1,2 @@ > > +$DBversion = "XXX"; > > +if ( CheckVersion($DBversion) ) { > > no reserve date?! > > ::: installer/data/mysql/kohastructure.sql > @@ +1883,4 @@ > > CREATE TABLE `reserves` ( -- information related to holds/reserves in Koha > > `reserve_id` int(11) NOT NULL auto_increment, -- primary key > > `borrowernumber` int(11) NOT NULL default 0, -- foreign key from the borrowers table defining which patron this hold is for > > + `reservedate` date default NULL, -- the date the hold was placed > > reservedate here... I just fixed a typo on the field description. No need to change the atomic update file! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #68 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to M. Tompsett from comment #53) > Comment on attachment 71317 [details] [review] > Bug 15486: Extend CanItemBeReserved so it handles daily holds limits > > Review of attachment 71317 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Reserves.pm > @@ +300,4 @@ > > my $ruleitemtype; # itemtype of the matching issuing rule > > my $allowedreserves = 0; # Total number of holds allowed across all records > > my $holds_per_record = 1; # Total number of holds allowed for this one given record > > + my $holds_per_day = 0; # Total number of holds allowed per day for the given patron > > Shouldn't this default to undef? (i.e. unlimited) Done! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #67 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Katrin Fischer from comment #26) > Can you take another look at my last comment and meaning of 0 please? > > I retested and after installing the patch the daily column is empty. Later > it's not possible to safe it empty, as empty jumps to 0. It doesn't feel > quite right. Done! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #66 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- I have: - Rebased against master - Adjusted to the new return values for C4::Reserves::CanItemBeReserved - Fixed the tests - Deal with Katrin's highlighted issue with 0 vs. unlimited. - Fixed Mark's remark on default value -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #65 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 79324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79324&action=ed… Bug 15486: (follow-up) Default to unlimited While it doesn't have a practical effect (the variable is reset several lines below) I agree this should be explicitly set to its default. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #64 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 79323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79323&action=ed… Bug 15486: DBIC update Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #63 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 79322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79322&action=ed… Bug 15486: Make circ rules UI handle holds_per_day This patch makes the staff UI correctly handle the holds_per_day configuration. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #62 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 79321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79321&action=ed… Bug 15486: Modify request.tt to handle the new error string This patch makes reserve/request.pl display a convenient error description when a hold cannot be placed due to the new daily limit configuration. To test: - Apply this patchset - Upgrade - Configure your circulation rules so there's a daily limit for holds - Place holds so the patron reaches the maximum - Place one more hold - Notice the hold cannot be placed and a convenient error message is displayed. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #61 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 79320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79320&action=ed… Bug 15486: Extend CanItemBeReserved so it handles daily holds limits This patch implements the required changes in C4::Reserves::CanItemBeReserved so it implements a daily limit on holds. It returns the 'tooManyReservesToday' string if the policy doesn't allow placing the hold. It returns 'OK' (current behaviour) otherwise. To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Holds.t => FAIL: Tests fail because the error condition is not making CanItemBeReserved return the desired error code. - Apply this patch - Run: k$ prove t/db_dependent/Holds.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '18

24 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #60 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 79319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79319&action=ed… Bug 15486: Unit tests This patch introduces unit tests for the new circulation rules option that allows setting a max holds per day limit. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Holds.t => FAIL: CanItemBeReserved doesn't check the amount of holds per day and the introduced error code is not returned. OK is returned instead. -- You are receiving this mail because: You are watching all bug changes.

1 0