September 2018 - Koha-bugs - lists.koha-community.org

[Bug 12365] Notes for rules
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76637|0 |1 is obsolete| | --- Comment #27 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Created attachment 78685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78685&action=ed… Bug 12365: Notes for rules This patch adds a note column to the circ and fine rules to act as a description line for the rule. To test: 1) Apply patch, update database (may have to also update schema) 2) Go to Admin -> Circ and fine rules 3) Scroll to the right, notice new Note column 4) Confirm it works to create a brand new rule with a Note 5) Confirm it works to modify an existing rule with a Note Sponsored-by: Catalyst IT Lee Jamison <ldjamison(a)marywood.edu> rescued this patch. It is a clean re-build of attachments 61865 and 63902 to fix the merge conflict introduced during application of both attachments. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: macon lauren KohaCon17 <caballeromaricon(a)gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12365] Notes for rules
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Lisette Scheer <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #26 from Lisette Scheer <lisetteslatah(a)gmail.com> --- I got the following error when applying the notes for rules patch. CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt Auto-merging installer/data/mysql/kohastructure.sql Auto-merging admin/smart-rules.pl Failed to merge in the changes. Patch failed at 0001 Bug 12365: Notes for rules The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-12365-Notes-for-rules-osNzXn.patch Lisette -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14670] add 'cite' option to detail page in OPAC
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Carl <ctodd(a)hcc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ctodd(a)hcc.edu -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #180 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Christopher Davis from comment #179) > David, > > I am impressed with your work on this- so much done in so little time. I > think that enabling Koha to harvest metadata is a grand idea, so I have been > following this bug. I heard that Koha's new indexer, Elastic Search, can > index non-MARC metadata- is this true? If this is true, then I hope that you > do not mind me asking you a question: this bug patch would have Koha's > OAI-PMH harvester ingest only metadata which has been crosswalked to > MARCXML; however, why stick with only MARCXML when Elastic Search can index > the incoming metadata in its native schema (Dublin Core, TEI, EAD, etc.)? > Please pardon my ignorance, but am I missing something? > > Thank you, > > Christopher Davis Hi Christopher, It feels like a very long time to me, but thank you very much! Neither ElasticSearch nor Zebra require MARC themselves per se, so either of them *could* index non-MARC metadata. However, Koha itself is a MARC-driven system, so the limitation you've observed with the OAI-PMH harvester is because of Koha's internals (and how we've chosen to index Koha's metadata). Indexing is certainly one part of the issue. I'm not 100% familiar with the implementation of ElasticSearch, but I think we're using MARC with that as well. I think the solution would be to have a generic schema that we use for indexing/searching so that we could map any metadata format to Koha's generic index schema. Then we'd have mapping from any metadata format to a Koha generic display format. The other issue would be how Koha handles "records" for other purposes. Deleting bibs, modifying bibs, acquisitions, subscriptions, etc. But really the first step is just being able to store a non-MARC bib, index it, and display it. Basically... lots of work needs to be done and someone just needs to start it. I think the first step will be creating non-MARC metadata bibliographic records which store non-MARC metadatain the biblio_metadata table. And the first step to doing thing would be changing the "marcflavour" column in that table to "schema". There's a lot of work to do there, but I think it's very important work! And it's work which would be great to do, since the Swedish Union Catalogue is using RDF. It would be great if we could just download the Swedish Union Catalogue metadata in its native format and work with that for indexing and display. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20735] New: Multiple LDAP servers
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20735 Bug ID: 20735 Summary: Multiple LDAP servers Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: terencelau(a)cic.hk QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org Koha does not support multiple LDAP servers. Can it be one of the development option? For example, student accounts were stored in LDAP A, teaching staff accounts were stored LDAP B. Students and teaching staff have different access rights / privileges. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Carl <junk(a)liriodendron.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |junk(a)liriodendron.net -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #179 from Christopher Davis <tubaclarinet(a)protonmail.com> --- David, I am impressed with your work on this- so much done in so little time. I think that enabling Koha to harvest metadata is a grand idea, so I have been following this bug. I heard that Koha's new indexer, Elastic Search, can index non-MARC metadata- is this true? If this is true, then I hope that you do not mind me asking you a question: this bug patch would have Koha's OAI-PMH harvester ingest only metadata which has been crosswalked to MARCXML; however, why stick with only MARCXML when Elastic Search can index the incoming metadata in its native schema (Dublin Core, TEI, EAD, etc.)? Please pardon my ignorance, but am I missing something? Thank you, Christopher Davis -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #249 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to Jonathan Druart from comment #245) > 1. aqbasketgroups.closedate is set to NOW, maybe better to use > basket.closedate (the latest)? Fixed > 2. ->bookseller should be ->vendor (not blocker as we already have both in > Koha::*...) Fixed > 3. a. I would not "cache" ->baskets, we already deal with the context in > Koha::Objects->search I don't know what is the context you are talking about, but I removed the "caching" > b. ->baskets_count - no need to have it, it should be replaced with > baskets->count > => Maybe you want to keep them for performance purpose, but is it really a > performance improvement? It's used only in templates, because TT seems to force the list context even with a directive like this: [% basketgroup.baskets.count %] It tries to call count on the first item of @{ $basketgroup->baskets } I'd happily remove this sub if you have a better idea. > 5. basketgroup.tt has a [% IF booksellerid %], it should not be useful now. Fixed > We may want to display a friendly message if called without a [valid] id Is returning a 404 error friendly ? Because it's probably what should be done if the id is invalid. > 6. basketgroups.tt should have JS at the bottom Fixed > 7. Some links still point to basketgroup.pl?booksellerid=X without the > basketgroupid, they should be replaced right? > i.e. code related to 'sub displaybasketgroups' in basketgroup.pl should be > removed (?) Fixed > 8. Are you sure you need the changes done to C4::Acquisition? No. They're not needed anymore. I removed them. > 9. acqui/basketgroup.pl > + use List::MoreUtils qw/uniq/; > => Not needed Fixed > 10. "kohaDataTable": We already have KohaTable. You are adding a 3rd way to > init a table. We already have 3 ways to initialize DT: 1. The "legacy API" way: $("#table_id").dataTable($.extend(true, {}, dataTablesDefaults, { ... }); 2. The "legacy API + column_settings" way: KohaTable('table_id', ...); 3. The "1.10+ API" way $('#table_id').DataTable(...) kohaDataTable is just a wrapper around the 3rd that provides the same defaults than the 1st and 2nd methods. I don't see how this is bad. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #248 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 78664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78664&action=ed… Bug 11708: Fix QA issues - Change how closedate is set in database update - Reword bookseller to vendor in Koha::Acquisition::Basketgroup - Do not "cache" baskets in Koha::Acquisition::Basketgroup - Remove useless IF in basketgroup.tt - Move JS to bottom in basketgroups.tt - Fix some links to basketgroup.pl - Remove useless use in acqui/basketgroup.pl - Remove useless sub displaybasketgroups in acqui/basketgroup.pl - Remove useless code in C4::Acquisition -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75909|0 |1 is obsolete| | --- Comment #247 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 78663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78663&action=ed… Bug 11708: New page for basket groups This patch moves the code responsible for displaying a list of basket groups into its own Perl script (acqui/basketgroups.pl), making the code in basketgroup.pl and basketgroup.tt a little bit easier to read. basketgroups.pl displays all basket groups in a single table (as bug 13371 for vendors) where rows are grouped by bookseller. This patch also adds 3 columns: - No. of ordered titles - No. of received titles - Date closed It also adds a wrapper around the new DataTable() constructor to be able to use it with the same defaults than the previous dataTable() constructor Test plan: 0. Create a bunch of booksellers and basketgroups 1. Go back to acquisitions home page and click on "Basket groups" link on the left 2. Play with the table (sort, filter) and try every possible actions (Edit, Close and export as PDF, View, Reopen, Export as CSV) 3. Go to a specific vendor page and click on "Basket groups" tab 4. Check that only the vendor's basket groups are displayed Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0