September 2018 - Koha-bugs - lists.koha-community.org

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #138 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Rebased the patchset (and fixed a sha1 missing error), now moving onto continuing QA. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78017|0 |1 is obsolete| | --- Comment #137 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 78638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78638&action=ed… Bug 12310: (QA follow-up) Add prefs to test too Test plan: Run t/db_dependent/UsageStats.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77973|0 |1 is obsolete| | --- Comment #136 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 78637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78637&action=ed… Bug 12310: (follow-up) Add relevant sysprefs to HEA DecimalSeparators: the new one CurrencyFormat: related because it's the display format -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77972|0 |1 is obsolete| | --- Comment #135 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 78636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78636&action=ed… Bug 12310: (QA follow-up) Simplify DecimalSeparators syspref description Thanks Marcel for the new version :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77971|0 |1 is obsolete| | --- Comment #134 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 78635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78635&action=ed… Bug 12310: (QA follow-up) Fix typo: unformating => unformatting -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75957|0 |1 is obsolete| | --- Comment #133 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 78634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78634&action=ed… Bug 12310: (follow-up) Fix forgotten writeoff amount field This is a follow up for this forgotten field. See main patch more details. == Test plan == 1. Use a translation of the staff interface if possible. 2. Go to a patrons's page → fines → pay fines 3. Click on "Write off" This assumes an existing debt. Which should exists if you just tested the previous patches. 4. If you enter "1,50", the writeoff amount saved is only 1. This is the bug. 5. Apply this patch 6. run ~/src/installer/data/mysql/updatedatabase.pl 7. Refresh the page 8. Retry the write off. Apply the annex 1 to the "Writeoff amount" field 9. It works! \o/ === Annex 1: Subpart for each concerned page === 1. Set DecimalSeparators syspref to ",." 2. Input "12,34" 3. Press the "Tab/Tabulation" key. It will unfocus the field and trigger the conversion. Validating the form does the same but it's a trick to test more quickly by not switching to another page. 4. The value should have been converted to 12.34 5. Do the same with "12,34 EUR" and ensure that it's converted to "12,34" Same with "EUR 12.34" -> "12.34" 6. "EUR 12.34€thanks lyonthree" -> "12.34" 7. "123 456,7" -> "123456.7" 8.. "2" -> "2" 9.. "2,0" -> "2.0" 10. "-1'345.95" -> "-1345.95" 11. ",1234" -> ".1234" 12. Set DecimalSeparators syspref to "," 13. Reload the page with the form 14. "1.000" -> "1000" 15. "1.000.000,10" -> "1000000.10" 16. Set DecimalSeparators syspref to "." 17. Reload the page with the form 18. "1,000" -> "1000" 19. "1,000,000.10" -> "1000000.10" 20. Validate the form and check that the final value with the dot was 21 well handled. 22. Think about Koalas and smile. 🐨🐨🐨 Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75956|0 |1 is obsolete| | --- Comment #132 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 78633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78633&action=ed… Bug 12310: (QA follow-up) Prevent updatedatabase noise Added IGNORE into the SQL statement. TEST PLAN --------- run the atomic update multiple times. -- noise apply patch run the atomic update multiple times. -- no noise Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75955|0 |1 is obsolete| | --- Comment #131 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 78632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78632&action=ed… Bug 12310: (follow-up) Keep the example text in fines This puts the example text back in with the correct decimal separator. The example uses the first char of the syspref. TEST PLAN --------- 1) set the I18N/L10N DecimalSeparators syspref to "," 2) go to a patron's fines tab. 3) open Create manual invoice and Create manual credit tabs 4) check both tabs -- Example: 5.00 appears 5) apply this patch 6) reload the page and check both create tabs. -- Example: 5,12 appears 7) set the I18N/L10N DecimalSeparators syspref to ".," 8) go back and check both tabs. -- Example: 5.12 appears (only the first separator is picked) 9) optionnal: run koha qa test tools Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75954|0 |1 is obsolete| | --- Comment #130 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 78631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78631&action=ed… Bug 12310: Decimal separator issues: fixes in fines The main goal is to prevent - x100 or /100 of the amounts - decimal part truncation Fixes Bug 19521 - Partial fine payment is not working with comma decimal separator Bonuses: - Gets rid of the spaces, currency symbols, names (EUR) There is nothing specific about currency symbols is this patch. It just removes everything that is not a digit a minus or a separator. It handles: - by default comma and dot as decimal separators on the same instance - dot or comma as thousands separators if choose to use only one of them as decimal separator. See DecimalSeparators syspref. - minuses, doesn't remove them - non-decimal values: it doesn't touch them == Test plan == 1. Use a translation of the staff interface if possible. 2. When you pay an existing fine (more details in the next steps if needed). Check that you can't enter any string except like "XX.XX" (examples in Annex 1) without having an issue after validation. (x100, truncation, etc) 3. Apply this patch 4. run ~/src/installer/data/mysql/updatedatabase.pl 5. In the manual invoice (cgi-bin/koha/members/maninvoice.pl) 6. Apply the annex 1 to the "Amount" field 7. When paying a fine (cgi-bin/koha/members/paycollect.pl) 8. Click on "Pay amount" to go to the page to pay all fines 9. Apply the annex 1 to the "Collect from patron" field 10. Click on "Pay" to go to the page to pay fine 11. Apply the annex 1 to the "Collect from patron" field 12. Go to "Create manual credit" (staff://cgi-bin/koha/members/mancredit.pl) 13. Apply the annex 1 to the "Amount" field 14. If you have ideas of stuff to try to find *regressions* from the previous versions, then try. You might spare librarian tears by finding something before it's released. (and prevent me from having bounty on my head) 15. Express your happiness. This is important, otherwise the sign off spell won't work! The details of expressing your happiness depend on your culture and habits. === Annex 1: Subpart for each concerned page === 1. Set DecimalSeparators syspref to ",." 2. Input "12,34" 3. Press the "Tab/Tabulation" key. It will unfocus the field and trigger the conversion. Validating the form does the same but it's a trick to test more quickly by not switching to another page. 4. The value should have been converted to 12.34 5. What follows is just a list of examples. They don't have to be tried on each field. 6. Do the same with "12,34 EUR" and ensure that it's converted to "12,34" 7. Same with "EUR 12.34" -> "12.34" 8. "EUR 12.34€hi lyonthree" -> "12.34" 9. "123 456,7" -> "123456.7" 10. "2" -> "2" 11. "2,0" -> "2.0" 12. "-1'345.95" -> "-1345.95" 13. ",1234" -> ".1234" 14. Set DecimalSeparators syspref to "," 15. Reload the page with the form 16. "1.000" -> "1000" 17. "1.000.000,10" -> "1000000.10" 18. Set DecimalSeparators syspref to "." 19. Reload the page with the form 20. "1,000" -> "1000" 21. "1,000,000.10" -> "1000000.10" 22. Validate the form and check that the final value with the dot was well handled. 23. Think about Koalas and smile. 🐨🐨🐨 Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13392] New statistics wizard for suggestions
by bugzilla-daemon＠bugs.koha-community.org 13 Sep '18

13 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #78 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to Nick Clemens from comment #69) > Hi Julian, > > Minor conflict in tests (wrong number) > Missing comma in kohastructure.sql between constraints Tests should pass now, and the syntax error in kohastructure.sql is fixed > > I tried adding a suggestion, ordering it, but never saw the suggestion > status update to 'ORDERED' - nothing relevant in error log It worked for me. Have you run updatedatabase + update_dbix_class_files ? > > Reporting seems to work, however, if I don't select both a row and column > the page simply reloads and clears data, maybe a warning could be added? The last patch fixes this. I did not add a warning but this scenario should not happen anymore > > Can you provide a clear test plan and verify things are working for you? The only test plan I can come up with is: 1. Create a lot of suggestions from different libraries and with different status 2. Try all the buttons on the form and see what happens :) Request directly mysql to compare results if needed -- You are receiving this mail because: You are watching all bug changes.

1 0