September 2018 - Koha-bugs - lists.koha-community.org

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75908|0 |1 is obsolete| | --- Comment #246 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 78662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78662&action=ed… Bug 11708: Change aqbasketgroups.closed to closeddate Signed-off-by: juliette levast <juliette.levast(a)iepg.fr> Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #142 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- > And also we might prefer focusing on getting rid of x100 or /100 of the amounts + decimal part truncation. Additional note: these are regressions from the 16.11 or the 16.05 The current state is less functional than few versions ago. (there were still cases before where this issue happened, that why the aim isn't just to get back to the previous behavior) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #141 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- (In reply to Martin Renvoize from comment #139) > I'm afraid I agree with marcelr, I don't really like that one can enter one > thing and when it's displayed later see a different thing due to the > distinct preferences. Unfortunately the only simple solution might be to keep them separated (but one should configure them coherently!) because it's a requirement to be able to use multiple separators in the same instance. During the last hackfest (march in Marseille) after talking to enough devs and librarians, I couldn't not put that in the requirements :( > I also can't help but feel like there's a better way out there, input > masking or something? That's not compatible with pasting values [1] And also we might prefer focusing on getting rid of x100 or /100 of the amounts + decimal part truncation. It might not be possible in a reasonable time put up a great UX + handle most cases at the same time. That might be better to refine out decimal number handling in various steps. Considering how complicated the problem is and that a perfect solution will take years to get enough resources and get into master. [1] The cases could be in acquisition when copying from another software, an invoice email, a PDF. Or maybe from somewhere else in Koha? I'm not sure about that use case. > Finally, there's a lot of test cases here, if we did push this I'd really > like to see some tests added to ensure we don't end up with a regression. You having a Selenium test that go to one field and try a part of the cases of the test plan? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #140 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- (In reply to Marcel de Rooy from comment #121) > The relation between CurrencyFormat and DecimalSeparators still worries me. The only simple solution might be to keep them separated (but one should configure them coherently!) because it's a requirement to be able to use multiple separators in the same instance. During the last hackfest (march in Marseille) after talking to enough devs and librarians, I couldn't not put that in the requirements :( > On paycollect CurrencyFormat formats the suggested price (using the > separators in CurrencyFormat) No, the example takes the first char of DecimalSeparators. > that I will edit (using the other pref). > Suppose that DecimalSeparators is not exactly identical, I will have issues > here. So fortunately this is not the case :) (above answer) > Should decimal separator not just be the one identified as such in > CurrencyFormat? Unfortunately no :( (first answer) > Hypothetically, I could use # as decimal separator (it works), but on the > form the prices are shown according to currency format. Which forms? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74001|0 |1 is obsolete| | --- Comment #168 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 78657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78657&action=ed… Bug 14385: Squash of a lot of patches rebased - Added missing GetHiddenItems parameter change case Without this prove t had a failure. - Always use mocks, not set_preference - Tweaks so t/db_dependent/00-strict.t passes There was a typo botcat vs borcat and borrowernumber was never defined. Grabbing from userenv, like other code does. - Tweak t/db_dependent/Items.t to fully test changes This will test all the if structures fully in GetHiddenItemnumbers. prove t/db_dependent/Items.t - Tweak borrower category code $borrower->{categorycode} on a Koha::Patron is not the same as $borrower->categorycode. Fixed error. - Search was returning URLS for wrong interface There was one search context place wrong. Changed it to $is_opac as the logic for setting $is_opac was modified correctly. - Corrected issues with category code. When a user isn't logged in, $borrower is undef and causes error when determining category code. Added conditional check. - Properly trigger all changes in C4/Search.pm - Fix QA Test tool failures C4/Search.pm had some tabs. - Add some commenting to make sense of logic - Refactor EmbedItemsInMarcBiblio parameters to hashref - Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call. prove t/db_dependent/Items.t - Add missing test to trigger Koha/BiblioUtils/Iterator change - Add borrower category overrides These files generally add borcat parameter to GetMarcBiblio. Others might include correction of filtering of items (opac-basket), or a comment as to why no changes were done (opac-search). In the case of opac-search, correcting the first FIXME will likely correct the OpacHiddenItems issues on tags. As such, that is beyond this bugs scope. Some code had loop optimizations and fixes made, like a 'next unless $record' when the biblio shouldn't even be in the list. - Modify opac-ISBDdetail and opac-MARCdetail Both files had similar logic. They were rearranged and optimized, so that both files would have practically identical initial blocks of code. Optimizations were possible, because GetMarcBiblio returns a filtered record, so that there is no double call (once in the opac-### file and once in GetMarcBiblio) to GetHiddenItemnumbers. - Fix hiding in opac-tags opac/opac-tags.pl was not properly hiding. There is currently one known bug associated with tags left. If you have two biblios tagged by different people with the same tag, the opac-search will show the one you tagged that is supposed to be hidden, because tag searches work differently than regular searches. This is beyond the scope of this bug. See the FIXME's in opac/opac-search.pl - Trigger the C4::ILSDI::Services changes prove t/db_dependent/ILSDI_Services.t - Added missing 'my' - Test C4/Labels/Label.pm changes - Improve C4::Record::marcrecord2csv test cases - Corrected opac-details searchResult call - Fix breaking issues constraint in ITerator test - Fix ILSDI_Services test when clubs with branch exist - Rebased again! The test plan is in comment #112 last I checked. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72447|0 |1 is obsolete| | --- Comment #167 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 78656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78656&action=ed… Bug 14385: Followup: changes to sysprefs.sql and atomicupdate Run updatedatabase.pl when testing Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Aleisha Amohia <aleishaamohia(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72446|0 |1 is obsolete| | --- Comment #166 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 78655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78655&action=ed… Bug 14385 Followup: C4::Borrowers not found GetMember is in C4::Members, not C4::Borrowers Signed-off-by: Claire Gravely <c.gravely(a)arts.ac.uk> Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Aleisha Amohia <aleishaamohia(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72445|0 |1 is obsolete| | --- Comment #165 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 78654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78654&action=ed… Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower categories Edit: Fixing merge conflicts in - t/db_dependent/Items.t - t/db_dependent/Search.t - C4/Search.pm Changes the API for calling GetHiddenItems and all the places in the code that call it. This is to allow borrower categories to be passed in. Adds an OpacHiddenItemsExceptions syspref to allow certain borrower categories to be able to see items, even if they are marked hidden by OpacHiddenItems To test: 1) Make two borrowers, one in a category that should see everything (ie Adult), and another in a category that should only see certain things (ie Adult - exceptions) 2) Add the borrower that can see everything (the Adult) to OpacHiddenItemsExceptions 3) To the OpacHiddenItems syspref, add an item type (ensure that you have some records that fall under this type in your library). 4) Log in as the borrower that should only see certain things (Adult - exception) 5) Do a search, filtered to show records which are the item type that you specified in the OpacHiddenItems syspref. No records should show for this borrower as this item type is hidden to them. 6) Log in as the borrower that should see everything (Adult) 7) Do the same search. There should be results from this search, as this borrower category has been specified as an exception to the hidden items Signed-off-by: Claire Gravely <c.gravely(a)arts.ac.uk> Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Aleisha Amohia <aleishaamohia(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #93 from David Gustafsson <glasklas(a)gmail.com> --- Rebased against master. Patches should now apply. Have not tested that still works though. I will report back once have had the time to test, or if someone else does before me. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 14 Sep '18

14 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76210|0 |1 is obsolete| | --- Comment #92 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 78653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78653&action=ed… Bug 14957 - Remove exports of removed subroutines Remove exports of subroutines previously removed -- You are receiving this mail because: You are watching all bug changes.

1 0