January 2019 - Koha-bugs - lists.koha-community.org

[Bug 7614] Branch transfer limit and holds
by bugzilla-daemon＠bugs.koha-community.org 22 Jan '19

22 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 --- Comment #41 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 84309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84309&action=ed… Bug 7614 [QA Follow-up]: Fix POD merge missed in rebase -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7614] Branch transfer limit and holds
by bugzilla-daemon＠bugs.koha-community.org 22 Jan '19

22 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 --- Comment #40 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 84308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84308&action=ed… Bug 7614: Don't allow un-usable pickup locations in the opac pickup locations pulldown Also fully qualifies some subroutine calls that fail for reasons unkown. Signed-off-by: Bob Bennhoff <bbennhoff(a)clicweb.org> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7614] Branch transfer limit and holds
by bugzilla-daemon＠bugs.koha-community.org 22 Jan '19

22 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 --- Comment #39 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 84307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84307&action=ed… Bug 7614: (follow-up) If patron's home library is not a pickup library, let them choose another one This patch fixes an issue where patron is not allowed to place a hold in OPAC while their home library is not a pickup library. Instead, they should be presented with a list of other available pickup locations. Signed-off-by: Bob Bennhoff <bbennhoff(a)clicweb.org> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7614] Branch transfer limit and holds
by bugzilla-daemon＠bugs.koha-community.org 22 Jan '19

22 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 --- Comment #38 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 84306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84306&action=ed… Bug 7614: Fix my variable earlier declaration bug. Signed-off-by: Bob Bennhoff <bbennhoff(a)clicweb.org> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7614] Branch transfer limit and holds
by bugzilla-daemon＠bugs.koha-community.org 22 Jan '19

22 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 --- Comment #37 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 84305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84305&action=ed… Bug 7614: Build a list of pickup locations in OPAC considering transfer limits This patch enables the checks for transfer limits for given biblionumber in OPAC when patron proceeds to place a hold. In case none of the items of that biblio can be transferred to a library, that library will not be included in the list of pickup locations. To test: 1. Make sure you meet the following requirements: 1.1: You are able to make holds in OPAC 1.2: System preference UseBranchTransferLimits set to "Enforce" 1.3: System preference BranchTransferLimitsType set to "item type" (for the sake of simplicity of this test plan, but you may also set it to "collection code" and deal with ccodes instead) 1.4: System preference item-level_itypes set to "specific item" 1.5: You have the default libraries and item types, otherwise replace the branchcodes and itemtypes in this test plan with your own 2. Make sure 'Fairfield' in cgi-bin/koha/admin/branches.pl has not disabled its ability to act as a "Pickup location" 3. Have a biblio with exactly one item of item-level itemtype 'BK' 4. Set item holdingbranch as 'CPL' 5. Go to cgi-bin/koha/admin/branch_transfer_limits.pl (keep this page open in a second tab for faster testing) 6. Select library 'Centerville' 7. Uncheck the checkbox 'FFL - Fairfield' and click Save 8. Go to OPAC and find your biblio, and start placing a hold on it 9. Click at the list of "Pick up location"s. 10. Observe that it is missing 'Fairfield' 11. Go back to cgi-bin/koha/admin/branch_transfer_limits.pl 12. Repeat step 6 and this time, check the checkbox 'FFL - Fairfield' 13. Refresh the page you arrived at step 8 14. Observe that it now includes 'Fairfield' Signed-off-by: Bob Bennhoff <bbennhoff(a)clicweb.org> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7614] Branch transfer limit and holds
by bugzilla-daemon＠bugs.koha-community.org 22 Jan '19

22 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 --- Comment #36 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 84304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84304&action=ed… Bug 7614: Consider transfer limits in Koha::Template::Plugin::Branches Consider transfer limits in Koha::Template::Plugin::Branches->pickup_locations. This patch modified the mentioned method to consider branch transfer limits and does not include any library in the returned list of libraries in case a branch transfer limit applies for a given book or item. To be tested in following patches. Signed-off-by: Bob Bennhoff <bbennhoff(a)clicweb.org> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7614] Branch transfer limit and holds
by bugzilla-daemon＠bugs.koha-community.org 22 Jan '19

22 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 --- Comment #35 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 84303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84303&action=ed… Bug 7614: Check transfer limit in CanBookBeReserved and CanItemBeReserved This patch adds $branchcode_to parameter to CanBookBeReserved and CanItemBeReserved. It represents the pickup location for the hold. This patch checks if the library is configured to be a pickup location (see Bug 7534), and also if the item can be transferred into the given library (see Bug 18072). To test: 1. prove t/db_dependent/Holds.t Signed-off-by: Bob Bennhoff <bbennhoff(a)clicweb.org> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7614] Branch transfer limit and holds
by bugzilla-daemon＠bugs.koha-community.org 22 Jan '19

22 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84295|0 |1 is obsolete| | Attachment #84296|0 |1 is obsolete| | Attachment #84297|0 |1 is obsolete| | Attachment #84298|0 |1 is obsolete| | Attachment #84299|0 |1 is obsolete| | Attachment #84300|0 |1 is obsolete| | Attachment #84301|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 84302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84302&action=ed… Bug 7614: Add a new method Koha::Libraries->pickup_locations This patch adds a new method, Koha::Libraries->pickup_locations. This method takes either an item or a biblio as a parameter, and returns the list of acceptable pickup locations by considering libraries' configuration to act as a pickup location as well as any branch transfer limits that may apply. To test: 1. prove t/db_dependent/Koha/Libraries.t Signed-off-by: Bob Bennhoff <bbennhoff(a)clicweb.org> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7614] Branch transfer limit and holds
by bugzilla-daemon＠bugs.koha-community.org 22 Jan '19

22 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7614] Branch transfer limit and holds
by bugzilla-daemon＠bugs.koha-community.org 22 Jan '19

22 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |kyle(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

1 0