January 2019 - Koha-bugs - lists.koha-community.org

[Bug 10562] Improve Leader06 Type Labels in MARC21slim2OPACResults.xsl
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '19

11 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10562 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer(a)inlibro.com --- Comment #3 from Charles Farmer <charles.farmer(a)inlibro.com> --- Patch wouldn't apply anymore, made a small rebase Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10562] Improve Leader06 Type Labels in MARC21slim2OPACResults.xsl
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '19

11 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10562 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76577|0 |1 is obsolete| | --- Comment #2 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 83822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83822&action=ed… Bug 10562: Improve Leader06 Type Labels in MARC21slim2OPACResults.xsl This patch takes the suggestions in Bug 10562 and implements those changes in MARC21slim2OPACResults.xsl. This patch also makes the following changes: - De-duplicate famfamfam icons: Remove the /silk subdirectory and move non-duplicates to famfamfam/; Correct paths to these images in templates and CSS - Improve the granularity of some material type icon choices: Show "Film," "Picture," or "Object" instead of "Visual material." - Remove unnecessary title attributes from material type images - Implement the kind of changes made in Bug 18235, "Add classes to material type icons on result lists and detail pages" -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7960] choice to not show the text labels for item types
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '19

11 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |charles.farmer(a)inlibro.com --- Comment #16 from Charles Farmer <charles.farmer(a)inlibro.com> --- Seems to unfortunately not apply anymore because of additional '| html' filters in the most recent templates. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21813] New: In-page JavaScript causes error on patron entry page
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '19

11 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813 Bug ID: 21813 Summary: In-page JavaScript causes error on patron entry page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 19641 There is an in-page block of JavaScript which should have been dealt with when Bug 19641 moved the template's JavaScript to the footer. Its position on the page causes a JavaScript error because jQuery hasn't loaded yet. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 [Bug 19641] Move patron templates JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 22105] New: opac-detail hides place hold link when items list hidden
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '19

11 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22105 Bug ID: 22105 Summary: opac-detail hides place hold link when items list hidden Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Created attachment 83814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83814&action=ed… Place hold link missing If the item list is too large when opening the opac-detail.pl page, the list is hidden, with a link to view. But while the list is hidden, the Place hold link is hidden. -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 11373] Add "change calculation" feature to the fine payment forms
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '19

11 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13985] Cash Management - Koha as 'Point of Sale'
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '19

11 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11373 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 [Bug 11373] Add "change calculation" feature to the fine payment forms -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add "change calculation" feature to the fine payment forms
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '19

11 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #82 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Works well for me, signing off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add "change calculation" feature to the fine payment forms
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '19

11 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83804|0 |1 is obsolete| | --- Comment #81 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 83813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83813&action=ed… Bug 11373: (follow-up) Add "change calculation" feature to the fine payment forms This patch provides some follow-ups, including corrections to the JavaScript and updates to the text for readability. - Remove obsolete script "type" attribute - Update the use of the obsolete jQuery method "bind" - Use Bootstrap's built-in "show" option instead of simulated click - Handle preventDoubleFormSubmit function's "waiting" class if modal is closed manually To test, apply the patch and follow the original test plan. Everything should work as expected. Note that when the modal is shown, the cursor changes to the "waiting" one when you hover over the body of the page. If you click "No" in the modal, the cursor should return to normal. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add "change calculation" feature to the fine payment forms
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '19

11 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82797|0 |1 is obsolete| | --- Comment #80 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 83812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83812&action=ed… Bug 11373: Show the difference between the amount collected and the amount paid of a fine payment. This patch adds a feature in the fine payment section. It allows to see the change due to patrons when the amount collected is higher than the amount paid. Test plan : - Apply patch. - Select a patron with a fine. - Go to Fines > Pay fines. - Click the button pay. - Choose the amount paid equal to the outstanding amount (exemple : 3$). - Choose the amount collected to be more than the outstanding amount (exemple : 5$). - Confirm that the change is correct (example : 5$ - 3$ = 2$). - Click the button confirm. - Click on Yes in the dialog box. - Confirm that the payment has been made (example : last amount = 3$). Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0