January 2019 - Koha-bugs - lists.koha-community.org

[Bug 15899] New: Remove the use of recordpayment
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '19

10 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 Bug ID: 15899 Summary: Remove the use of recordpayment Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org With recordpayment now simply being a wrapper round Koha::Account::pay, we can remove the calls to recordpayment and replace them with direct calls to Koha::Account::pay. -- You are receiving this mail because: You are watching all bug changes.

1 25

[Bug 18580] New: Account-pay does not apply credits / clear old fines as did recordpayment
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '19

10 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18580 Bug ID: 18580 Summary: Account-pay does not apply credits / clear old fines as did recordpayment Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: colin.campbell(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com the recordpayment routine in C4::Accounts cleared old paid fines and applied credit amounts as part of its pay routine. The behaviour was implicit and not signalled or commented in the code. The pay routine in Koha::Account which is now called by paycollect.pl instead of the old routine does not leaving these on the users fine display although they owe 0. Staff cannot manually remove these. For example a user has the following accountlines +-----------+-------------+-------------------+ | amount | accounttype | amountoutstanding | +-----------+-------------+-------------------+ | -1.300000 | C | -1.300000 | | 0.650000 | Res | 0.650000 | | 0.650000 | Res | 0.650000 | | 0.650000 | Res | 0.650000 | +-----------+-------------+-------------------+ after recordpayment has been called with an amount of 0.65 the lines are +-----------+-------------+-------------------+ | amount | accounttype | amountoutstanding | +-----------+-------------+-------------------+ | -1.300000 | C | 0.000000 | | 0.650000 | Res | 0.000000 | | 0.650000 | Res | 0.000000 | | 0.650000 | Res | 0.000000 | | -0.650000 | Pay | 0.000000 | +-----------+-------------+-------------------+ However now calling Account->pay for the same amount results in +-----------+-------------+-------------------+ | amount | accounttype | amountoutstanding | +-----------+-------------+-------------------+ | -1.300000 | C | -1.300000 | | 0.650000 | Res | 0.000000 | | 0.650000 | Res | 0.650000 | | 0.650000 | Res | 0.650000 | | -0.650000 | Pay | 0.000000 | +-----------+-------------+-------------------+ leaving the credit and two fines with an amountoutstanding although the user has nothing to pay (the amountoutstanding columns sum to 0) and leading to misleading displays. The difference is driven by the line where @outstanding_fines is retrieved the selection is amountoutstanding > 0. In recordpayment it was amountoutstanding <> 0 so that negative amounts were included and processed as part of the payment, rather than ignored. The fact that this implicit behaviour was not commented made it easy to miss. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 11

[Bug 22059] New: Wrong exception parameters in Koha::Patron->set_password
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '19

10 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22059 Bug ID: 22059 Summary: Wrong exception parameters in Koha::Patron->set_password Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Exception::Class requires parameters to be passed as a list instead of a hashref. Then this is wrong: Koha::Exceptions::Password::TooShort->throw({ length => $password_length, min_length => $min_length }); this is ok: Koha::Exceptions::Password::TooShort->throw( length => $password_length, min_length => $min_length ); This is a minor issue anyway, preventing exceptions from being stringified correctly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 15

[Bug 21788] New: C4::Circulation::ProcessOfflinePayment should pass library_id to ->pay
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '19

10 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788 Bug ID: 21788 Summary: C4::Circulation::ProcessOfflinePayment should pass library_id to ->pay Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Bug 19066 introduces the new column. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 21786] New: Routes for credits should include library_id
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '19

10 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21786 Bug ID: 21786 Summary: Routes for credits should include library_id Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST api Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 26

[Bug 22093] New: unable to enter password
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '19

10 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22093 Bug ID: 22093 Summary: unable to enter password Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Project website Assignee: wizzyrea(a)gmail.com Reporter: divya.divya145(a)gmail.com Target Milestone: --- Password mismatch occur -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 13412] Allow configuration of auto-created authorities
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '19

10 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13412 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9069] Make it possible to import MARC21 authorities from VIAF into Koha
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '19

10 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9069 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21334] New: Add bibliographic content type definitions
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '19

10 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21334 Bug ID: 21334 Summary: Add bibliographic content type definitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST api Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com Biblio and authority records need some content-type definitions to be added to the Mojolicious startup code: - 'application/marcxml+xml' - 'application/marc-in-json' - 'application/marc' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 25

[Bug 14476] Improving opac-search performances
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '19

10 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14476 --- Comment #9 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to David Cook from comment #8) > (In reply to Tomás Cohen Arazi from comment #7) > > (In reply to Fridolin SOMERS from comment #5) > > > This will also avoid indexing all record on item circulation. > > > > Not sure about it, but we could certainly index items and make JOIN > > operations in our queries ;-) (for limits, as David also suggests). > > I was totally thinking about that, as I was thinking about Solr query joins. > I imagine ElasticSearch must be able to do the same thing, although I don't > think Zebra could. Or did you have something in mind for JOIN operations? I was thinking ES. Zebra support is in freeze mode. And I'm sure you cannot mix different databases on a query. -- You are receiving this mail because: You are watching all bug changes.

1 0