January 2019 - Koha-bugs - lists.koha-community.org

[Bug 21813] New: In-page JavaScript causes error on patron entry page
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '19

11 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813 Bug ID: 21813 Summary: In-page JavaScript causes error on patron entry page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 19641 There is an in-page block of JavaScript which should have been dealt with when Bug 19641 moved the template's JavaScript to the footer. Its position on the page causes a JavaScript error because jQuery hasn't loaded yet. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 [Bug 19641] Move patron templates JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 22105] New: opac-detail hides place hold link when items list hidden
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '19

11 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22105 Bug ID: 22105 Summary: opac-detail hides place hold link when items list hidden Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Created attachment 83814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83814&action=ed… Place hold link missing If the item list is too large when opening the opac-detail.pl page, the list is hidden, with a link to view. But while the list is hidden, the Place hold link is hidden. -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 11373] Add "change calculation" feature to the fine payment forms
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '19

11 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13985] Cash Management - Koha as 'Point of Sale'
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '19

11 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11373 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 [Bug 11373] Add "change calculation" feature to the fine payment forms -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add "change calculation" feature to the fine payment forms
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '19

11 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #82 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Works well for me, signing off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add "change calculation" feature to the fine payment forms
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '19

11 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83804|0 |1 is obsolete| | --- Comment #81 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 83813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83813&action=ed… Bug 11373: (follow-up) Add "change calculation" feature to the fine payment forms This patch provides some follow-ups, including corrections to the JavaScript and updates to the text for readability. - Remove obsolete script "type" attribute - Update the use of the obsolete jQuery method "bind" - Use Bootstrap's built-in "show" option instead of simulated click - Handle preventDoubleFormSubmit function's "waiting" class if modal is closed manually To test, apply the patch and follow the original test plan. Everything should work as expected. Note that when the modal is shown, the cursor changes to the "waiting" one when you hover over the body of the page. If you click "No" in the modal, the cursor should return to normal. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add "change calculation" feature to the fine payment forms
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '19

11 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82797|0 |1 is obsolete| | --- Comment #80 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 83812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83812&action=ed… Bug 11373: Show the difference between the amount collected and the amount paid of a fine payment. This patch adds a feature in the fine payment section. It allows to see the change due to patrons when the amount collected is higher than the amount paid. Test plan : - Apply patch. - Select a patron with a fine. - Go to Fines > Pay fines. - Click the button pay. - Choose the amount paid equal to the outstanding amount (exemple : 3$). - Choose the amount collected to be more than the outstanding amount (exemple : 5$). - Confirm that the change is correct (example : 5$ - 3$ = 2$). - Click the button confirm. - Click on Yes in the dialog box. - Confirm that the payment has been made (example : last amount = 3$). Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add "change calculation" feature to the fine payment forms
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '19

11 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #79 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 83804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83804&action=ed… Bug 11373: (follow-up) Add "change calculation" feature to the fine payment forms This patch provides some follow-ups, including corrections to the JavaScript and updates to the text for readability. - Remove obsolete script "type" attribute - Update the use of the obsolete jQuery method "bind" - Use Bootstrap's built-in "show" option instead of simulated click - Handle preventDoubleFormSubmit function's "waiting" class if modal is closed manually To test, apply the patch and follow the original test plan. Everything should work as expected. Note that when the modal is shown, the cursor changes to the "waiting" one when you hover over the body of the page. If you click "No" in the modal, the cursor should return to normal. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add "change calculation" feature to the fine payment forms
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '19

11 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21796] New: Patron Restriction do not restrict checkouts if patron also has a fee/fine on their account
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '19

11 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Bug ID: 21796 Summary: Patron Restriction do not restrict checkouts if patron also has a fee/fine on their account Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: kelly(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Created attachment 82109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82109&action=ed… with both restriction and fine, checkout box is visible. Prior behavior: when a patron has a restriction added to their account, the ability of checking out has been removed. The checkout box is replaced by a "View restriction" box and an "Override Restriction Temporarily" box option. If Override is chosen, then the patron's checkout box will reappear for that session. Currently in Koha 18.05.05, when a patron has a restriction, this behavior described above happens correctly. However, if a patron also has a fine of a dollar amount in addition to the restriction, the checkout box is now visible allowing checkouts to occur. The fine/fee amount can be any amount- this does not seem to correlate with the noissuecharge system preference. For an example, system preference Noissuecharge set at 20.00, the value of $2.00 fine was attached to the patron and a restriction, the checkout box still appeared. If a fine/fee was above the noissuecharge, this same behavior occurred- the checkout box appears. See screenshot of bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 21