January 2019 - Koha-bugs - lists.koha-community.org

[Bug 14576] Allow arbitrary automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 07 Jan '19

07 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #97 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 83697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83697&action=ed… Bug 14576: Unit tests To test: 1 - prove -v t/db_dependent/Circulation/Returns.t 2 - prove -v t/db_dependent/Circulation/issue.t 3 - prove -v t/db_dependent/UsageStats.t 4 - All should pass Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow arbitrary automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 07 Jan '19

07 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83113|0 |1 is obsolete| | Attachment #83114|0 |1 is obsolete| | Attachment #83115|0 |1 is obsolete| | --- Comment #96 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 83696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83696&action=ed… Bug 14576: Allow arbitrary automatic update of location on checkin This patch adds a new syspref "UpdateItemLocationOnCheckin" which accepts pairs of shelving locations. On check-in the items location is compared ot the location on the left and, if it matches, is updated to the location on the left. This preference replaces ReturnToShelvingCart and InProcessingToShelvingCart preferences. The update statement should insert values that replciate these functions. Note existing functionality of all items in PROC location being returned to permanent_location is preserved by default. Also, any items issued from CART location will be returned to their permanent location on issue (if it differs) Special values for this pref are: _ALL_ - used on left side only to affect all items _BLANK_ - used on either side to match on/set to blank (actual blanks will work, but this is an easier to read option) _PERM_ - used on right side only to return items to permanent location Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateitemLocationOnCheckin to the following (assuming sample data): NEW: FIC FIC: GEN 4) Create an item, set its location to NEW 5) Check in the item, note its location is now FIC 6) Check in the item again, note its location is now GEN 7) Check in the item again, note its location remains GEN 8) Test using _ALL_, _BLANK_ and _PERM_ for updates 9) Try entering various incorrect syntax in the pref and note you are warned Sponsored by: Arcadia Public Library (http://library.ci.arcadia.ca.us/) Middletown Township Public Library (http://www.mtpl.org/) Round Rock Public Library (https://www.roundrocktexas.gov/departments/library/) Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21745] New: Checkin of withdrawn items marked successful via SIP2 when BlockReturnOfWithdrawnItems is enabled
by bugzilla-daemon＠bugs.koha-community.org 07 Jan '19

07 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21745 Bug ID: 21745 Summary: Checkin of withdrawn items marked successful via SIP2 when BlockReturnOfWithdrawnItems is enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com To recreate: 1 - Mark an item withdrawn 2 - Set up sip server: https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 3 - Set 'BlockReturnOfWithdrawnItems' to block 4 - Use the sip_cli_emulator to checkin the withdrawn item 5 - There is no error in the checkin -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 7

[Bug 14576] Allow arbitrary automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 07 Jan '19

07 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #95 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Josef Moravec from comment #89) > Nick, why do you prefer to _ALL_ rule override everything? Shouldn't the > most specific rule be the first taken into account and _ALL_ rule used as > fallback? I imagine it could simplify the setting on systems with many > locations. I suppose my thought was that _ALL_ could be used to circumvent all others in a scenario where you had a closing or something. I am not sure I envisioned a scenario where ALL would be used constantly -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9606] If you export to Ris the page information is not included
by bugzilla-daemon＠bugs.koha-community.org 07 Jan '19

07 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9606 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de Severity|enhancement |normal --- Comment #1 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- This is still valid for RIS at least. It might require some "clever" guessing as the page information is stored in a non-structured way in 773$g (also: mutli-lingual: German S., English p.) and RIS expects start (SP) and end page (EP) in separate lines. I consider this a bug and not an enhancement as the information is vital for articles. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13618] Add additional template filter methods and a filter presence test to Koha
by bugzilla-daemon＠bugs.koha-community.org 07 Jan '19

07 Jan '19

1 0

[Bug 8426] Diacritics not being mapped for searching (Non-ICU)
by bugzilla-daemon＠bugs.koha-community.org 07 Jan '19

07 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8426 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle.m.hall(a)gmail.com |koha-bugs(a)lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 8426] Diacritics not being mapped for searching (Non-ICU)
by bugzilla-daemon＠bugs.koha-community.org 07 Jan '19

07 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8426 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Nick Clemens from comment #11) > (In reply to Owen Leonard from comment #9) > > Is this patch still relevant? Comments here are contradictory. If this > > should still be tested please provide a detailed test plan. > > Still relevant, plan for Kyle's patch is similar to follow-up: > > 1 - Import the sample record > 2 - Search for Zhar-ptitsa > 3 - No result > 4 - Apply patch > 5 - You may need to cp word-phrase-utf.chr from > /home/vagrant/kohaclone/etc/zebradb/etc/word-phrase-utf.chr to > /etc/koha/zebradb/etc/word-phrase-utf.chr > (backup your original first) > 6 - Reindex zebra > 7 - Search again, you should get result Z problems moved to bug 22073 as the patches for original issue don't seem to work -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8426] Diacritics not being mapped for searching (Non-ICU)
by bugzilla-daemon＠bugs.koha-community.org 07 Jan '19

07 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8426 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81722|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21686] New: Koha::Account->pay has no tests
by bugzilla-daemon＠bugs.koha-community.org 07 Jan '19

07 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21686 Bug ID: 21686 Summary: Koha::Account->pay has no tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Everything in the Koha namespace should be properly tested.. but Koha::Account has a number of methods that are missing corresponding tests. -- You are receiving this mail because: You are watching all bug changes.

1 3