January 2019 - Koha-bugs - lists.koha-community.org

[Bug 13515] Table messages is missing FK constraints and is never cleaned up
by bugzilla-daemon＠bugs.koha-community.org 07 Jan '19

07 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 --- Comment #11 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- (In reply to Nick Clemens from comment #10) > The update doe snot appear to be idempotent - can you check the condition? > Yep. Constraint nameis wrong in foreign_key_exists call. Need a follow-up -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14759] Replacement for Text::Unaccent
by bugzilla-daemon＠bugs.koha-community.org 06 Jan '19

06 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 --- Comment #32 from David Cook <dcook(a)prosentient.com.au> --- Went to the Australia mirror... http://ftp.au.debian.org/debian/pool/main/libt/libtext-unaccent-perl/ http://ftp.au.debian.org/debian/pool/main/libt/libtext-unaccent-perl/libtex… Patch looks consistent with the following: https://bugs.launchpad.net/ubuntu/+source/libtext-unaccent-perl/+bug/460640 https://rt.cpan.org/Public/Bug/Display.html?id=21177 I don't think the maintainer has done anything on CPAN or Debian for many years. Looks like other Debian folk fixed the Debian package, and CPAN is just abandoned. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14759] Replacement for Text::Unaccent
by bugzilla-daemon＠bugs.koha-community.org 06 Jan '19

06 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 --- Comment #31 from David Cook <dcook(a)prosentient.com.au> --- In any case, this seems like a major sticking point for anyone not using Debian-based distros. For now, I'm just removing Text::Unaccent where necessary. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14759] Replacement for Text::Unaccent
by bugzilla-daemon＠bugs.koha-community.org 06 Jan '19

06 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 --- Comment #30 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Colin Campbell from comment #25) > Text::Unaccent does not build on 64bit systems, the tests fail because of > errors in the ccode. There has been a patch for that for four years but it > looks like the upstream code is moribund. If you look at the test results it > now fails on all linux test builds. The module has not been kept up to date > to handle modern perl strings. I think the debian version may be patched to > fix the bug in 64bit tests but it is buggy and should not be relied on. > Suggest moving to Text::Unaccent::PurPerl be prioritized I just ran into this again. Can't build on a 64 bit system running Perl 5.26. If you do force the build and install, you'll just get difficult to diagnose 500 errors in Koha. As Colin mentioned, there's been known issues for this for ages: https://rt.cpan.org/Public/Dist/Display.html?Name=Text-Unaccent I've gone to https://packages.debian.org/stretch/libtext-unaccent-perl to see if I can find the patch that Debian uses. I reckon http://deb.debian.org/debian/pool/main/libt/libtext-unaccent-perl/libtext-u… is the patch but the Debian CDN keeps timing out on me. When I try with curl, it seems like the CDN is refusing connections on port 80 and 443, so something looks like it's up with Debian... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14393] Add collection code filter to inventory
by bugzilla-daemon＠bugs.koha-community.org 06 Jan '19

06 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393 --- Comment #22 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Charles Farmer from comment #21) > Merging seems to fail because of HTML filters and whatnot, pretty expected > from a 2015 patch. Thanks for checking, Charles. Looks like the patch is 9474 commits behind master. Let me try rebasing it. Not a trivial rebase at a glance. Will have to look at this more some other time. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15174] Allow borrowers to be members of additional categories
by bugzilla-daemon＠bugs.koha-community.org 05 Jan '19

05 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15174 cfhong2000(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cfhong2000(a)gmail.com --- Comment #9 from cfhong2000(a)gmail.com --- Hi, Can this patch be applied to Koha 18.05? If so, how do I apply this patch? Thanks, Chee -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13654] Cannot place a hold for biblio with too many items to display unless viewing them all
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13654 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer(a)inlibro.com --- Comment #11 from Charles Farmer <charles.farmer(a)inlibro.com> --- In the case where neither CountItemsIssued nor $biblio->has_items_waiting_or_intransit return 1, pushing AllowOnShelfHolds => 1 to the template doesn't seem enough, since the ReservableItems variable wouldn't have been initialized in opac-details.pl. On my end, at least, this means that I'm still not able to see the 'Place hold' button after applying the patch. I would suggest either also sending ReservableItems to the template, or simply setting $allow_onshelf_holds = 1. Still a bit too early to put this as Failed QA, as I'm not a QA person myself, but the patch doesn't feel quite right. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 --- Comment #26 from Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> --- Your test plan works and it doesn't seem there's a problem with the extended steps either. Sorry, for the mistakes I made while editing the page, I will try to be more focus next time. :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #25 from Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> --- (In reply to Pierre-Marc Thibault from comment #22) > Created attachment 83669 [details] [review] > Bug 10676: Add unit tests - GetItemsInfo > > To test: > prove t/db_dependent/Items.t > > Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault(a)inLibro.com> > > https://bugs.koha-community.org/show_bug.cgi?id=22053 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83669|0 |1 is obsolete| | --- Comment #24 from Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> --- Created attachment 83671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83671&action=ed… Bug 10676: Add unit tests - GetItemsInfo To test: prove t/db_dependent/Items.t Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault(a)inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0