January 2019 - Koha-bugs - lists.koha-community.org

[Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 --- Comment #26 from Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> --- Your test plan works and it doesn't seem there's a problem with the extended steps either. Sorry, for the mistakes I made while editing the page, I will try to be more focus next time. :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #25 from Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> --- (In reply to Pierre-Marc Thibault from comment #22) > Created attachment 83669 [details] [review] > Bug 10676: Add unit tests - GetItemsInfo > > To test: > prove t/db_dependent/Items.t > > Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault(a)inLibro.com> > > https://bugs.koha-community.org/show_bug.cgi?id=22053 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83669|0 |1 is obsolete| | --- Comment #24 from Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> --- Created attachment 83671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83671&action=ed… Bug 10676: Add unit tests - GetItemsInfo To test: prove t/db_dependent/Items.t Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault(a)inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83668|0 |1 is obsolete| | --- Comment #23 from Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> --- Created attachment 83670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83670&action=ed… Bug 10676: Fix behaviour of OpacHiddenItems for items.restricted The numerical restricted value was overwritten in GetItemsInfo with the description. So OpacHiddenItems would only work for restricted using the description, not the numerical value of the authorised value like for other similar status fields. This changes GetItemsInfo to use a separate variable for the description, as it's already done for notforloan and changes the template files where the variable is used accordingly. To test - Before applying patch - Configure OpacHiddenItems with: restricted: [1] - Find a record with more than one item and mark one of the items as "Restricted Access" (assume standard sample data - check authorised value if status doesn't exist) - Verify the item is still shown in OPAC. - Apply patch - Verify that the item is now hidden - Verify that the status still displays nicely in the staff detail page - Delete OpacHiddenItems - Verify that the status is showing nicely in the OPAC detail page Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault(a)inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14393] Add collection code filter to inventory
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer(a)inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #21 from Charles Farmer <charles.farmer(a)inlibro.com> --- Merging seems to fail because of HTML filters and whatnot, pretty expected from a 2015 patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83631|0 |1 is obsolete| | --- Comment #22 from Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> --- Created attachment 83669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83669&action=ed… Bug 10676: Add unit tests - GetItemsInfo To test: prove t/db_dependent/Items.t Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault(a)inLibro.com> https://bugs.koha-community.org/show_bug.cgi?id=22053 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83630|0 |1 is obsolete| | --- Comment #21 from Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> --- Created attachment 83668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83668&action=ed… Bug 10676: Fix behaviour of OpacHiddenItems for items.restricted The numerical restricted value was overwritten in GetItemsInfo with the description. So OpacHiddenItems would only work for restricted using the description, not the numerical value of the authorised value like for other similar status fields. This changes GetItemsInfo to use a separate variable for the description, as it's already done for notforloan and changes the template files where the variable is used accordingly. To test - Before applying patch - Configure OpacHiddenItems with: restricted: [1] - Find a record with more than one item and mark one of the items as "Restricted Access" (assume standard sample data - check authorised value if status doesn't exist) - Verify the item is still shown in OPAC. - Apply patch - Verify that the item is now hidden - Verify that the status still displays nicely in the staff detail page - Delete OpacHiddenItems - Verify that the status is showing nicely in the OPAC detail page Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault(a)inLibro.com> https://bugs.koha-community.org/show_bug.cgi?id=22053 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10676] OpacHiddenItems not working for restricted on OPAC detail
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OpacHiddenItems not working |OpacHiddenItems not working |for restricted |for restricted on OPAC | |detail --- Comment #20 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- If I understood correctly, you can still sign off. This deals with the case, that not all items on a record are hidden and the OPAC detail pages. You could extend the test plan a bit: - Verify that if the restricted item is the only item, the record cannot be found in the OPAC - Verfy you can't access the record directly by URL - Verify the item information in the results is correct >From what Joy said those already work, but should not be broken by the patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10676] OpacHiddenItems not working for restricted
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 --- Comment #19 from Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> --- I didn't complete the test since there is a current conversation involving Joy which let me think there is a problem that is not in the test plan and that would make my sign off meaningless. I am wrong? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10676] OpacHiddenItems not working for restricted
by bugzilla-daemon＠bugs.koha-community.org 04 Jan '19

04 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 --- Comment #18 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Joy, thx for checking again! I'd need to investigate a bit more, but it's possible the code for hiding the record is using a slightly different logic. Koha is always fun ;) Pierre, is it working ok now for you? -- You are receiving this mail because: You are watching all bug changes.

1 0