January 2019 - Koha-bugs - lists.koha-community.org

[Bug 17138] New: UpdateFine() modyfies existing fine records even when there is no need
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '24

19 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138 Bug ID: 17138 Summary: UpdateFine() modyfies existing fine records even when there is no need Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: abl(a)biblos.pk.edu.pl QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com In C4/Overdues.pm: 574: # we're updating an existing fine. Only modify if amount changed 577: if ( $data->{'amount'} != $amount ) { for some numbers (e.g. 5.60) the comparison in line 577 fails ($data->{'amount'} is decimal(28,6) i.e. a string, and $amount may be a floating point number with no exact binary representation). E.g. when the fine amounts are multiple of 0.20, it fails for the 33.3% of the amounts (on average). Depending on the fine charging settings, this may trigger unnecessary database writes (and a lot of them). If 'Fine Charging Interval' is 1 day, this has very little practical consequences (misc/cronjobs/fines.pl script is usually run once per day, and all fines need an increase anyway). But if the charging interval is longer, e.g. 7 days, in a given day amount changes only for the 1/7 of the fines (again, on average), and over 60% of the database writes would be redundant. To reproduce: 1) run misc/cronjobs/fines.pl 2) add warn "AMOUNT ".$data->{'amount'}." vs $amount"; below line 577 in C4/Overdues.pm 3) run misc/cronjobs/fines.pl again 4) you'll see some warnings like 'AMOUNT 5.600000 vs 5.6' or: dump accountlines table after step 1), run the script 2nd time, dump the table again and compare the contents - some of the records would have a different timestamp. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 38

[Bug 20202] New: Link EDI account to Create Edi order
by bugzilla-daemon＠bugs.koha-community.org 12 Dec '24

12 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20202 Bug ID: 20202 Summary: Link EDI account to Create Edi order Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: cunha(a)monterey.org QA Contact: testopia(a)bugs.koha-community.org Currently to send create an EDI order you click "Create EDIFACT order" and are taken to a page to select, if you have multiple EDI accounts, your vendor account from a drop-down menu. It would be great if the Vendor and EDI account could be linked, so there would be no possibility of sending the order to the wrong account. We started with the ByWater beta version of EDI, that was the way it worked in beta. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 5

[Bug 17600] New: Standardize the EXPORT
by bugzilla-daemon＠bugs.koha-community.org 11 Dec '24

11 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 Bug ID: 17600 Summary: Standardize the EXPORT Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org On bug 17591 we discovered that there was something weird going on with the way we export and use subroutines/modules. I tried to standardize our EXPORT to use EXPORT_OK only. -- You are receiving this mail because: You are watching all bug changes.

1 215

[Bug 16694] New: Limit SIP2 auth by patron attribute
by bugzilla-daemon＠bugs.koha-community.org 10 Dec '24

10 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694 Bug ID: 16694 Summary: Limit SIP2 auth by patron attribute Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: magnus(a)libriotech.no Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org In Scandinavia "more open" (Swedish: "Meröppet", Norwegian: "Meråpent") is a hot issue at the moment. What this means is that patrons can use their card and password/PIN to lock themselves into the library even when staff is not around. Typically, this means that patrons can get access to the library building from 7 am to 11 pm, even if the library is only staffed from 8 am to 5 pm. Typically, SIP2 is used to communnicate between the "more open"-system and the ILS, specifically to authenticate the user with a username and password/PIN. Also, you want the ability to turn "more open" access on and off for patrons. An extended patron attribute with possible values of NULL/empty, 0 or 1 should serve well for this. SIP2 does not have a field for saying "this is a moreopen login", so we need a way to identify a SIP2 user as a moreopen user. My plan is to add another attribute to the login element in SIPConfig.xml to achieve this: <login id="koha" password="koha" delimiter="|" error-detect="enabled" institution="kohalibrary" patron-attribute="MEROPPET" /> "MEROPPET" is then the name of an extended patron attribute which can be set to NULL or 0 (patron should not have access to moreopen) or 1 (patron should have access). This should be flexible enough to allow other, similar schemes to use some other patron attribute. -- You are receiving this mail because: You are watching all bug changes.

1 43

[Bug 17976] New: TT syntax for notices - Add an equivalence for items.fine
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '24

06 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17976 Bug ID: 17976 Summary: TT syntax for notices - Add an equivalence for items.fine Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org The items.fine is a trick of our historical syntax. We need to provide a way to access this value from the a notice template using the TT syntax. -- You are receiving this mail because: You are watching all bug changes.

1 39

[Bug 18397] New: Sent notices for...: Display email address ( including which field it's taken from)
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '24

05 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18397 Bug ID: 18397 Summary: Sent notices for...: Display email address (including which field it's taken from) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org Display in Home > Patrons > Sent notices for... the email address and the field where it is taken from. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 37

[Bug 18885] New: Onsite Checkout has a weird behaviour concerning sticky due date
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '24

05 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18885 Bug ID: 18885 Summary: Onsite Checkout has a weird behaviour concerning sticky due date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: baptiste.wojtkowski(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When you perform an onsite checkout, the next checkout is pre-setted as follows: - Specify due date => today - Onsite checkout => not checked I don't think this is is a correct behaviour: according to me there are 3 solutions, but I don't know which is the best: - Maintaining "onsite checkout" checked - Don't change duedatespec in interface when onsite checout is clicked and process it in the intranet part - Remove the duedatespec on the new checkout page loading This part of the code is really hard for me since it were patched and re patched and I'm not sure of the expected behaviour of all lines, so I would like some expert opinion before coding a solution -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 22

[Bug 17628] New: Move bibliographic related code to Koha::Biblio
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '24

05 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628 Bug ID: 17628 Summary: Move bibliographic related code to Koha::Biblio Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 31

[Bug 21114] New: Select multiple item rows with Ctrl+click and Shift+click
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '24

04 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21114 Bug ID: 21114 Summary: Select multiple item rows with Ctrl+click and Shift+click Change sponsored?: --- Product: Koha Version: unspecified Hardware: PC OS: Windows Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: dimantonak(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Currently, if you want to select multiple items in "Edit items in batch" you have to click (check) per item. It would be great and time saving to add the ability to multiple select the items using Ctrl+click and Shift+click using some javascript code. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 20988] New: Internationalization: wrap all translatable text inside t() calls
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '24

04 Dec '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988 Bug ID: 20988 Summary: Internationalization: wrap all translatable text inside t() calls Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: julian.maurice(a)biblibre.com Reporter: julian.maurice(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr Depends on: 15395 Bug 15395's Koha::I18n is working well, but it is basically useless until we wrap all the translatable strings inside __*() calls (or t*() calls inside templates). This bug aims to do that. I wrote a little tool to automatically find and replace translatable text by the corresponding call. It can be found here : https://github.com/jajm/koha-i18n. This bug will hold a few patches that will make koha-i18n work better and I'll try to attach all the changes it does. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 [Bug 15395] Internationalization: plural forms, context, and more -- You are receiving this mail because: You are watching all bug changes.

1 81