October 2019 - Koha-bugs - lists.koha-community.org

[Bug 23038] New: Expected warnings displayed by tests
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '19

15 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23038 Bug ID: 23038 Summary: Expected warnings displayed by tests Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 22908, 22049 Target Milestone: --- When tests are ran, there are 2 warnings that are expected and raised by DBI. As they are expected they must be correctly caught and not displayed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 [Bug 22049] MarkIssueReturned should rely on returndate only https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22908 [Bug 22908] Modsuggestion will generate a notice even if the modification failed -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 9181] Add patron messaging preference to Batch Patrons Modification tool
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '19

15 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9181 Sally <sally.healey(a)cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '19

15 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #215 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- One last followup. We were still referencing a relative path for the pqf.properties file from inside the config.xml and this was not resolving correctly. After a little more digging I spotted that 'cql2rpn' should always be 'relative to the working directory', but under a daemon start the working directory was not being set correctly. One can, however, pass a `-w` to the daemon to explicitly set working directory and as such make relative paths (from the config file directory) work as expected. Ere, this gets the tests passing again in my koha-testing-docker instance and also in my local environment but it might be worth double-checking at your end whether things will continue to work in your live environments.. I have a hunch you're using full paths in your config files there (or perhaps YAZ5 just does a much better job of detecting working directory in the first place for you). Pushed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '19

15 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #214 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 94209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94209&action=ed… Bug 13937: (RM follow-up) Set working directory for daemon mode. When running as a daemon under Net::Z3950::SimpleServer YAZ requires a little help to know where it's "working directory" is located so relative paths in config files may resolve correctly. This patch passes the working directory as prescribed on https://software.indexdata.com/yaz/doc/server.invocation.html such that the resolution of the cql2rpn filepath works as expected in tests. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '19

15 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #39 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 94208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94208&action=ed… Bug 15522: Replace the obsoleted fixFloat occurrence to use Sticky -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '19

15 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #38 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 94207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94207&action=ed… Bud 15522: Restore categories filtering Mimicking what is done for Branches -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '19

15 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #37 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 94206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94206&action=ed… Bug 15522: Fix permission name manage_circ_rules_from_any_libraries On 15520 followups have been provided to not use a negative permission. Note that two api tests are failing (get 400). I would like some help to investigate here why 400 is returned instead of 403. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '19

15 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #36 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 94205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94205&action=ed… Bug 15522: Add yarn.lock (autogenerated) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '19

15 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #35 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 94204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94204&action=ed… Bug 15522: Remove old circulation rules interface -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '19

15 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #34 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 94203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94203&action=ed… Bug 15522: New interface for updated circulation rules Test plan: 1) Make sure all dependencies are applied, and that their DB upgrades have been applied. 2) Build JS (see previous patches for HOWTO). 3) Load .../cgi-bin/koha/admin/policy.pl . 4) Try changing an existing rule (one with a textbox or dropdown). Hit "Save rules", ensure that your changes are saved. 5) Until changes are saved, all cells that are changed or affected by your changes should be highlighted in yellow. 6) Same as above, but deleting a rule by hitting the "x" next to it. 7) Add rows and columns using the "Choose rule..." and "Choose category/item type..." dropdowns. 8) Add rules by clicking the pencil in a currently unset rule cell. Ensure changes are saved. 9) Hit "Cleanup rules"; all redundant rules should be removed. As this only removes rules that are the same as the defaults, this should not change any effective rules. 10) Use the filters at the top right ("Circulation", "Holds" and "Fines") to filter the kinds of rules that are shown. 11) Ensure that any desired library can be shown, including (if selected) all at the same time. JD edits: Removed the changes to filtered categories, will be done in a follow-up -- You are receiving this mail because: You are watching all bug changes.

1 0