October 2019 - Koha-bugs - lists.koha-community.org

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '19

15 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #33 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 94202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94202&action=ed… Bug 15522: Add JS build pipeline This is not directly testable, but can be either used through the Makefile: $ make js-build (This will automatically install all dependencies.) Or by manually installing yarn: $ sudo apt install nodejs npm $ sudo npm install -g yarn $ yarn install $ yarn build (There is also `make js-watch` and `yarn watch`, which automatically recompile when files are changed.) JD note: the make rule does not work -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '19

15 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91977|0 |1 is obsolete| | Attachment #91978|0 |1 is obsolete| | Attachment #91979|0 |1 is obsolete| | Attachment #91980|0 |1 is obsolete| | Attachment #91981|0 |1 is obsolete| | Attachment #91982|0 |1 is obsolete| | Attachment #91983|0 |1 is obsolete| | Attachment #91984|0 |1 is obsolete| | --- Comment #32 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 94201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94201&action=ed… Bug 15522: Add API for circulation rules Test plan: 1) Run t/db_dependent/api/v1/circ_rules.t . -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '19

15 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15522] New interface for revamped circulation rules
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '19

15 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '19

15 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #213 from Ere Maijala <ere.maijala(a)helsinki.fi> --- Thanks, Martin! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '19

15 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #212 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Thanks so much for all your work here Ere, It's looking great to me now, I've just pushed the final followup and am waiting on Jenkins to go green.. crossed fingers but it all passes locally for me now in the various versions so touch wood Jenkins will be happy too. It's great to have this one in! Martin -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11514] Untranslatable "Uncertain" text in acq
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '19

15 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 --- Comment #11 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I can confirm that: 1) It's a bug fix for the existing behavior: "(Uncertain)" is not longer displayed, because of the use of the Price plugin. 2) We cannot test the second part of the patch. Even if it cannot hurt it may make more sense to remove the code in the controller and don't touch the template file. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '19

15 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #211 from Ere Maijala <ere.maijala(a)helsinki.fi> --- Ok, the latest patch includes a copy of pqf.properties so that no copying needs to be performed. This makes things more simple and avoids possible permission issues with copying. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '19

15 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Ere Maijala <ere.maijala(a)helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94109|0 |1 is obsolete| | --- Comment #210 from Ere Maijala <ere.maijala(a)helsinki.fi> --- Created attachment 94110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94110&action=ed… Bug 13937: (QA follow-up) Make tests work with YAZ 4 and 5. Also makes add_item_status tests more robust by clearing the cache after modifying authorised values. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '19

15 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #209 from Ere Maijala <ere.maijala(a)helsinki.fi> --- (In reply to David Cook from comment #207) > Comment on attachment 94109 [details] [review] > Bug 13937: (QA follow-up) Make tests work with YAZ 4 and 5. > > Review of attachment 94109 [details] [review]: > ----------------------------------------------------------------- > > ::: t/db_dependent/Koha/Z3950Responder/GenericSession.t > @@ +82,5 @@ > > $child = fork(); > > if ($child == 0) { > > my $config_dir = dirname(__FILE__) . '/'; > > + # Copy pqf.properties from etc/z3950 > > + copy($config_dir . '../../../../etc/z3950/pqf.properties', $config_dir . 'pqf.properties') || die "Copying pqf.properties failed: $!"; > > This seems a little fragile to me. I don't know what we're doing in other > scripts, but it might be worth using https://perldoc.perl.org/FindBin.html > here? I'll revise. Actually, would it better to just include a copy of pqf.properties in the test dir? It would also make sure that any changes to the default pqf.properties don't break tests. -- You are receiving this mail because: You are watching all bug changes.

1 0