October 2019 - Koha-bugs - lists.koha-community.org

[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '19

15 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #209 from Ere Maijala <ere.maijala(a)helsinki.fi> --- (In reply to David Cook from comment #207) > Comment on attachment 94109 [details] [review] > Bug 13937: (QA follow-up) Make tests work with YAZ 4 and 5. > > Review of attachment 94109 [details] [review]: > ----------------------------------------------------------------- > > ::: t/db_dependent/Koha/Z3950Responder/GenericSession.t > @@ +82,5 @@ > > $child = fork(); > > if ($child == 0) { > > my $config_dir = dirname(__FILE__) . '/'; > > + # Copy pqf.properties from etc/z3950 > > + copy($config_dir . '../../../../etc/z3950/pqf.properties', $config_dir . 'pqf.properties') || die "Copying pqf.properties failed: $!"; > > This seems a little fragile to me. I don't know what we're doing in other > scripts, but it might be worth using https://perldoc.perl.org/FindBin.html > here? I'll revise. Actually, would it better to just include a copy of pqf.properties in the test dir? It would also make sure that any changes to the default pqf.properties don't break tests. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '19

15 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #208 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Ere Maijala from comment #206) > The last patch should work with both YAZ versions. The real culprit was that > the test requests did not include version parameter, and YAZ 5 defaulted to > a newer SRU version that uses a different namespace. All tests now use > version=1.1 parameter. Additionally, pqf.properties is copied to the test > directory so that a relative path isn't needed in config.xml. Nice one, Ere! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '19

15 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #207 from David Cook <dcook(a)prosentient.com.au> --- Comment on attachment 94109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94109 Bug 13937: (QA follow-up) Make tests work with YAZ 4 and 5. Review of attachment 94109: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=139…) ----------------------------------------------------------------- ::: t/db_dependent/Koha/Z3950Responder/GenericSession.t @@ +82,5 @@ > $child = fork(); > if ($child == 0) { > my $config_dir = dirname(__FILE__) . '/'; > + # Copy pqf.properties from etc/z3950 > + copy($config_dir . '../../../../etc/z3950/pqf.properties', $config_dir . 'pqf.properties') || die "Copying pqf.properties failed: $!"; This seems a little fragile to me. I don't know what we're doing in other scripts, but it might be worth using https://perldoc.perl.org/FindBin.html here? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '19

15 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #206 from Ere Maijala <ere.maijala(a)helsinki.fi> --- The last patch should work with both YAZ versions. The real culprit was that the test requests did not include version parameter, and YAZ 5 defaulted to a newer SRU version that uses a different namespace. All tests now use version=1.1 parameter. Additionally, pqf.properties is copied to the test directory so that a relative path isn't needed in config.xml. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '19

15 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #205 from Ere Maijala <ere.maijala(a)helsinki.fi> --- Created attachment 94109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94109&action=ed… Bug 13937: (QA follow-up) Make tests work with YAZ 4 and 5. Also makes add_item_status tests more robust by clearing the cache after modifying authorised values. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '19

15 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #204 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Ere Maijala from comment #203) > I see. I'll take another stab at trying to make the tests work with both > versions. I can try to help. I'm pretty busy at the moment, so not too keen to spin up a koha-testing-docker and try it out, but if you point me at the test, I can have a look. Martin's already pushed the patches to master, so maybe it doesn't matter too much? Maybe he can clarify things. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '19

15 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #203 from Ere Maijala <ere.maijala(a)helsinki.fi> --- (In reply to David Cook from comment #202) > I think I don't know enough about the particular test in question to really > continue the conversation. I figured it was a case of providing a > configuration value to a function in the test, but it sounds like perhaps > it's a Zebra config file and that it's an integration test, so I see how > that could be tricky. I withdraw my suggestion heh. I value the suggestion, though it wouldn't solve the problem that YAZ 4 and 5 do diagnostics (error handling) differently. I'll see if I can modify the tests to pass on both. > That's an interesting question. Looking at > https://packages.debian.org/search?keywords=yaz, I see YAZ 4 is used in > Jessie and Stretch, but Buster and Bullseye use YAZ 5. I see. I'll take another stab at trying to make the tests work with both versions. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '19

15 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #202 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Ere Maijala from comment #199) > The path is in a config file, so hard-coding it there there doesn't seem > quite proper. It doesn't seem possible to specify it programmatically. > Anyway, it wouldn't help since YAZ 4 and 5 handle some error conditions > differently, unless I remove the offending tests. That's of course possible > too, but I would rather not do that unless it's the last option. > I think I don't know enough about the particular test in question to really continue the conversation. I figured it was a case of providing a configuration value to a function in the test, but it sounds like perhaps it's a Zebra config file and that it's an integration test, so I see how that could be tricky. I withdraw my suggestion heh. > Now, this strays from the main topic a bit, but as far as I can tell last > YAZ 4 release was in 2013. That's pretty ancient. Could we decide not to fix > the tests for such an old version? That's an interesting question. Looking at https://packages.debian.org/search?keywords=yaz, I see YAZ 4 is used in Jessie and Stretch, but Buster and Bullseye use YAZ 5. Perhaps we could specify a YAZ 4 run time dependency and YAZ 5 as a build dependency in the Debian control file? But then we probably should be building on the same OSes that we're supporting at run time, so I think perhaps we do have to support YAZ 4 behaviour until we don't support Debian Stretch anymore? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22545] New: C4::Matcher::get_matches aggressive isbn and issn search don't give any results with ES
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '19

14 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 Bug ID: 22545 Summary: C4::Matcher::get_matches aggressive isbn and issn search don't give any results with ES Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs(a)lists.koha-community.org Reporter: johanna.raisa(a)koha-suomi.fi QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- When using AggressiveMatchOnISBN or AggressiveMatchOnISSN preferences instead of UseQueryParser the search for duplicates fails. ES don't give any results, it seems that the problem is the query string. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 23810] New: upgrade fail when reserves waitting
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '19

14 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23810 Bug ID: 23810 Summary: upgrade fail when reserves waitting Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: hagud(a)orex.es QA Contact: testopia(a)bugs.koha-community.org Koha fails when upgrading a database that cointains value 'W' at reserves.found and there is no expired date, koha fail to upgrade Not a HASH reference at updatedatabase.pl at 14371 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1