October 2019 - Koha-bugs - lists.koha-community.org

[Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '19

07 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen(a)gmail.com |katrin.fischer(a)bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '19

07 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer(a)bsz-bw.de --- Comment #29 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- 1) QA tools fail: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt FAIL filters missing_filter at line 111 ( [% description %]) missing_filter at line 113 ( [% itemtype %]) 2) It looks like this is only implemented for MARC21 (XSLT) - can we please add a note to the system preference description to document that? 3) While you are editing that file... could we shorten the options in the pull down a bit by putting the shared part into the text? Then the pull down would only be: 'Koha biblio level itemtype' and 'MARC control fields'. 4) When there is no itemtype image set, there is nothing displayed. Might be intended behaviour - so just noting. (no blocker) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '19

07 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen <bin.wen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88400|0 |1 is obsolete| | --- Comment #161 from Bin Wen <bin.wen(a)inlibro.com> --- Created attachment 93856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93856&action=ed… Bug 11879: (follow-up) Corrected OPAC and removed unrelated changes Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> Signed-off-by: Bin Wen <bin.wen(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '19

07 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen <bin.wen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88399|0 |1 is obsolete| | --- Comment #160 from Bin Wen <bin.wen(a)inlibro.com> --- Created attachment 93855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93855&action=ed… Bug 11879: Remove unecessary code in controller - adds the field required is defined in BorrowerMandatoryField (staff only) - removes code from controller (not needed, we can follow existing pattern) - does not send patron's attribute separately (we have the 'patron' variable already) Need to be done: - same changes for the OPAC - remove extra changes made to moremember-brief.tt (if bugfix it needs to be moved on a separate bug report) - deal with PatronSelfModificationBorrowerUnwantedField and PatronSelfRegistrationBorrowerUnwantedField I first thought it would have replaced AutoEmailPrimaryAddress, but it actually only needed for display purpose, how/where can we explain that? Are release notes enough? Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> Signed-off-by: Bin Wen <bin.wen(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '19

07 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen <bin.wen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88398|0 |1 is obsolete| | --- Comment #159 from Bin Wen <bin.wen(a)inlibro.com> --- Created attachment 93854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93854&action=ed… Bug 11879: Schema updates Signed-off-by: Lucie Gay <lucie.gay(a)ens-paris-saclay.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> Signed-off-by: Bin Wen <bin.wen(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '19

07 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen <bin.wen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88397|0 |1 is obsolete| | --- Comment #158 from Bin Wen <bin.wen(a)inlibro.com> --- Created attachment 93853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93853&action=ed… Bug 11879: (QA follow-up) Fix problems found in code review Signed-off-by: Lucie Gay <lucie.gay(a)ens-paris-saclay.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> Signed-off-by: Bin Wen <bin.wen(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '19

07 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen <bin.wen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88396|0 |1 is obsolete| | --- Comment #157 from Bin Wen <bin.wen(a)inlibro.com> --- Created attachment 93852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93852&action=ed… Bug 11879: (follow-up) Streamline markup and make label corrections This patch makes minor markup corrections to the patron detail page template: - Simplify the SWITCH markup - Add "primary" to primary phone label - Correct case on label - Add IF statement to hide label if there is no primary contact method Signed-off-by: Lucie Gay <lucie.gay(a)ens-paris-saclay.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> Signed-off-by: Bin Wen <bin.wen(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '19

07 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen <bin.wen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93850|0 |1 is obsolete| | --- Comment #156 from Bin Wen <bin.wen(a)inlibro.com> --- Created attachment 93851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93851&action=ed… Bug 11879: Add the "Main contact method" field in borrower informations. This patch adds the "Main Contact Method" field in the borrower modification form. This field is useful for reporting purposes, or to know which contact method to use first when trying to contact a borrower. Following Nicolas' fix, removed a $branch variable from patch, since it has been suppressed in Bug 17284. Test case : * Edit a borrower's informations. The "Main Contact Method" selectbox should appear in the form and its value should be saved correctly. Sponsored-by: CCSR <http://www.ccsr.qc.ca> Signed-off-by: Lucie Gay <lucie.gay(a)ens-paris-saclay.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> Signed-off-by: Bin Wen <bin.wen(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '19

07 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen <bin.wen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |bin.wen(a)inlibro.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '19

07 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen <bin.wen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88395|0 |1 is obsolete| | --- Comment #155 from Bin Wen <bin.wen(a)inlibro.com> --- Created attachment 93850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93850&action=ed… Bug 11879: Add the "Main contact method" field in borrower informations. This patch adds the "Main Contact Method" field in the borrower modification form. This field is useful for reporting purposes, or to know which contact method to use first when trying to contact a borrower. Following Nicolas' fix, removed a $branch variable from patch, since it has been suppressed in Bug 17284. Test case : * Edit a borrower's informations. The "Main Contact Method" selectbox should appear in the form and its value should be saved correctly. Sponsored-by: CCSR <http://www.ccsr.qc.ca> Signed-off-by: Lucie Gay <lucie.gay(a)ens-paris-saclay.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> Signed-off-by: Bin Wen <bin.wen(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0